[INFO] fetching crate toad-stem 1.0.0-beta.3... [INFO] checking toad-stem-1.0.0-beta.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate toad-stem 1.0.0-beta.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate toad-stem 1.0.0-beta.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate toad-stem 1.0.0-beta.3 [INFO] finished tweaking crates.io crate toad-stem 1.0.0-beta.3 [INFO] tweaked toml for crates.io crate toad-stem 1.0.0-beta.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4beff1740eebb5ffdaeb8332eeaacd874750c66f63cbd8edf7d170ee540d2b01 [INFO] running `Command { std: "docker" "start" "-a" "4beff1740eebb5ffdaeb8332eeaacd874750c66f63cbd8edf7d170ee540d2b01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4beff1740eebb5ffdaeb8332eeaacd874750c66f63cbd8edf7d170ee540d2b01", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4beff1740eebb5ffdaeb8332eeaacd874750c66f63cbd8edf7d170ee540d2b01", kill_on_drop: false }` [INFO] [stdout] 4beff1740eebb5ffdaeb8332eeaacd874750c66f63cbd8edf7d170ee540d2b01 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 764c16eab803f31d8a708d26fd31684f516fa29f5a414090505a147355b7d05b [INFO] running `Command { std: "docker" "start" "-a" "764c16eab803f31d8a708d26fd31684f516fa29f5a414090505a147355b7d05b", kill_on_drop: false }` [INFO] [stderr] Checking toad-stem v1.0.0-beta.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `RwLockReadGuard<'_, T>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:112:7 [INFO] [stdout] | [INFO] [stdout] 109 | fn map_ref(&self, mut f: F) -> R [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | f(self.read().unwrap().deref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockWriteGuard<'_, T>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:7 [INFO] [stdout] | [INFO] [stdout] 115 | fn map_mut(&self, mut f: F) -> R [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | f(self.write().unwrap().deref_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, T>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:130:7 [INFO] [stdout] | [INFO] [stdout] 127 | fn map_ref(&self, mut f: F) -> R [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | f(self.borrow().deref()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, T>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:136:7 [INFO] [stdout] | [INFO] [stdout] 133 | fn map_mut(&self, mut f: F) -> R [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | f(self.borrow_mut().deref_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `toad-stem` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `RwLockReadGuard<'_, T>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:112:7 [INFO] [stdout] | [INFO] [stdout] 109 | fn map_ref(&self, mut f: F) -> R [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | f(self.read().unwrap().deref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RwLockWriteGuard<'_, T>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:118:7 [INFO] [stdout] | [INFO] [stdout] 115 | fn map_mut(&self, mut f: F) -> R [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | f(self.write().unwrap().deref_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ref<'_, T>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:130:7 [INFO] [stdout] | [INFO] [stdout] 127 | fn map_ref(&self, mut f: F) -> R [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | f(self.borrow().deref()) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `RefMut<'_, T>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:136:7 [INFO] [stdout] | [INFO] [stdout] 133 | fn map_mut(&self, mut f: F) -> R [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | f(self.borrow_mut().deref_mut()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:190:11 [INFO] [stdout] | [INFO] [stdout] 190 | $b.as_ref().unwrap().clone().wait(); [INFO] [stdout] | ^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 195 | wait!(START); [INFO] [stdout] | ------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` on by default [INFO] [stdout] = note: this warning originates in the macro `wait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:190:11 [INFO] [stdout] | [INFO] [stdout] 190 | $b.as_ref().unwrap().clone().wait(); [INFO] [stdout] | ^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 198 | wait!(READING); [INFO] [stdout] | -------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: this warning originates in the macro `wait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:190:11 [INFO] [stdout] | [INFO] [stdout] 190 | $b.as_ref().unwrap().clone().wait(); [INFO] [stdout] | ^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 199 | wait!(READING_DONE); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: this warning originates in the macro `wait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:190:11 [INFO] [stdout] | [INFO] [stdout] 190 | $b.as_ref().unwrap().clone().wait(); [INFO] [stdout] | ^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 202 | wait!(MODIFY_DONE); [INFO] [stdout] | ------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: this warning originates in the macro `wait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:190:11 [INFO] [stdout] | [INFO] [stdout] 190 | $b.as_ref().unwrap().clone().wait(); [INFO] [stdout] | ^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 206 | wait!(START); [INFO] [stdout] | ------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: this warning originates in the macro `wait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:190:11 [INFO] [stdout] | [INFO] [stdout] 190 | $b.as_ref().unwrap().clone().wait(); [INFO] [stdout] | ^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 207 | wait!(READING); [INFO] [stdout] | -------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: this warning originates in the macro `wait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:190:11 [INFO] [stdout] | [INFO] [stdout] 190 | $b.as_ref().unwrap().clone().wait(); [INFO] [stdout] | ^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 209 | wait!(MODIFY_DONE); [INFO] [stdout] | ------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: this warning originates in the macro `wait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:190:11 [INFO] [stdout] | [INFO] [stdout] 190 | $b.as_ref().unwrap().clone().wait(); [INFO] [stdout] | ^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 212 | wait!(START); [INFO] [stdout] | ------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: this warning originates in the macro `wait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:190:11 [INFO] [stdout] | [INFO] [stdout] 190 | $b.as_ref().unwrap().clone().wait(); [INFO] [stdout] | ^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 213 | wait!(READING); [INFO] [stdout] | -------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: this warning originates in the macro `wait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:190:11 [INFO] [stdout] | [INFO] [stdout] 190 | $b.as_ref().unwrap().clone().wait(); [INFO] [stdout] | ^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 214 | wait!(READING_DONE); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: this warning originates in the macro `wait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static is discouraged [INFO] [stdout] --> src/lib.rs:190:11 [INFO] [stdout] | [INFO] [stdout] 190 | $b.as_ref().unwrap().clone().wait(); [INFO] [stdout] | ^^ shared reference to mutable static [INFO] [stdout] ... [INFO] [stdout] 215 | wait!(MODIFY_DONE); [INFO] [stdout] | ------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: this warning originates in the macro `wait` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `toad-stem` (lib test) due to 5 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "764c16eab803f31d8a708d26fd31684f516fa29f5a414090505a147355b7d05b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "764c16eab803f31d8a708d26fd31684f516fa29f5a414090505a147355b7d05b", kill_on_drop: false }` [INFO] [stdout] 764c16eab803f31d8a708d26fd31684f516fa29f5a414090505a147355b7d05b