[INFO] fetching crate tket2 0.4.0... [INFO] checking tket2-0.4.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate tket2 0.4.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate tket2 0.4.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tket2 0.4.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate tket2 0.4.0 [INFO] tweaked toml for crates.io crate tket2 0.4.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 205 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding approx v0.4.0 (available: v0.5.1) [INFO] [stderr] Adding convert_case v0.4.0 (available: v0.6.0) [INFO] [stderr] Adding delegate v0.10.0 (available: v0.13.0) [INFO] [stderr] Adding delegate v0.12.0 (available: v0.13.0) [INFO] [stderr] Adding derive_more v0.99.18 (available: v1.0.0) [INFO] [stderr] Adding fixedbitset v0.4.2 (available: v0.5.7) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding jni-sys v0.3.0 (available: v0.4.0) [INFO] [stderr] Adding portgraph v0.8.0 (available: v0.12.2) [INFO] [stderr] Adding radium v0.7.0 (available: v1.1.0) [INFO] [stderr] Adding rstest v0.19.0 (available: v0.22.0) [INFO] [stderr] Adding rstest_macros v0.19.0 (available: v0.22.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (available: v2.0.0) [INFO] [stderr] Adding smol_str v0.2.2 (available: v0.3.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding tket-json-rs v0.5.1 (available: v0.6.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.45.0 (available: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.42.2 (available: v0.52.6) [INFO] [stderr] Adding wyz v0.5.1 (available: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fb200fa7a972784b0df5b66cf08babc2e592cdeab33ec7bd49ad66b212f8b9ea [INFO] running `Command { std: "docker" "start" "-a" "fb200fa7a972784b0df5b66cf08babc2e592cdeab33ec7bd49ad66b212f8b9ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fb200fa7a972784b0df5b66cf08babc2e592cdeab33ec7bd49ad66b212f8b9ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fb200fa7a972784b0df5b66cf08babc2e592cdeab33ec7bd49ad66b212f8b9ea", kill_on_drop: false }` [INFO] [stdout] fb200fa7a972784b0df5b66cf08babc2e592cdeab33ec7bd49ad66b212f8b9ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 93f23f2b3be3f1592745a07b45de6d43b023a25e9267f1e9689f73d510169c43 [INFO] running `Command { std: "docker" "start" "-a" "93f23f2b3be3f1592745a07b45de6d43b023a25e9267f1e9689f73d510169c43", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Compiling cgmath v0.18.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Compiling delegate v0.12.0 [INFO] [stderr] Compiling typetag-impl v0.2.18 [INFO] [stderr] Checking context-iterators v0.2.0 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking html-escape v0.2.13 [INFO] [stderr] Compiling enum_dispatch v0.3.13 [INFO] [stderr] Compiling delegate v0.13.0 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Checking downcast-rs v1.2.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling rstest_macros v0.19.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Compiling cc v1.1.21 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking approx v0.4.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking priority-queue v2.1.1 [INFO] [stderr] Checking indent_write v2.2.0 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking webbrowser v1.0.2 [INFO] [stderr] Checking cool_asserts v2.0.3 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking erased-serde v0.4.5 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking typetag v0.2.18 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking tket-json-rs v0.5.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Checking portgraph v0.12.2 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Checking hugr-core v0.9.1 [INFO] [stderr] Checking rstest v0.19.0 [INFO] [stderr] Checking hugr-passes v0.8.1 [INFO] [stderr] Checking hugr v0.12.1 [INFO] [stderr] Checking tket2 v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `command::CommandIterator<'_, hugr::Hugr>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit/command.rs:547:13 [INFO] [stdout] | [INFO] [stdout] 542 | fn iterate_commands_simple(#[case] circ: Circuit) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 547 | let mut commands = CommandIterator::new(&circ); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `types::signature::FuncTypeBase` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/circuit.rs:698:20 [INFO] [stdout] | [INFO] [stdout] 692 | #[case] circ: Circuit, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 698 | assert_eq!(circ.circuit_signature().input_count(), qubits + bits); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SmolStr` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ops.rs:227:27 [INFO] [stdout] | [INFO] [stdout] 226 | fn get_opdef(op: impl NamedOp) -> Option<&'static Arc> { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 227 | EXTENSION.get_op(&op.name()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for the crate [INFO] [stdout] --> tests/badger_termination.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #![cfg(feature = "portmatching")] [INFO] [stdout] 2 | | [INFO] [stdout] 3 | | use rstest::{fixture, rstest}; [INFO] [stdout] 4 | | use tket2::optimiser::badger::BadgerOptions; [INFO] [stdout] ... | [INFO] [stdout] 64 | | assert_eq!(opt_circ.commands().count(), 11); [INFO] [stdout] 65 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-W missing-docs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `circuit::Circuit` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/passes/pytket.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 117 | fn test_pytket_lowering(#[case] circ: Circuit) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let lowered_circ = lower_to_pytket(&circ).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SerialCircuit` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialize/pytket/tests.rs:266:9 [INFO] [stdout] | [INFO] [stdout] 265 | fn circuit_roundtrip(#[case] circ: Circuit, #[case] decoded_sig: Signature) { [INFO] [stdout] | ---- ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 266 | let ser: SerialCircuit = SerialCircuit::encode(&circ).unwrap(); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `SerialCircuit` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serialize/pytket/tests.rs:295:9 [INFO] [stdout] | [INFO] [stdout] 294 | fn test_add_angle_serialise(#[case] circ_add_angles: Circuit, #[case] param_str: &str) { [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | let ser: SerialCircuit = SerialCircuit::encode(&circ_add_angles).unwrap(); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tket2` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "93f23f2b3be3f1592745a07b45de6d43b023a25e9267f1e9689f73d510169c43", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "93f23f2b3be3f1592745a07b45de6d43b023a25e9267f1e9689f73d510169c43", kill_on_drop: false }` [INFO] [stdout] 93f23f2b3be3f1592745a07b45de6d43b023a25e9267f1e9689f73d510169c43