[INFO] fetching crate tide-validator 0.8.0... [INFO] checking tide-validator-0.8.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate tide-validator 0.8.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate tide-validator 0.8.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tide-validator 0.8.0 [INFO] finished tweaking crates.io crate tide-validator 0.8.0 [INFO] tweaked toml for crates.io crate tide-validator 0.8.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate tide-validator 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4d0cbc72665c3d046a0ff837b8102749899c0a716b9957332b206546c4d3c5bd [INFO] running `Command { std: "docker" "start" "-a" "4d0cbc72665c3d046a0ff837b8102749899c0a716b9957332b206546c4d3c5bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4d0cbc72665c3d046a0ff837b8102749899c0a716b9957332b206546c4d3c5bd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d0cbc72665c3d046a0ff837b8102749899c0a716b9957332b206546c4d3c5bd", kill_on_drop: false }` [INFO] [stdout] 4d0cbc72665c3d046a0ff837b8102749899c0a716b9957332b206546c4d3c5bd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 470e24c5e1c9178d54dc9a856f7a7365ebe8a9634c60a7049d04f0f8b0cdeb78 [INFO] running `Command { std: "docker" "start" "-a" "470e24c5e1c9178d54dc9a856f7a7365ebe8a9634c60a7049d04f0f8b0cdeb78", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Checking smallvec v1.2.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling proc-macro-nested v0.1.4 [INFO] [stderr] Checking futures-sink v0.3.4 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking futures-core v0.3.4 [INFO] [stderr] Checking futures-io v0.3.4 [INFO] [stderr] Checking futures-task v0.3.4 [INFO] [stderr] Checking lock_api v0.3.3 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Compiling anyhow v1.0.28 [INFO] [stderr] Checking once_cell v1.3.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking unicode-normalization v0.1.12 [INFO] [stderr] Checking pin-project-lite v0.1.4 [INFO] [stderr] Checking futures-timer v2.0.2 [INFO] [stderr] Compiling backtrace-sys v0.1.34 [INFO] [stderr] Compiling httparse v1.3.4 [INFO] [stderr] Checking futures-channel v0.3.4 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Compiling error-chain v0.12.2 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking omnom v2.1.2 [INFO] [stderr] Checking data-encoding v2.2.0 [INFO] [stderr] Checking route-recognizer v0.1.13 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking infer v0.1.6 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking bytes v0.5.4 [INFO] [stderr] Checking kv-log-macro v1.0.4 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking crossbeam-channel v0.4.2 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking http v0.2.1 [INFO] [stderr] Checking parking_lot_core v0.7.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Checking num_cpus v1.12.0 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking async-task v1.3.1 [INFO] [stderr] Checking byte-pool v0.2.1 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking idna v0.2.0 [INFO] [stderr] Checking backtrace v0.3.45 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking parking_lot v0.10.0 [INFO] [stderr] Checking mio v0.6.21 [INFO] [stderr] Checking url v2.1.1 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking cookie v0.12.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.12 [INFO] [stderr] Compiling async-attributes v1.1.1 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Compiling futures-macro v0.3.4 [INFO] [stderr] Checking futures-util v0.3.4 [INFO] [stderr] Checking broadcaster v1.0.0 [INFO] [stderr] Checking futures-executor v0.3.4 [INFO] [stderr] Checking futures v0.3.4 [INFO] [stderr] Checking async-std v1.5.0 [INFO] [stderr] Checking serde_qs v0.5.2 [INFO] [stderr] Checking serde_json v1.0.52 [INFO] [stderr] Checking http-types v1.2.0 [INFO] [stderr] Checking http-service v0.5.0 [INFO] [stderr] Checking async-h1 v1.1.2 [INFO] [stderr] Checking async-sse v2.1.0 [INFO] [stderr] Checking http-service-mock v0.5.0 [INFO] [stderr] Checking http-service-h1 v0.1.0 [INFO] [stderr] Checking tide v0.8.0 [INFO] [stderr] Checking tide-validator v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:430:21 [INFO] [stdout] | [INFO] [stdout] 430 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_CustomError` [INFO] [stdout] 431 | struct CustomError { [INFO] [stdout] | ----------- `CustomError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:430:32 [INFO] [stdout] | [INFO] [stdout] 430 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_CustomError` [INFO] [stdout] 431 | struct CustomError { [INFO] [stdout] | ----------- `CustomError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> examples/simple.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Deserialize, Serialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Cat` [INFO] [stdout] 9 | struct Cat { [INFO] [stdout] | --- `Cat` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> examples/simple.rs:8:23 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Deserialize, Serialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Cat` [INFO] [stdout] 9 | struct Cat { [INFO] [stdout] | --- `Cat` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> examples/custom_error.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Deserialize, Serialize)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Cat` [INFO] [stdout] 9 | struct Cat { [INFO] [stdout] | --- `Cat` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> examples/custom_error.rs:8:23 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Deserialize, Serialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Cat` [INFO] [stdout] 9 | struct Cat { [INFO] [stdout] | --- `Cat` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> examples/custom_error.rs:39:17 [INFO] [stdout] | [INFO] [stdout] 39 | #[derive(Debug, Serialize)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_CustomError` [INFO] [stdout] 40 | struct CustomError { [INFO] [stdout] | ----------- `CustomError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.47s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: http-types v1.2.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "470e24c5e1c9178d54dc9a856f7a7365ebe8a9634c60a7049d04f0f8b0cdeb78", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "470e24c5e1c9178d54dc9a856f7a7365ebe8a9634c60a7049d04f0f8b0cdeb78", kill_on_drop: false }` [INFO] [stdout] 470e24c5e1c9178d54dc9a856f7a7365ebe8a9634c60a7049d04f0f8b0cdeb78