[INFO] fetching crate tetsy-jsonrpc-ipc-server 15.1.0... [INFO] checking tetsy-jsonrpc-ipc-server-15.1.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate tetsy-jsonrpc-ipc-server 15.1.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate tetsy-jsonrpc-ipc-server 15.1.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tetsy-jsonrpc-ipc-server 15.1.0 [INFO] finished tweaking crates.io crate tetsy-jsonrpc-ipc-server 15.1.0 [INFO] tweaked toml for crates.io crate tetsy-jsonrpc-ipc-server 15.1.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate tetsy-jsonrpc-ipc-server 15.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c20835545107db9ee0b09af2a0b07bf9e5fedbb5f6ef7127baae27e8c9dfa8f0 [INFO] running `Command { std: "docker" "start" "-a" "c20835545107db9ee0b09af2a0b07bf9e5fedbb5f6ef7127baae27e8c9dfa8f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c20835545107db9ee0b09af2a0b07bf9e5fedbb5f6ef7127baae27e8c9dfa8f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c20835545107db9ee0b09af2a0b07bf9e5fedbb5f6ef7127baae27e8c9dfa8f0", kill_on_drop: false }` [INFO] [stdout] c20835545107db9ee0b09af2a0b07bf9e5fedbb5f6ef7127baae27e8c9dfa8f0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ce52add3abd8b790236d7e8cf0ebe896fbb15db344e35cdeaa22c428e71ed34f [INFO] running `Command { std: "docker" "start" "-a" "ce52add3abd8b790236d7e8cf0ebe896fbb15db344e35cdeaa22c428e71ed34f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.88 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling serde v1.0.124 [INFO] [stderr] Compiling syn v1.0.63 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking regex-syntax v0.6.23 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling winapi v0.3.9 [INFO] [stderr] Compiling serde_derive v1.0.124 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking bstr v0.2.15 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling parking_lot_core v0.6.2 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking mio-named-pipes v0.1.7 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking socket2 v0.3.19 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking miow v0.3.6 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking parking_lot_core v0.7.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking tokio-service v0.1.0 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking parking_lot v0.10.2 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking tokio-named-pipes v0.1.0 [INFO] [stderr] Checking tetsy-tokio-ipc v0.4.0 [INFO] [stderr] Checking regex v1.4.4 [INFO] [stderr] Checking globset v0.4.6 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking tetsy-jsonrpc-core v15.1.0 [INFO] [stderr] Checking tetsy-jsonrpc-server-utils v15.1.0 [INFO] [stderr] Checking tetsy-jsonrpc-ipc-server v15.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn start(self, path: &str) -> std::io::Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | let (wait_signal, wait_receiver) = oneshot::channel(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | let handle = InnerHandles { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | match start_receiver.wait().expect("Message should always be sent") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result<(), std::io::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn start(self, path: &str) -> std::io::Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 148 | let (wait_signal, wait_receiver) = oneshot::channel(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 253 | let handle = InnerHandles { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | match start_receiver.wait().expect("Message should always be sent") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tetsy-jsonrpc-ipc-server` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/server.rs:437:19 [INFO] [stdout] | [INFO] [stdout] 437 | let path = path.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tetsy-jsonrpc-ipc-server` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "ce52add3abd8b790236d7e8cf0ebe896fbb15db344e35cdeaa22c428e71ed34f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce52add3abd8b790236d7e8cf0ebe896fbb15db344e35cdeaa22c428e71ed34f", kill_on_drop: false }` [INFO] [stdout] ce52add3abd8b790236d7e8cf0ebe896fbb15db344e35cdeaa22c428e71ed34f