[INFO] fetching crate test-strategy 0.4.0... [INFO] checking test-strategy-0.4.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate test-strategy 0.4.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate test-strategy 0.4.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate test-strategy 0.4.0 [INFO] finished tweaking crates.io crate test-strategy 0.4.0 [INFO] tweaked toml for crates.io crate test-strategy 0.4.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate test-strategy 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2aa2964924a0f42b5d28a7b725ce67e311d93a380e4e83a70c62dd1f4977c5bf [INFO] running `Command { std: "docker" "start" "-a" "2aa2964924a0f42b5d28a7b725ce67e311d93a380e4e83a70c62dd1f4977c5bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2aa2964924a0f42b5d28a7b725ce67e311d93a380e4e83a70c62dd1f4977c5bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2aa2964924a0f42b5d28a7b725ce67e311d93a380e4e83a70c62dd1f4977c5bf", kill_on_drop: false }` [INFO] [stdout] 2aa2964924a0f42b5d28a7b725ce67e311d93a380e4e83a70c62dd1f4977c5bf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5481c666c42313b287e1a0059d2c83700da9b01fa6f290026d938c428b4d800e [INFO] running `Command { std: "docker" "start" "-a" "5481c666c42313b287e1a0059d2c83700da9b01fa6f290026d938c428b4d800e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking winnow v0.6.13 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking quote v1.0.36 [INFO] [stderr] Checking syn v2.0.68 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Compiling trybuild v1.0.96 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking unarray v0.1.4 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking proptest v1.5.0 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking serde_json v1.0.117 [INFO] [stderr] Checking toml_edit v0.22.14 [INFO] [stderr] Checking toml v0.8.14 [INFO] [stderr] Compiling structmeta-derive v0.3.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Checking structmeta v0.3.0 [INFO] [stderr] Checking test-strategy v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arbitrary.rs:38:10 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn derive_arbitrary(input: DeriveInput) -> Result { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let args: ArbitraryArgsForType = parse_from_attrs(&input.attrs, "arbitrary")?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let type_parameters = if let Some(ty) = &args.args { [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let expr = match &input.data { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | &parse_quote!(proptest::arbitrary::Arbitrary), [INFO] [stdout] | -------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | &bounds.build_wheres(quote!(proptest::arbitrary::Arbitrary + 'static)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `proc_macro2::TokenStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arbitrary.rs:223:21 [INFO] [stdout] | [INFO] [stdout] 205 | fn into_strategy(self, ty: &StrategyValueType) -> TokenStream { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | let any_with = ty.any_with(quote!(_any_args)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 224 | let any_with_args_let = ty.any_with_args_let(quote!(_any_args), init); [INFO] [stdout] 225 | / quote! { [INFO] [stdout] 226 | | { [INFO] [stdout] 227 | | #any_with_args_let; [INFO] [stdout] 228 | | #(#setters)* [INFO] [stdout] 229 | | #any_with [INFO] [stdout] 230 | | } [INFO] [stdout] 231 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arbitrary.rs:38:10 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn derive_arbitrary(input: DeriveInput) -> Result { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | let args: ArbitraryArgsForType = parse_from_attrs(&input.attrs, "arbitrary")?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let type_parameters = if let Some(ty) = &args.args { [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | let expr = match &input.data { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | &parse_quote!(proptest::arbitrary::Arbitrary), [INFO] [stdout] | -------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | &bounds.build_wheres(quote!(proptest::arbitrary::Arbitrary + 'static)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arbitrary.rs:1000:17 [INFO] [stdout] | [INFO] [stdout] 1000 | let mut lets = Vec::new(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1010 | expr: quote! { [INFO] [stdout] | _______________________- [INFO] [stdout] | |_______________________| [INFO] [stdout] 1011 | | { [INFO] [stdout] 1012 | | #(#lets)* [INFO] [stdout] 1013 | | #expr [INFO] [stdout] 1014 | | } [INFO] [stdout] 1015 | | }, [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `proc_macro2::TokenStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arbitrary.rs:223:21 [INFO] [stdout] | [INFO] [stdout] 205 | fn into_strategy(self, ty: &StrategyValueType) -> TokenStream { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | let any_with = ty.any_with(quote!(_any_args)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 224 | let any_with_args_let = ty.any_with_args_let(quote!(_any_args), init); [INFO] [stdout] 225 | / quote! { [INFO] [stdout] 226 | | { [INFO] [stdout] 227 | | #any_with_args_let; [INFO] [stdout] 228 | | #(#setters)* [INFO] [stdout] 229 | | #any_with [INFO] [stdout] 230 | | } [INFO] [stdout] 231 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bound.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 22 | let fork = input.fork(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | match fork.parse() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arbitrary.rs:1000:17 [INFO] [stdout] | [INFO] [stdout] 1000 | let mut lets = Vec::new(); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 1010 | expr: quote! { [INFO] [stdout] | _______________________- [INFO] [stdout] | |_______________________| [INFO] [stdout] 1011 | | { [INFO] [stdout] 1012 | | #(#lets)* [INFO] [stdout] 1013 | | #expr [INFO] [stdout] 1014 | | } [INFO] [stdout] 1015 | | }, [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bound.rs:23:15 [INFO] [stdout] | [INFO] [stdout] 22 | let fork = input.fork(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | match fork.parse() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `test-strategy` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `test-strategy` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "5481c666c42313b287e1a0059d2c83700da9b01fa6f290026d938c428b4d800e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5481c666c42313b287e1a0059d2c83700da9b01fa6f290026d938c428b4d800e", kill_on_drop: false }` [INFO] [stdout] 5481c666c42313b287e1a0059d2c83700da9b01fa6f290026d938c428b4d800e