[INFO] fetching crate templito 0.4.3... [INFO] checking templito-0.4.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate templito 0.4.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate templito 0.4.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate templito 0.4.3 [INFO] finished tweaking crates.io crate templito 0.4.3 [INFO] tweaked toml for crates.io crate templito 0.4.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 95 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.13.1 (available: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding deflate v0.8.6 (available: v1.0.0) [INFO] [stderr] Adding getrandom v0.1.16 (available: v0.2.15) [INFO] [stderr] Adding gif v0.11.4 (available: v0.13.1) [INFO] [stderr] Adding image v0.23.14 (available: v0.25.2) [INFO] [stderr] Adding imagesize v0.8.8 (available: v0.13.0) [INFO] [stderr] Adding jpeg-decoder v0.1.22 (available: v0.3.1) [INFO] [stderr] Adding miniz_oxide v0.3.7 (available: v0.8.0) [INFO] [stderr] Adding miniz_oxide v0.4.4 (available: v0.8.0) [INFO] [stderr] Adding num-rational v0.3.2 (available: v0.4.2) [INFO] [stderr] Adding png v0.16.8 (available: v0.17.13) [INFO] [stderr] Adding pulldown-cmark v0.7.2 (available: v0.12.1) [INFO] [stderr] Adding rand v0.7.3 (available: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (available: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (available: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (available: v0.3.2) [INFO] [stderr] Adding tiff v0.6.1 (available: v0.9.1) [INFO] [stderr] Adding toml v0.5.11 (available: v0.8.19) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fe3e0079ac216788e2dd164b7d36f5f5777ea098d45125153000a6dbc6691aa6 [INFO] running `Command { std: "docker" "start" "-a" "fe3e0079ac216788e2dd164b7d36f5f5777ea098d45125153000a6dbc6691aa6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fe3e0079ac216788e2dd164b7d36f5f5777ea098d45125153000a6dbc6691aa6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe3e0079ac216788e2dd164b7d36f5f5777ea098d45125153000a6dbc6691aa6", kill_on_drop: false }` [INFO] [stdout] fe3e0079ac216788e2dd164b7d36f5f5777ea098d45125153000a6dbc6691aa6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ebd49e5dd5027d7687196979a1eea88fe50ffb48fe57b50d5e831920bb1ede98 [INFO] running `Command { std: "docker" "start" "-a" "ebd49e5dd5027d7687196979a1eea88fe50ffb48fe57b50d5e831920bb1ede98", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling pulldown-cmark v0.7.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Checking tokenate v0.1.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking imagesize v0.8.8 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking gif v0.11.4 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking err_tools v0.1.1 [INFO] [stderr] Checking gobble v0.6.3 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking card_format v0.2.1 [INFO] [stderr] Checking templito v0.4.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result, anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/funcs/lists.rs:214:27 [INFO] [stdout] | [INFO] [stdout] 213 | let scope = Scope::new(¶ms[..]); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | match pp.run(&scope, &mut NoTemplates, &fm) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, anyhow::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/funcs/lists.rs:214:27 [INFO] [stdout] | [INFO] [stdout] 213 | let scope = Scope::new(¶ms[..]); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | match pp.run(&scope, &mut NoTemplates, &fm) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn top(self) -> HashMap { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | self.maps.into_iter().next().unwrap_or(HashMap::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/scope.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn top(self) -> HashMap { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | self.maps.into_iter().next().unwrap_or(HashMap::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template.rs:490:28 [INFO] [stdout] | [INFO] [stdout] 489 | pub fn to_tree(self) -> anyhow::Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 490 | tt_root_block(&mut self.v.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/funcs/lists.rs:155:48 [INFO] [stdout] | [INFO] [stdout] 155 | .binary_search_by(|v| compare(&comps, v.deref(), args[1].deref())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `tdata::TData` does not implement `Deref`, so calling `deref` on `&tdata::TData` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 155 - .binary_search_by(|v| compare(&comps, v.deref(), args[1].deref())) [INFO] [stdout] 155 + .binary_search_by(|v| compare(&comps, v, args[1].deref())) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `tdata::TData`, implement `Clone` for it [INFO] [stdout] --> src/tdata.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum TData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template.rs:490:28 [INFO] [stdout] | [INFO] [stdout] 489 | pub fn to_tree(self) -> anyhow::Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 490 | tt_root_block(&mut self.v.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/funcs/lists.rs:169:56 [INFO] [stdout] | [INFO] [stdout] 169 | let n = list.binary_search_by(|v| compare(&comps, v.deref(), args[1].deref())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `tdata::TData` does not implement `Deref`, so calling `deref` on `&tdata::TData` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 169 - let n = list.binary_search_by(|v| compare(&comps, v.deref(), args[1].deref())); [INFO] [stdout] 169 + let n = list.binary_search_by(|v| compare(&comps, v, args[1].deref())); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `tdata::TData`, implement `Clone` for it [INFO] [stdout] --> src/tdata.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum TData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `templito` (lib) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/funcs/lists.rs:155:48 [INFO] [stdout] | [INFO] [stdout] 155 | .binary_search_by(|v| compare(&comps, v.deref(), args[1].deref())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `tdata::TData` does not implement `Deref`, so calling `deref` on `&tdata::TData` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 155 - .binary_search_by(|v| compare(&comps, v.deref(), args[1].deref())) [INFO] [stdout] 155 + .binary_search_by(|v| compare(&comps, v, args[1].deref())) [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `tdata::TData`, implement `Clone` for it [INFO] [stdout] --> src/tdata.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum TData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.deref()` on a reference in this situation does nothing [INFO] [stdout] --> src/funcs/lists.rs:169:56 [INFO] [stdout] | [INFO] [stdout] 169 | let n = list.binary_search_by(|v| compare(&comps, v.deref(), args[1].deref())); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `tdata::TData` does not implement `Deref`, so calling `deref` on `&tdata::TData` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 169 - let n = list.binary_search_by(|v| compare(&comps, v.deref(), args[1].deref())); [INFO] [stdout] 169 + let n = list.binary_search_by(|v| compare(&comps, v, args[1].deref())); [INFO] [stdout] | [INFO] [stdout] help: if you meant to clone `tdata::TData`, implement `Clone` for it [INFO] [stdout] --> src/tdata.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 + #[derive(Clone)] [INFO] [stdout] 10 | pub enum TData { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `templito` (lib test) due to 4 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ebd49e5dd5027d7687196979a1eea88fe50ffb48fe57b50d5e831920bb1ede98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ebd49e5dd5027d7687196979a1eea88fe50ffb48fe57b50d5e831920bb1ede98", kill_on_drop: false }` [INFO] [stdout] ebd49e5dd5027d7687196979a1eea88fe50ffb48fe57b50d5e831920bb1ede98