[INFO] fetching crate tc-chain 0.5.0... [INFO] checking tc-chain-0.5.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate tc-chain 0.5.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate tc-chain 0.5.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate tc-chain 0.5.0 [INFO] finished tweaking crates.io crate tc-chain 0.5.0 [INFO] tweaked toml for crates.io crate tc-chain 0.5.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 169 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.7.8 (available: v0.8.11) [INFO] [stderr] Adding attribute-derive v0.6.1 (available: v0.10.1) [INFO] [stderr] Adding attribute-derive-macro v0.6.1 (available: v0.10.1) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding ds-ext v0.2.0 (available: v0.3.0) [INFO] [stderr] Adding futures v0.1.31 (available: v0.3.30) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding lru v0.7.8 (available: v0.12.4) [INFO] [stderr] Adding num-traits v0.1.43 (available: v0.2.19) [INFO] [stderr] Adding proc-macro-utils v0.8.0 (available: v0.10.0) [INFO] [stderr] Adding quick-xml v0.18.1 (available: v0.36.2) [INFO] [stderr] Adding quote-use v0.7.2 (available: v0.8.4) [INFO] [stderr] Adding quote-use-macros v0.7.2 (available: v0.8.4) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 04500b7f9d3defe3acc33d7e392204e21b30c9172e2e6dff39643024471edda7 [INFO] running `Command { std: "docker" "start" "-a" "04500b7f9d3defe3acc33d7e392204e21b30c9172e2e6dff39643024471edda7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "04500b7f9d3defe3acc33d7e392204e21b30c9172e2e6dff39643024471edda7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "04500b7f9d3defe3acc33d7e392204e21b30c9172e2e6dff39643024471edda7", kill_on_drop: false }` [INFO] [stdout] 04500b7f9d3defe3acc33d7e392204e21b30c9172e2e6dff39643024471edda7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8b1008cfed745f022e87e0915d979c7abec8edee64e452b87872265b48a02dff [INFO] running `Command { std: "docker" "start" "-a" "8b1008cfed745f022e87e0915d979c7abec8edee64e452b87872265b48a02dff", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling smallvec v1.13.2 [INFO] [stderr] Checking bytes v1.7.2 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling collection_literals v1.0.1 [INFO] [stderr] Compiling interpolator v0.5.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling derive-where v1.2.7 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking get-size v0.1.4 [INFO] [stderr] Checking safecast v0.2.3 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling proc-macro-utils v0.8.0 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Checking collate v0.4.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking pest v2.7.13 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling quote-use-macros v0.7.2 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Compiling quote-use v0.7.2 [INFO] [stderr] Compiling attribute-derive-macro v0.6.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling pest_meta v2.7.13 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling attribute-derive v0.6.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Compiling get-size-derive v0.1.3 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling pest_generator v2.7.13 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking destream v0.8.0 [INFO] [stderr] Checking async-hash v0.5.4 [INFO] [stderr] Checking ds-ext v0.2.0 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling pest_derive v2.7.13 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking handlebars v6.1.0 [INFO] [stderr] Checking email-address-parser v2.0.0 [INFO] [stderr] Checking hr-id v0.6.0 [INFO] [stderr] Checking tbon v0.6.0 [INFO] [stderr] Checking number-general v0.12.0 [INFO] [stderr] Checking txn_lock v0.10.0 [INFO] [stderr] Checking pathlink v0.3.0 [INFO] [stderr] Checking freqfs v0.10.0 [INFO] [stderr] Checking txfs v0.4.0 [INFO] [stderr] Checking tc-error v0.12.0 [INFO] [stderr] Checking tcgeneric v0.11.0 [INFO] [stderr] Checking tc-value v0.13.1 [INFO] [stderr] Checking tc-transact v0.21.1 [INFO] [stderr] Checking tc-scalar v0.5.0 [INFO] [stderr] Checking tc-collection v0.5.0 [INFO] [stderr] Checking tc-chain v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `txn_lock::guard::TxnReadGuard` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/history.rs:197:14 [INFO] [stdout] | [INFO] [stdout] 185 | pub async fn replicate(&self, txn: &State::Txn, subject: &T, other: Self) -> TCResult<()> [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let (latest, other_latest) = [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 198 | try_join!(self.latest.read(*txn.id()), other.latest.read(*txn.id()))?; [INFO] [stdout] | -------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | let (block, other) = try_join!(self.read_block(i), other.read_block(i))?; [INFO] [stdout] | -------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | let (mut dest, source) = try_join!( [INFO] [stdout] | ______________________________________- [INFO] [stdout] | |______________________________________| [INFO] [stdout] | |______________________________________| [INFO] [stdout] | |______________________________________| [INFO] [stdout] | |______________________________________| [INFO] [stdout] 228 | | self.write_block(*latest) [INFO] [stdout] 229 | | .map_err(|cause| internal!("missing chain block {}: {cause}", *latest)), [INFO] [stdout] 230 | | other [INFO] [stdout] 231 | | .read_block(*latest) [INFO] [stdout] 232 | | .map_err(|cause| bad_request!("invalid source Chain: {cause}")) [INFO] [stdout] 233 | | )?; [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `txn_lock::guard::TxnReadGuard` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/history.rs:197:14 [INFO] [stdout] | [INFO] [stdout] 185 | pub async fn replicate(&self, txn: &State::Txn, subject: &T, other: Self) -> TCResult<()> [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let (latest, other_latest) = [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 198 | try_join!(self.latest.read(*txn.id()), other.latest.read(*txn.id()))?; [INFO] [stdout] | -------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | let (block, other) = try_join!(self.read_block(i), other.read_block(i))?; [INFO] [stdout] | -------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | let (mut dest, source) = try_join!( [INFO] [stdout] | ______________________________________- [INFO] [stdout] | |______________________________________| [INFO] [stdout] | |______________________________________| [INFO] [stdout] | |______________________________________| [INFO] [stdout] | |______________________________________| [INFO] [stdout] 228 | | self.write_block(*latest) [INFO] [stdout] 229 | | .map_err(|cause| internal!("missing chain block {}: {cause}", *latest)), [INFO] [stdout] 230 | | other [INFO] [stdout] 231 | | .read_block(*latest) [INFO] [stdout] 232 | | .map_err(|cause| bad_request!("invalid source Chain: {cause}")) [INFO] [stdout] 233 | | )?; [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/public.rs:55:15 [INFO] [stdout] | [INFO] [stdout] 51 | fn put<'b>(self: Box) -> Option> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | match self.chain.subject().route(&[]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/public.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 81 | fn delete<'b>(self: Box) -> Option> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | match self.chain.subject().route(&[]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/public.rs:55:15 [INFO] [stdout] | [INFO] [stdout] 51 | fn put<'b>(self: Box) -> Option> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | match self.chain.subject().route(&[]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/public.rs:85:15 [INFO] [stdout] | [INFO] [stdout] 81 | fn delete<'b>(self: Box) -> Option> [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 85 | match self.chain.subject().route(&[]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tc-chain` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tc-chain` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "8b1008cfed745f022e87e0915d979c7abec8edee64e452b87872265b48a02dff", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b1008cfed745f022e87e0915d979c7abec8edee64e452b87872265b48a02dff", kill_on_drop: false }` [INFO] [stdout] 8b1008cfed745f022e87e0915d979c7abec8edee64e452b87872265b48a02dff