[INFO] fetching crate stv-rs 0.5.0... [INFO] checking stv-rs-0.5.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate stv-rs 0.5.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate stv-rs 0.5.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate stv-rs 0.5.0 [INFO] finished tweaking crates.io crate stv-rs 0.5.0 [INFO] tweaked toml for crates.io crate stv-rs 0.5.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate stv-rs 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0273d1dfd3053bbb502e5e95e7346425a8dc5ef07d30324fa4d3da76f3d9e4bb [INFO] running `Command { std: "docker" "start" "-a" "0273d1dfd3053bbb502e5e95e7346425a8dc5ef07d30324fa4d3da76f3d9e4bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0273d1dfd3053bbb502e5e95e7346425a8dc5ef07d30324fa4d3da76f3d9e4bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0273d1dfd3053bbb502e5e95e7346425a8dc5ef07d30324fa4d3da76f3d9e4bb", kill_on_drop: false }` [INFO] [stdout] 0273d1dfd3053bbb502e5e95e7346425a8dc5ef07d30324fa4d3da76f3d9e4bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 71808f29a3a6e50a55ed4c56ef246172e8e56b8678cb3194b6296ddc71f32c28 [INFO] running `Command { std: "docker" "start" "-a" "71808f29a3a6e50a55ed4c56ef246172e8e56b8678cb3194b6296ddc71f32c28", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking clap_lex v0.6.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking clap_builder v4.4.18 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking is-terminal v0.4.13 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking clap v4.4.18 [INFO] [stderr] Checking stv-rs v0.5.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stdout] error: this value of type `R` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/mod.rs:505:25 [INFO] [stdout] | [INFO] [stdout] 502 | Self::loop_check_i1(|a| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 505 | R::ratio_i(I::from_usize(1), a.clone()) * R::from_int(a.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `R` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/mod.rs:698:32 [INFO] [stdout] | [INFO] [stdout] 696 | Self::loop_check1_i1(&test_values, |a, b| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 697 | if !b.is_zero() { [INFO] [stdout] 698 | assert_eq!(&(a * &b) / &b, *a, "a * int(b) / int(b) != a for {a}, {b}"); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `R` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/mod.rs:730:25 [INFO] [stdout] | [INFO] [stdout] 727 | Self::loop_check1_i2(&test_values, num_samples, |a, b, c| { [INFO] [stdout] | - - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 730 | &(a / &b) / &c, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `R` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/mod.rs:743:25 [INFO] [stdout] | [INFO] [stdout] 740 | Self::loop_check2_i1(&test_values, num_samples, |a: &R, b: &R, c: I| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 743 | &(a + b) / &c, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `R` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/mod.rs:778:25 [INFO] [stdout] | [INFO] [stdout] 775 | Self::loop_check1_i1(&test_values, |a, b| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 778 | a * &b, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `R` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/arithmetic/mod.rs:818:25 [INFO] [stdout] | [INFO] [stdout] 816 | Self::loop_check1_i1(&test_values, |a, b| { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 817 | if !b.is_zero() { [INFO] [stdout] 818 | let mut c = a.clone(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `vote_count::VoteCount` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vote_count.rs:1334:29 [INFO] [stdout] | [INFO] [stdout] 1319 | let keep_factors_list = [ [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1334 | let left_vote_count = { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::vec::IntoIter` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vote_count.rs:1375:31 [INFO] [stdout] | [INFO] [stdout] 1372 | let empty_ballot = Ballot::empty(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1373 | let empty_keep_factors = vec![]; [INFO] [stdout] | ------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1374 | [INFO] [stdout] 1375 | for used_power in R::get_positive_test_values() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `I` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vote_count.rs:1488:42 [INFO] [stdout] | [INFO] [stdout] 1486 | let pascal = pascal::(count); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1487 | for i in 0..=count { [INFO] [stdout] 1488 | assert_eq!(pascal[i][0], I::from_usize(1)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `stv-rs` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "71808f29a3a6e50a55ed4c56ef246172e8e56b8678cb3194b6296ddc71f32c28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "71808f29a3a6e50a55ed4c56ef246172e8e56b8678cb3194b6296ddc71f32c28", kill_on_drop: false }` [INFO] [stdout] 71808f29a3a6e50a55ed4c56ef246172e8e56b8678cb3194b6296ddc71f32c28