[INFO] fetching crate starlark_syntax 0.12.0... [INFO] checking starlark_syntax-0.12.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate starlark_syntax 0.12.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate starlark_syntax 0.12.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate starlark_syntax 0.12.0 [INFO] finished tweaking crates.io crate starlark_syntax 0.12.0 [INFO] tweaked toml for crates.io crate starlark_syntax 0.12.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 114 packages to latest compatible versions [INFO] [stderr] Adding annotate-snippets v0.9.2 (available: v0.11.4) [INFO] [stderr] Adding bit-set v0.5.3 (available: v0.8.0) [INFO] [stderr] Adding bit-vec v0.6.3 (available: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding convert_case v0.4.0 (available: v0.6.0) [INFO] [stderr] Adding ctor v0.1.26 (available: v0.2.8) [INFO] [stderr] Adding derive_more v0.99.18 (available: v1.0.0) [INFO] [stderr] Adding fixedbitset v0.4.2 (available: v0.5.7) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding lalrpop v0.19.12 (available: v0.21.0) [INFO] [stderr] Adding lalrpop-util v0.19.12 (available: v0.21.0) [INFO] [stderr] Adding logos v0.12.1 (available: v0.14.2) [INFO] [stderr] Adding logos-derive v0.12.1 (available: v0.14.2) [INFO] [stderr] Adding lsp-types v0.94.1 (available: v0.97.0) [INFO] [stderr] Adding phf_shared v0.10.0 (available: v0.11.2) [INFO] [stderr] Adding regex-syntax v0.6.29 (available: v0.8.4) [INFO] [stderr] Adding siphasher v0.3.11 (available: v1.0.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding term v0.7.0 (available: v1.0.0) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29dd055ed5935b4d9b5b5f6229770374ddd0641ced78c424307b6440ca44932c [INFO] running `Command { std: "docker" "start" "-a" "29dd055ed5935b4d9b5b5f6229770374ddd0641ced78c424307b6440ca44932c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29dd055ed5935b4d9b5b5f6229770374ddd0641ced78c424307b6440ca44932c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29dd055ed5935b4d9b5b5f6229770374ddd0641ced78c424307b6440ca44932c", kill_on_drop: false }` [INFO] [stdout] 29dd055ed5935b4d9b5b5f6229770374ddd0641ced78c424307b6440ca44932c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 471ada394b97600ab1809f758240fe52a8da26da59c53faba855ef97572f77a2 [INFO] running `Command { std: "docker" "start" "-a" "471ada394b97600ab1809f758240fe52a8da26da59c53faba855ef97572f77a2", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling regex-syntax v0.6.29 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling phf_shared v0.10.0 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling is-terminal v0.4.13 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling ena v0.14.3 [INFO] [stderr] Compiling parking_lot v0.12.3 [INFO] [stderr] Compiling string_cache v0.8.7 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling allocative v0.3.3 [INFO] [stderr] Compiling diff v0.1.13 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling dupe_derive v0.9.0 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling allocative_derive v0.3.3 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling starlark_map v0.12.0 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking dupe v0.9.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling convert_case v0.4.0 [INFO] [stderr] Checking annotate-snippets v0.9.2 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling logos-derive v0.12.1 [INFO] [stderr] Checking lalrpop-util v0.19.12 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking logos v0.12.1 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling lalrpop v0.19.12 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking lsp-types v0.94.1 [INFO] [stderr] Compiling starlark_syntax v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slice_vec_ext.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 25 | fn collect_result(mut it: impl ExactSizeIterator>) -> Result, E> { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | match it.next() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>, ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntax/module.rs:196:15 [INFO] [stdout] | [INFO] [stdout] 193 | let codemap = CodeMap::new(filename.to_owned(), content); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | let lexer = Lexer::new(codemap.source(), dialect, codemap.dupe()); [INFO] [stdout] 195 | let mut errors = Vec::new(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | match StarlarkParser::new().parse( [INFO] [stdout] | _______________^ [INFO] [stdout] 197 | | &mut ParserState { [INFO] [stdout] 198 | | codemap: &codemap, [INFO] [stdout] 199 | | dialect, [INFO] [stdout] ... | [INFO] [stdout] 202 | | lexer.filter(|t| !matches!(t, Ok((_, Token::Comment(_), _)))), [INFO] [stdout] 203 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/slice_vec_ext.rs:26:11 [INFO] [stdout] | [INFO] [stdout] 25 | fn collect_result(mut it: impl ExactSizeIterator>) -> Result, E> { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | match it.next() { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>, ParseError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/syntax/module.rs:196:15 [INFO] [stdout] | [INFO] [stdout] 193 | let codemap = CodeMap::new(filename.to_owned(), content); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | let lexer = Lexer::new(codemap.source(), dialect, codemap.dupe()); [INFO] [stdout] 195 | let mut errors = Vec::new(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | match StarlarkParser::new().parse( [INFO] [stdout] | _______________^ [INFO] [stdout] 197 | | &mut ParserState { [INFO] [stdout] 198 | | codemap: &codemap, [INFO] [stdout] 199 | | dialect, [INFO] [stdout] ... | [INFO] [stdout] 202 | | lexer.filter(|t| !matches!(t, Ok((_, Token::Comment(_), _)))), [INFO] [stdout] 203 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlark_syntax` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlark_syntax` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "471ada394b97600ab1809f758240fe52a8da26da59c53faba855ef97572f77a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "471ada394b97600ab1809f758240fe52a8da26da59c53faba855ef97572f77a2", kill_on_drop: false }` [INFO] [stdout] 471ada394b97600ab1809f758240fe52a8da26da59c53faba855ef97572f77a2