[INFO] fetching crate starlark_derive 0.12.0... [INFO] checking starlark_derive-0.12.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate starlark_derive 0.12.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate starlark_derive 0.12.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate starlark_derive 0.12.0 [INFO] finished tweaking crates.io crate starlark_derive 0.12.0 [INFO] tweaked toml for crates.io crate starlark_derive 0.12.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4fd59d2cf07b30f6d29a0052e80ac7333902fff40340df9a9b42221ea01bae65 [INFO] running `Command { std: "docker" "start" "-a" "4fd59d2cf07b30f6d29a0052e80ac7333902fff40340df9a9b42221ea01bae65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4fd59d2cf07b30f6d29a0052e80ac7333902fff40340df9a9b42221ea01bae65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4fd59d2cf07b30f6d29a0052e80ac7333902fff40340df9a9b42221ea01bae65", kill_on_drop: false }` [INFO] [stdout] 4fd59d2cf07b30f6d29a0052e80ac7333902fff40340df9a9b42221ea01bae65 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 16c13f4e6c78c50bec11b81cd8f47b99d5cb8d88e416f5a64537695607049c7f [INFO] running `Command { std: "docker" "start" "-a" "16c13f4e6c78c50bec11b81cd8f47b99d5cb8d88e416f5a64537695607049c7f", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling dupe_derive v0.9.0 [INFO] [stderr] Checking dupe v0.9.0 [INFO] [stderr] Checking starlark_derive v0.12.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/for_each_field.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 32 | field_handler: impl Fn(&Ident, &Field) -> syn::Result, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let field_names: Vec = (0..fields.unnamed.len()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 46 | | s.struct_token.span => { [INFO] [stdout] 47 | | let Self(#(#field_names),*) = self; [INFO] [stdout] 48 | | #(#field_handlers)* [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 60 | | s.struct_token.span => { [INFO] [stdout] 61 | | let Self { #(#field_names),* } = self; [INFO] [stdout] 62 | | #(#field_handlers)* [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/for_each_field.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | let field_names: Vec = (0..fields.unnamed.len()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 88 | | v.ident.span() => [INFO] [stdout] 89 | | Self::#variant_name(#(#field_names),*) => { [INFO] [stdout] 90 | | #(#field_handlers)* [INFO] [stdout] 91 | | } [INFO] [stdout] 92 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 102 | | v.ident.span() => [INFO] [stdout] 103 | | Self::#variant_name { #(#field_names),* } => { [INFO] [stdout] 104 | | #(#field_handlers)* [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/for_each_field.rs:37:17 [INFO] [stdout] | [INFO] [stdout] 32 | field_handler: impl Fn(&Ident, &Field) -> syn::Result, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let field_names: Vec = (0..fields.unnamed.len()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 46 | | s.struct_token.span => { [INFO] [stdout] 47 | | let Self(#(#field_names),*) = self; [INFO] [stdout] 48 | | #(#field_handlers)* [INFO] [stdout] 49 | | } [INFO] [stdout] 50 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 60 | | s.struct_token.span => { [INFO] [stdout] 61 | | let Self { #(#field_names),* } = self; [INFO] [stdout] 62 | | #(#field_handlers)* [INFO] [stdout] 63 | | } [INFO] [stdout] 64 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/for_each_field.rs:79:17 [INFO] [stdout] | [INFO] [stdout] 79 | let field_names: Vec = (0..fields.unnamed.len()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 87 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 88 | | v.ident.span() => [INFO] [stdout] 89 | | Self::#variant_name(#(#field_names),*) => { [INFO] [stdout] 90 | | #(#field_handlers)* [INFO] [stdout] 91 | | } [INFO] [stdout] 92 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 102 | | v.ident.span() => [INFO] [stdout] 103 | | Self::#variant_name { #(#field_names),* } => { [INFO] [stdout] 104 | | #(#field_handlers)* [INFO] [stdout] 105 | | } [INFO] [stdout] 106 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:292:17 [INFO] [stdout] | [INFO] [stdout] 292 | let field_names: Vec<_> = (0..fields.unnamed.len()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 295 | Ok(syn::parse_quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 296 | | span=> [INFO] [stdout] 297 | | #name::#variant_name(#(#field_names),*) => { [INFO] [stdout] 298 | | #name::#variant_name( [INFO] [stdout] ... | [INFO] [stdout] 301 | | } [INFO] [stdout] 302 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | Ok(syn::parse_quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 307 | | span=> [INFO] [stdout] 308 | | #name::#variant_name { #(#field_names),* } => { [INFO] [stdout] 309 | | #name::#variant_name { [INFO] [stdout] ... | [INFO] [stdout] 312 | | } [INFO] [stdout] 313 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/freeze.rs:292:17 [INFO] [stdout] | [INFO] [stdout] 292 | let field_names: Vec<_> = (0..fields.unnamed.len()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 295 | Ok(syn::parse_quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 296 | | span=> [INFO] [stdout] 297 | | #name::#variant_name(#(#field_names),*) => { [INFO] [stdout] 298 | | #name::#variant_name( [INFO] [stdout] ... | [INFO] [stdout] 301 | | } [INFO] [stdout] 302 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 306 | Ok(syn::parse_quote_spanned! { [INFO] [stdout] | ________________- [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] | |________________| [INFO] [stdout] 307 | | span=> [INFO] [stdout] 308 | | #name::#variant_name { #(#field_names),* } => { [INFO] [stdout] 309 | | #name::#variant_name { [INFO] [stdout] ... | [INFO] [stdout] 312 | | } [INFO] [stdout] 313 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlark_derive` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `starlark_derive` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "16c13f4e6c78c50bec11b81cd8f47b99d5cb8d88e416f5a64537695607049c7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "16c13f4e6c78c50bec11b81cd8f47b99d5cb8d88e416f5a64537695607049c7f", kill_on_drop: false }` [INFO] [stdout] 16c13f4e6c78c50bec11b81cd8f47b99d5cb8d88e416f5a64537695607049c7f