[INFO] fetching crate standing-relations 0.1.2... [INFO] checking standing-relations-0.1.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate standing-relations 0.1.2 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate standing-relations 0.1.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate standing-relations 0.1.2 [INFO] finished tweaking crates.io crate standing-relations 0.1.2 [INFO] tweaked toml for crates.io crate standing-relations 0.1.2 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 39 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (available: v1.0.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 935aff72403720d7997b0c9406079ff020e34783cec9d6be3d999e9c2a7d2932 [INFO] running `Command { std: "docker" "start" "-a" "935aff72403720d7997b0c9406079ff020e34783cec9d6be3d999e9c2a7d2932", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "935aff72403720d7997b0c9406079ff020e34783cec9d6be3d999e9c2a7d2932", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "935aff72403720d7997b0c9406079ff020e34783cec9d6be3d999e9c2a7d2932", kill_on_drop: false }` [INFO] [stdout] 935aff72403720d7997b0c9406079ff020e34783cec9d6be3d999e9c2a7d2932 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6204910515b3101c748809d9583d80bb70f4dff28dadb93f91ccf91c027a7f1f [INFO] running `Command { std: "docker" "start" "-a" "6204910515b3101c748809d9583d80bb70f4dff28dadb93f91ccf91c027a7f1f", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking unicode-segmentation v1.12.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking standing-relations v0.1.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking console v0.15.8 [INFO] [stdout] error: this value of type `Option<::Item>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/feedback/op/checked_foreach.rs:7:15 [INFO] [stdout] | [INFO] [stdout] 6 | fn checked_foreach(mut self, mut f: impl FnMut(Self::Item)) -> bool { [INFO] [stdout] | -------- ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 7 | match self.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(K, HashMap)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/feedback/op.rs:101:15 [INFO] [stdout] | [INFO] [stdout] 100 | let m = self.output.get(context); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | match m.receive() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking similar v2.6.0 [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/core/context/tracking.rs:158:13 [INFO] [stdout] | [INFO] [stdout] 158 | let mut info = &mut self.0[index.0]; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::hash_map::Entry<'_, K, V>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/op/reduce/map.rs:22:15 [INFO] [stdout] | [INFO] [stdout] 21 | fn insert_if_different(&mut self, k: K, v: V) -> InsertResult { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | match self.entry(k) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::collections::btree_map::Entry<'_, K, V>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/op/reduce/map.rs:43:15 [INFO] [stdout] | [INFO] [stdout] 42 | fn insert_if_different(&mut self, k: K, v: V) -> InsertResult { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | match self.entry(k) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `checked_foreach` is never used [INFO] [stdout] --> src/feedback/op/checked_foreach.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub trait CheckedForeach: Iterator { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] 2 | fn checked_foreach(self, f: impl FnMut(Self::Item)) -> bool; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `standing-relations` (lib) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6204910515b3101c748809d9583d80bb70f4dff28dadb93f91ccf91c027a7f1f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6204910515b3101c748809d9583d80bb70f4dff28dadb93f91ccf91c027a7f1f", kill_on_drop: false }` [INFO] [stdout] 6204910515b3101c748809d9583d80bb70f4dff28dadb93f91ccf91c027a7f1f