[INFO] fetching crate soroban-env-macros 21.2.1... [INFO] checking soroban-env-macros-21.2.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate soroban-env-macros 21.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate soroban-env-macros 21.2.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate soroban-env-macros 21.2.1 [INFO] finished tweaking crates.io crate soroban-env-macros 21.2.1 [INFO] tweaked toml for crates.io crate soroban-env-macros 21.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] [stderr] Adding base32 v0.4.0 (available: v0.5.1) [INFO] [stderr] Adding itertools v0.11.0 (available: v0.13.0) [INFO] [stderr] Adding stellar-strkey v0.0.8 (available: v0.0.11) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 68e760ba8fadd350b935449bb49e5fe65053b6178a5eb4d74d2df1b1a35b9fab [INFO] running `Command { std: "docker" "start" "-a" "68e760ba8fadd350b935449bb49e5fe65053b6178a5eb4d74d2df1b1a35b9fab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "68e760ba8fadd350b935449bb49e5fe65053b6178a5eb4d74d2df1b1a35b9fab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68e760ba8fadd350b935449bb49e5fe65053b6178a5eb4d74d2df1b1a35b9fab", kill_on_drop: false }` [INFO] [stdout] 68e760ba8fadd350b935449bb49e5fe65053b6178a5eb4d74d2df1b1a35b9fab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 17f2565d2f70756cc9e57c9ced2427649f873e1e1325e8088c178bdd6084305f [INFO] running `Command { std: "docker" "start" "-a" "17f2565d2f70756cc9e57c9ced2427649f873e1e1325e8088c178bdd6084305f", kill_on_drop: false }` [INFO] [stderr] Checking base32 v0.4.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking escape-bytes v0.1.1 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Compiling crate-git-revision v0.0.6 [INFO] [stderr] Compiling stellar-strkey v0.0.8 [INFO] [stderr] Compiling stellar-xdr v21.2.0 [INFO] [stderr] Checking soroban-env-macros v21.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `proc_macro2::Ident` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synth_wasm_expr_type.rs:213:21 [INFO] [stdout] | [INFO] [stdout] 206 | let case_name = format_ident!("{}", f.name); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let enum_name_2 = enum_name.clone(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | let arg_names: Vec<_> = f.args.iter().map(|a| format_ident!("{}", a.name)).collect(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let ty2 = format_ident!("{}", ty.clone()); [INFO] [stdout] | ^^^ [INFO] [stdout] 214 | let arg0 = arg_names[0].clone(); [INFO] [stdout] 215 | / quote! { [INFO] [stdout] 216 | | #enum_name_2::#case_name(#(#arg_names),*) => { [INFO] [stdout] 217 | | #ty2::from(#arg0.clone()).into() [INFO] [stdout] 218 | | } [INFO] [stdout] 219 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | / quote! { [INFO] [stdout] 228 | | #enum_name_2::#case_name(#(#arg_names),*) => { [INFO] [stdout] 229 | | _func_emitter.maybe_choose_local(#ty, *#arg0).map(|x| x.into()) [INFO] [stdout] 230 | | .unwrap_or_else(|| #arg1.emit(_func_emitter)) [INFO] [stdout] 231 | | } [INFO] [stdout] 232 | | [INFO] [stdout] 233 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | / quote! { [INFO] [stdout] 253 | | #enum_name_2::#case_name(#(#arg_names),*) => { [INFO] [stdout] 254 | | #(#subcalls)* [INFO] [stdout] 255 | | _func_emitter.#case_name(#(#arg_names_2),*); [INFO] [stdout] 256 | | _func_emitter.alloc_and_store_local(#ty).into() [INFO] [stdout] 257 | | } [INFO] [stdout] 258 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `soroban-env-macros` (lib test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `proc_macro2::Ident` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/synth_wasm_expr_type.rs:213:21 [INFO] [stdout] | [INFO] [stdout] 206 | let case_name = format_ident!("{}", f.name); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let enum_name_2 = enum_name.clone(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | let arg_names: Vec<_> = f.args.iter().map(|a| format_ident!("{}", a.name)).collect(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | let ty2 = format_ident!("{}", ty.clone()); [INFO] [stdout] | ^^^ [INFO] [stdout] 214 | let arg0 = arg_names[0].clone(); [INFO] [stdout] 215 | / quote! { [INFO] [stdout] 216 | | #enum_name_2::#case_name(#(#arg_names),*) => { [INFO] [stdout] 217 | | #ty2::from(#arg0.clone()).into() [INFO] [stdout] 218 | | } [INFO] [stdout] 219 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | / quote! { [INFO] [stdout] 228 | | #enum_name_2::#case_name(#(#arg_names),*) => { [INFO] [stdout] 229 | | _func_emitter.maybe_choose_local(#ty, *#arg0).map(|x| x.into()) [INFO] [stdout] 230 | | .unwrap_or_else(|| #arg1.emit(_func_emitter)) [INFO] [stdout] 231 | | } [INFO] [stdout] 232 | | [INFO] [stdout] 233 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | / quote! { [INFO] [stdout] 253 | | #enum_name_2::#case_name(#(#arg_names),*) => { [INFO] [stdout] 254 | | #(#subcalls)* [INFO] [stdout] 255 | | _func_emitter.#case_name(#(#arg_names_2),*); [INFO] [stdout] 256 | | _func_emitter.alloc_and_store_local(#ty).into() [INFO] [stdout] 257 | | } [INFO] [stdout] 258 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `soroban-env-macros` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "17f2565d2f70756cc9e57c9ced2427649f873e1e1325e8088c178bdd6084305f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17f2565d2f70756cc9e57c9ced2427649f873e1e1325e8088c178bdd6084305f", kill_on_drop: false }` [INFO] [stdout] 17f2565d2f70756cc9e57c9ced2427649f873e1e1325e8088c178bdd6084305f