[INFO] fetching crate solidrs 0.4.0... [INFO] checking solidrs-0.4.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate solidrs 0.4.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate solidrs 0.4.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate solidrs 0.4.0 [INFO] finished tweaking crates.io crate solidrs 0.4.0 [INFO] tweaked toml for crates.io crate solidrs 0.4.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate solidrs 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 53ecc3ae5f375c98b8e2b345d0aebbd8370f2520c16416c451f09838f13bffcd [INFO] running `Command { std: "docker" "start" "-a" "53ecc3ae5f375c98b8e2b345d0aebbd8370f2520c16416c451f09838f13bffcd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53ecc3ae5f375c98b8e2b345d0aebbd8370f2520c16416c451f09838f13bffcd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53ecc3ae5f375c98b8e2b345d0aebbd8370f2520c16416c451f09838f13bffcd", kill_on_drop: false }` [INFO] [stdout] 53ecc3ae5f375c98b8e2b345d0aebbd8370f2520c16416c451f09838f13bffcd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1ac0c0295c81497d63ace780c185b459fdaaf5878d3a6aa0a1fe18f4d613853 [INFO] running `Command { std: "docker" "start" "-a" "c1ac0c0295c81497d63ace780c185b459fdaaf5878d3a6aa0a1fe18f4d613853", kill_on_drop: false }` [INFO] [stderr] Checking solidrs v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `InnerElement` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modify.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 38 | fn margin(self, margin: Val) -> Self { [INFO] [stdout] | ---- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | other => panic!("margin() is not allowed for type {other}"), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `InnerElement` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/modify.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 38 | fn margin(self, margin: Val) -> Self { [INFO] [stdout] | ---- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | other => panic!("margin() is not allowed for type {other}"), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `width` should have an upper case name [INFO] [stdout] --> src/../examples/variables.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | var!(width, 10, "cube width"); [INFO] [stdout] | ^^^^^ help: convert the identifier to upper case: `WIDTH` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solidrs` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: constant `height` should have an upper case name [INFO] [stdout] --> src/../examples/variables.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | var!(height, 20, "cube height"); [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper case: `HEIGHT` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `cylinder_height` should have an upper case name [INFO] [stdout] --> src/../examples/variables.rs:16:11 [INFO] [stdout] | [INFO] [stdout] 16 | calc!(cylinder_height, width / 2); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: convert the identifier to upper case: `CYLINDER_HEIGHT` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solidrs` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c1ac0c0295c81497d63ace780c185b459fdaaf5878d3a6aa0a1fe18f4d613853", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1ac0c0295c81497d63ace780c185b459fdaaf5878d3a6aa0a1fe18f4d613853", kill_on_drop: false }` [INFO] [stdout] c1ac0c0295c81497d63ace780c185b459fdaaf5878d3a6aa0a1fe18f4d613853