[INFO] fetching crate solabi 0.2.0... [INFO] checking solabi-0.2.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate solabi 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate solabi 0.2.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate solabi 0.2.0 [INFO] finished tweaking crates.io crate solabi 0.2.0 [INFO] tweaked toml for crates.io crate solabi 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1f071765f71826f598597774d50ee96076c5786d7bbc02112bc08b63469dc7a1 [INFO] running `Command { std: "docker" "start" "-a" "1f071765f71826f598597774d50ee96076c5786d7bbc02112bc08b63469dc7a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1f071765f71826f598597774d50ee96076c5786d7bbc02112bc08b63469dc7a1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f071765f71826f598597774d50ee96076c5786d7bbc02112bc08b63469dc7a1", kill_on_drop: false }` [INFO] [stdout] 1f071765f71826f598597774d50ee96076c5786d7bbc02112bc08b63469dc7a1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 72ceb5efd774ed395c1185582b0a919ecc395a7c85da612bfbf9759a355be969 [INFO] running `Command { std: "docker" "start" "-a" "72ceb5efd774ed395c1185582b0a919ecc395a7c85da612bfbf9759a355be969", kill_on_drop: false }` [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking ethaddr v0.2.2 [INFO] [stderr] Checking ethnum v1.5.0 [INFO] [stderr] Checking ethdigest v0.4.0 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking ethprim v0.3.0 [INFO] [stderr] Checking solabi v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `json::Descriptor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi/json.rs:134:15 [INFO] [stdout] | [INFO] [stdout] 128 | fn from(function: abi::FunctionDescriptor) -> Self { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | ..DescriptorKind::Function.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `json::Descriptor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi/json.rs:160:15 [INFO] [stdout] | [INFO] [stdout] 156 | fn from(constructor: abi::ConstructorDescriptor) -> Self { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | ..DescriptorKind::Constructor.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `json::Descriptor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi/json.rs:184:15 [INFO] [stdout] | [INFO] [stdout] 179 | fn from(event: abi::EventDescriptor) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | ..DescriptorKind::Event.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `json::Descriptor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi/json.rs:206:15 [INFO] [stdout] | [INFO] [stdout] 202 | fn from(error: abi::ErrorDescriptor) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | ..DescriptorKind::Error.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `json::Field` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi/json.rs:619:15 [INFO] [stdout] | [INFO] [stdout] 616 | fn from(field: abi::EventField) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 619 | ..field.field.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solabi` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `abi::FunctionDescriptor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi/declaration.rs:574:17 [INFO] [stdout] | [INFO] [stdout] 566 | let expected = FunctionDescriptor { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 574 | let parsed = FunctionDescriptor::parse_declaration(function).unwrap(); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `json::Descriptor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi/json.rs:134:15 [INFO] [stdout] | [INFO] [stdout] 128 | fn from(function: abi::FunctionDescriptor) -> Self { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | ..DescriptorKind::Function.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `json::Descriptor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi/json.rs:160:15 [INFO] [stdout] | [INFO] [stdout] 156 | fn from(constructor: abi::ConstructorDescriptor) -> Self { [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | ..DescriptorKind::Constructor.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `json::Descriptor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi/json.rs:184:15 [INFO] [stdout] | [INFO] [stdout] 179 | fn from(event: abi::EventDescriptor) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | ..DescriptorKind::Event.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `json::Descriptor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi/json.rs:206:15 [INFO] [stdout] | [INFO] [stdout] 202 | fn from(error: abi::ErrorDescriptor) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | ..DescriptorKind::Error.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `json::Field` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/abi/json.rs:619:15 [INFO] [stdout] | [INFO] [stdout] 616 | fn from(field: abi::EventField) -> Self { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 619 | ..field.field.into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `abi::EventDescriptor` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/encoders.rs:469:18 [INFO] [stdout] | [INFO] [stdout] 452 | let (event, encoder) = [INFO] [stdout] | ----- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 456 | let fields = [ [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 469 | let (event, encoder) = decl(signature); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `solabi` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "72ceb5efd774ed395c1185582b0a919ecc395a7c85da612bfbf9759a355be969", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "72ceb5efd774ed395c1185582b0a919ecc395a7c85da612bfbf9759a355be969", kill_on_drop: false }` [INFO] [stdout] 72ceb5efd774ed395c1185582b0a919ecc395a7c85da612bfbf9759a355be969