[INFO] fetching crate smoljson 0.1.1... [INFO] checking smoljson-0.1.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate smoljson 0.1.1 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate smoljson 0.1.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate smoljson 0.1.1 [INFO] finished tweaking crates.io crate smoljson 0.1.1 [INFO] tweaked toml for crates.io crate smoljson 0.1.1 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8de702d1a02bebc8b8f82639b8611098fbe610b22667c46d965f0049cb3a9cdb [INFO] running `Command { std: "docker" "start" "-a" "8de702d1a02bebc8b8f82639b8611098fbe610b22667c46d965f0049cb3a9cdb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8de702d1a02bebc8b8f82639b8611098fbe610b22667c46d965f0049cb3a9cdb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8de702d1a02bebc8b8f82639b8611098fbe610b22667c46d965f0049cb3a9cdb", kill_on_drop: false }` [INFO] [stdout] 8de702d1a02bebc8b8f82639b8611098fbe610b22667c46d965f0049cb3a9cdb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c7077dd013dea1f47a6ed8d07665e55b1eb00bbef04b090df14806bc26dfca0f [INFO] running `Command { std: "docker" "start" "-a" "c7077dd013dea1f47a6ed8d07665e55b1eb00bbef04b090df14806bc26dfca0f", kill_on_drop: false }` [INFO] [stderr] Checking smoljson v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:152:33 [INFO] [stdout] | [INFO] [stdout] 152 | #[cfg(any(debug_assertions, feature = "better_errors"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:154:37 [INFO] [stdout] | [INFO] [stdout] 154 | #[cfg(not(any(debug_assertions, feature = "better_errors")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:159:37 [INFO] [stdout] | [INFO] [stdout] 159 | #[cfg(any(debug_assertions, feature = "better_errors"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:167:41 [INFO] [stdout] | [INFO] [stdout] 167 | #[cfg(not(any(debug_assertions, feature = "better_errors")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:222:37 [INFO] [stdout] | [INFO] [stdout] 222 | #[cfg(any(debug_assertions, feature = "better_errors"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:242:41 [INFO] [stdout] | [INFO] [stdout] 242 | #[cfg(not(any(debug_assertions, feature = "better_errors")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:152:33 [INFO] [stdout] | [INFO] [stdout] 152 | #[cfg(any(debug_assertions, feature = "better_errors"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:154:37 [INFO] [stdout] | [INFO] [stdout] 154 | #[cfg(not(any(debug_assertions, feature = "better_errors")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:159:37 [INFO] [stdout] | [INFO] [stdout] 159 | #[cfg(any(debug_assertions, feature = "better_errors"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:167:41 [INFO] [stdout] | [INFO] [stdout] 167 | #[cfg(not(any(debug_assertions, feature = "better_errors")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:222:37 [INFO] [stdout] | [INFO] [stdout] 222 | #[cfg(any(debug_assertions, feature = "better_errors"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `better_errors` [INFO] [stdout] --> src/read.rs:242:41 [INFO] [stdout] | [INFO] [stdout] 242 | #[cfg(not(any(debug_assertions, feature = "better_errors")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default_allow_comments` [INFO] [stdout] = help: consider adding `better_errors` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::result::Result>, read::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:251:15 [INFO] [stdout] | [INFO] [stdout] 250 | pub fn finish(mut self) -> Result<()> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | match self.next_token() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::result::Result>, read::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/read.rs:251:15 [INFO] [stdout] | [INFO] [stdout] 250 | pub fn finish(mut self) -> Result<()> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 251 | match self.next_token() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::result::Result, read::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:209:20 [INFO] [stdout] | [INFO] [stdout] 209 | match tri!(de.next()) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / match $e { [INFO] [stdout] 61 | | Ok(v) => v, [INFO] [stdout] 62 | | Err(e) => return Err(e), [INFO] [stdout] 63 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `core::result::Result, read::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value.rs:209:20 [INFO] [stdout] | [INFO] [stdout] 209 | match tri!(de.next()) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / match $e { [INFO] [stdout] 61 | | Ok(v) => v, [INFO] [stdout] 62 | | Err(e) => return Err(e), [INFO] [stdout] 63 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smoljson` (lib test) due to 3 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `smoljson` (lib) due to 3 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c7077dd013dea1f47a6ed8d07665e55b1eb00bbef04b090df14806bc26dfca0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c7077dd013dea1f47a6ed8d07665e55b1eb00bbef04b090df14806bc26dfca0f", kill_on_drop: false }` [INFO] [stdout] c7077dd013dea1f47a6ed8d07665e55b1eb00bbef04b090df14806bc26dfca0f