[INFO] fetching crate simplicity-lang 0.2.0... [INFO] checking simplicity-lang-0.2.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate simplicity-lang 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate simplicity-lang 0.2.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate simplicity-lang 0.2.0 [INFO] finished tweaking crates.io crate simplicity-lang 0.2.0 [INFO] tweaked toml for crates.io crate simplicity-lang 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 42 packages to latest compatible versions [INFO] [stderr] Adding bech32 v0.10.0-beta (available: v0.11.0) [INFO] [stderr] Adding bitcoin v0.31.2 (available: v0.32.2) [INFO] [stderr] Adding bitcoin-internals v0.2.0 (available: v0.4.0) [INFO] [stderr] Adding bitcoin_hashes v0.13.0 (available: v0.14.0) [INFO] [stderr] Adding elements v0.24.1 (available: v0.25.0) [INFO] [stderr] Adding hex-conservative v0.1.2 (available: v0.2.1) [INFO] [stderr] Adding miniscript v11.2.0 (available: v12.2.0) [INFO] [stderr] Adding secp256k1 v0.28.2 (available: v0.29.1) [INFO] [stderr] Adding secp256k1-sys v0.9.2 (available: v0.10.1) [INFO] [stderr] Adding secp256k1-zkp v0.10.1 (available: v0.11.0) [INFO] [stderr] Adding secp256k1-zkp-sys v0.9.1 (available: v0.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 69505ee084842e2824af02ee8357f7a1bfad0f1de00be794f3a0035eeab2a1ef [INFO] running `Command { std: "docker" "start" "-a" "69505ee084842e2824af02ee8357f7a1bfad0f1de00be794f3a0035eeab2a1ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "69505ee084842e2824af02ee8357f7a1bfad0f1de00be794f3a0035eeab2a1ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69505ee084842e2824af02ee8357f7a1bfad0f1de00be794f3a0035eeab2a1ef", kill_on_drop: false }` [INFO] [stdout] 69505ee084842e2824af02ee8357f7a1bfad0f1de00be794f3a0035eeab2a1ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 25dfb343717422de71e47ca5e809b3a9dfac47f31cdf163e0b0a1a4da88c68c9 [INFO] running `Command { std: "docker" "start" "-a" "25dfb343717422de71e47ca5e809b3a9dfac47f31cdf163e0b0a1a4da88c68c9", kill_on_drop: false }` [INFO] [stderr] Compiling secp256k1-sys v0.9.2 [INFO] [stderr] Compiling bitcoin-internals v0.2.0 [INFO] [stderr] Checking hex-conservative v0.1.2 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Compiling secp256k1-zkp-sys v0.9.1 [INFO] [stderr] Compiling bitcoin-private v0.1.0 [INFO] [stderr] Compiling bitcoin v0.31.2 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking bech32 v0.10.0-beta [INFO] [stderr] Compiling simplicity-sys v0.2.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking bitcoin_hashes v0.13.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking secp256k1 v0.28.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking santiago v1.3.1 [INFO] [stderr] Checking secp256k1-zkp v0.10.1 [INFO] [stderr] Checking miniscript v11.2.0 [INFO] [stderr] Checking elements v0.24.1 [INFO] [stderr] Checking simplicity-lang v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `StackElem` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_encoding/decode.rs:343:8 [INFO] [stdout] | [INFO] [stdout] 325 | let mut stack = Vec::with_capacity(32); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | Ok(stack.pop().unwrap().value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ast` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/human_encoding/parse/ast.rs:110:11 [INFO] [stdout] | [INFO] [stdout] 101 | let lexer_rules = lexer_rules(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let grammar = grammar::(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let trees = santiago::parser::parse(&grammar, &lexemes)?; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | assert_eq!(trees.len(), 1, "ambiguous parse (this is a bug)"); [INFO] [stdout] 110 | match trees[0].as_abstract_syntax_tree() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ast` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/human_encoding/parse/ast.rs:603:54 [INFO] [stdout] | [INFO] [stdout] 600 | "expr" => rules "symbol" => |mut toks| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 603 | if let Ast::Symbol { value, position } = mem::replace(&mut toks[0], Ast::Replaced) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ast` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/human_encoding/parse/ast.rs:612:54 [INFO] [stdout] | [INFO] [stdout] 609 | "expr" => rules "?" "symbol" => |mut toks| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | if let Ast::Symbol { value, position } = mem::replace(&mut toks[1], Ast::Replaced) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `StackElem` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bit_encoding/decode.rs:343:8 [INFO] [stdout] | [INFO] [stdout] 325 | let mut stack = Vec::with_capacity(32); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | Ok(stack.pop().unwrap().value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ast` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/human_encoding/parse/ast.rs:110:11 [INFO] [stdout] | [INFO] [stdout] 101 | let lexer_rules = lexer_rules(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | let grammar = grammar::(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | let trees = santiago::parser::parse(&grammar, &lexemes)?; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | assert_eq!(trees.len(), 1, "ambiguous parse (this is a bug)"); [INFO] [stdout] 110 | match trees[0].as_abstract_syntax_tree() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ast` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/human_encoding/parse/ast.rs:603:54 [INFO] [stdout] | [INFO] [stdout] 600 | "expr" => rules "symbol" => |mut toks| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 603 | if let Ast::Symbol { value, position } = mem::replace(&mut toks[0], Ast::Replaced) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Ast` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/human_encoding/parse/ast.rs:612:54 [INFO] [stdout] | [INFO] [stdout] 609 | "expr" => rules "?" "symbol" => |mut toks| { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 612 | if let Ast::Symbol { value, position } = mem::replace(&mut toks[1], Ast::Replaced) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `human_encoding::error::ErrorSet` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/human_encoding/parse/mod.rs:617:17 [INFO] [stdout] | [INFO] [stdout] 614 | fn error_contains(res: Result, s: &str) { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 617 | Err(errs) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, std::sync::Arc>>>>, human_encoding::error::ErrorSet>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/human_encoding/parse/mod.rs:630:15 [INFO] [stdout] | [INFO] [stdout] 629 | fn assert_const(s: &str, value: Arc) { [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 630 | match parse::(s) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>>, Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/human_encoding/mod.rs:238:15 [INFO] [stdout] | [INFO] [stdout] 234 | let forest = Forest::::parse(s).unwrap(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | let mut witness = HashMap::new(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | match forest.to_witness_node(&witness).unwrap().finalize() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>>, Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/human_encoding/mod.rs:277:15 [INFO] [stdout] | [INFO] [stdout] 274 | let forest = Forest::::parse(s).unwrap(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | let witness = HashMap::new(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | [INFO] [stdout] 277 | match forest.to_witness_node(&witness).unwrap().finalize() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>>, Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/human_encoding/mod.rs:310:15 [INFO] [stdout] | [INFO] [stdout] 291 | let forest = Forest::::parse(s).unwrap(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 292 | let mut witness = HashMap::new(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 310 | match forest.to_witness_node(&witness).unwrap().finalize() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/mod.rs:283:45 [INFO] [stdout] | [INFO] [stdout] 282 | fn sum(a: Type, b: Type) -> Self { [INFO] [stdout] | - - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | if let (Some(adata), Some(bdata)) = (a.final_data(), b.final_data()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/mod.rs:291:45 [INFO] [stdout] | [INFO] [stdout] 290 | fn product(a: Type, b: Type) -> Self { [INFO] [stdout] | - - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | if let (Some(adata), Some(bdata)) = (a.final_data(), b.final_data()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/human_encoding/parse/mod.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | Literal(Cmr), [INFO] [stdout] | ------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 142 | Literal(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/human_encoding/parse/mod.rs:402:5 [INFO] [stdout] | [INFO] [stdout] 160 | / pub fn parse( [INFO] [stdout] 161 | | program: &str, [INFO] [stdout] 162 | | ) -> Result, Arc>>, ErrorSet> { [INFO] [stdout] | |_________________________________________________________________- move the `impl` block outside of this function `parse` [INFO] [stdout] ... [INFO] [stdout] 402 | impl<'a, J: Jet> DagLike for &'a ResolvedExpression { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-------^^^^^^^^^------------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `ResolvedExpression` is not local [INFO] [stdout] | `DagLike` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, bit_machine::ExecutionError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/policy/serialize.rs:270:15 [INFO] [stdout] | [INFO] [stdout] 265 | let finalized = commit [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | match mac.exec(&finalized, env) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/mod.rs:283:45 [INFO] [stdout] | [INFO] [stdout] 282 | fn sum(a: Type, b: Type) -> Self { [INFO] [stdout] | - - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 283 | if let (Some(adata), Some(bdata)) = (a.final_data(), b.final_data()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/mod.rs:291:45 [INFO] [stdout] | [INFO] [stdout] 290 | fn product(a: Type, b: Type) -> Self { [INFO] [stdout] | - - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 291 | if let (Some(adata), Some(bdata)) = (a.final_data(), b.final_data()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simplicity-lang` (lib) due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/human_encoding/parse/mod.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | Literal(Cmr), [INFO] [stdout] | ------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 142 | Literal(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/human_encoding/parse/mod.rs:402:5 [INFO] [stdout] | [INFO] [stdout] 160 | / pub fn parse( [INFO] [stdout] 161 | | program: &str, [INFO] [stdout] 162 | | ) -> Result, Arc>>, ErrorSet> { [INFO] [stdout] | |_________________________________________________________________- move the `impl` block outside of this function `parse` [INFO] [stdout] ... [INFO] [stdout] 402 | impl<'a, J: Jet> DagLike for &'a ResolvedExpression { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^-------^^^^^^^^^------------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `ResolvedExpression` is not local [INFO] [stdout] | `DagLike` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simplicity-lang` (lib test) due to 13 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "25dfb343717422de71e47ca5e809b3a9dfac47f31cdf163e0b0a1a4da88c68c9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "25dfb343717422de71e47ca5e809b3a9dfac47f31cdf163e0b0a1a4da88c68c9", kill_on_drop: false }` [INFO] [stdout] 25dfb343717422de71e47ca5e809b3a9dfac47f31cdf163e0b0a1a4da88c68c9