[INFO] fetching crate si_units 0.1.2... [INFO] checking si_units-0.1.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate si_units 0.1.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate si_units 0.1.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate si_units 0.1.2 [INFO] finished tweaking crates.io crate si_units 0.1.2 [INFO] tweaked toml for crates.io crate si_units 0.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 9 packages to latest compatible versions [INFO] [stderr] Adding itertools v0.12.1 (available: v0.13.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3d8f510dc01f50e695a79d37eaa0ddf4af2ab8739871eb6914979fee8596b1f2 [INFO] running `Command { std: "docker" "start" "-a" "3d8f510dc01f50e695a79d37eaa0ddf4af2ab8739871eb6914979fee8596b1f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3d8f510dc01f50e695a79d37eaa0ddf4af2ab8739871eb6914979fee8596b1f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3d8f510dc01f50e695a79d37eaa0ddf4af2ab8739871eb6914979fee8596b1f2", kill_on_drop: false }` [INFO] [stdout] 3d8f510dc01f50e695a79d37eaa0ddf4af2ab8739871eb6914979fee8596b1f2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 23b1999197f138fb2927eeaf84065dba26e63c282845c458d1acf7d4d5533dd5 [INFO] running `Command { std: "docker" "start" "-a" "23b1999197f138fb2927eeaf84065dba26e63c282845c458d1acf7d4d5533dd5", kill_on_drop: false }` [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling prse-derive v1.1.2 [INFO] [stderr] Checking prse v1.2.1 [INFO] [stderr] Checking si_units v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `((Option, Option>), (Option, Option>))` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 18 | fn add(self, rhs: SiValue) -> Self::Output { [INFO] [stdout] | ---- --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | if let ((Some(lhs_val), Some(lhs_unit)), (Some(rhs_val), Some(rhs_unit))) = [INFO] [stdout] 20 | ((self.value, self.unit), (rhs.value, rhs.unit)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `((Option, Option>), (Option, Option>))` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 18 | fn add(self, rhs: SiValue) -> Self::Output { [INFO] [stdout] | ---- --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | if let ((Some(lhs_val), Some(lhs_unit)), (Some(rhs_val), Some(rhs_unit))) = [INFO] [stdout] 20 | ((self.value, self.unit), (rhs.value, rhs.unit)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `((Option, Option>), (Option, Option>))` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 38 | fn sub(self, rhs: SiValue) -> Self::Output { [INFO] [stdout] | ---- --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | if let ((Some(lhs_val), Some(lhs_unit)), (Some(rhs_val), Some(rhs_unit))) = [INFO] [stdout] 40 | ((self.value, self.unit), (rhs.value, rhs.unit)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `((Option, Option>), (Option, Option>))` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 38 | fn sub(self, rhs: SiValue) -> Self::Output { [INFO] [stdout] | ---- --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | if let ((Some(lhs_val), Some(lhs_unit)), (Some(rhs_val), Some(rhs_unit))) = [INFO] [stdout] 40 | ((self.value, self.unit), (rhs.value, rhs.unit)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `si_units` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `si_units` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "23b1999197f138fb2927eeaf84065dba26e63c282845c458d1acf7d4d5533dd5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23b1999197f138fb2927eeaf84065dba26e63c282845c458d1acf7d4d5533dd5", kill_on_drop: false }` [INFO] [stdout] 23b1999197f138fb2927eeaf84065dba26e63c282845c458d1acf7d4d5533dd5