[INFO] fetching crate sfm 0.5.0... [INFO] checking sfm-0.5.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate sfm 0.5.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate sfm 0.5.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sfm 0.5.0 [INFO] finished tweaking crates.io crate sfm 0.5.0 [INFO] tweaked toml for crates.io crate sfm 0.5.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate sfm 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 37d720c970a197af449e24439999c85358787dab21d52b50cee480691e1824b7 [INFO] running `Command { std: "docker" "start" "-a" "37d720c970a197af449e24439999c85358787dab21d52b50cee480691e1824b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "37d720c970a197af449e24439999c85358787dab21d52b50cee480691e1824b7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37d720c970a197af449e24439999c85358787dab21d52b50cee480691e1824b7", kill_on_drop: false }` [INFO] [stdout] 37d720c970a197af449e24439999c85358787dab21d52b50cee480691e1824b7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9db8e39765cfbff66f5c8fc0617b12e941aa286983e2be72da9185ea67d268ab [INFO] running `Command { std: "docker" "start" "-a" "9db8e39765cfbff66f5c8fc0617b12e941aa286983e2be72da9185ea67d268ab", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking unicode-segmentation v1.7.1 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking mio v0.7.7 [INFO] [stderr] Checking parking_lot_core v0.8.2 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking dirs v3.0.1 [INFO] [stderr] Checking signal-hook v0.1.17 [INFO] [stderr] Checking crossterm v0.18.2 [INFO] [stderr] Checking crossterm v0.19.0 [INFO] [stderr] Checking tui v0.14.0 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking sfm v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/file_system/functions.rs:64:27 [INFO] [stdout] | [INFO] [stdout] 61 | dir_entry: DirEntry, [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 64 | if let Ok(metadata) = dir_entry.metadata() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/store.rs:75:42 [INFO] [stdout] | [INFO] [stdout] 69 | fn dispatch_middlewares(&mut self, order: usize, action: TAction) { [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | if let Some(middleware_action) = self.middlewares[order](self, action.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/ui/component_base.rs:44:30 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn set_state(&mut self, callback: StateSetter) [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | if let Some(state) = self.state.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `show_icons` and `error_icon` are never read [INFO] [stdout] --> src/app/components/error_modal.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct ErrorModalComponentProps { [INFO] [stdout] | ------------------------ fields in this struct [INFO] [stdout] 24 | message: Option, [INFO] [stdout] 25 | show_icons: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 26 | error_icon: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ErrorModalComponentProps` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `modal_style` is never read [INFO] [stdout] --> src/app/components/rename_modal.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct RenameModalComponentProps { [INFO] [stdout] | ------------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | modal_style: ModalStyle, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RenameModalComponentProps` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `has_displayed_tabs` is never read [INFO] [stdout] --> src/app/components/tab.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 31 | pub struct TabComponentProps { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 32 | state: Option>, [INFO] [stdout] 33 | has_displayed_tabs: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TabComponentProps` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sfm` (bin "sfm") due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9db8e39765cfbff66f5c8fc0617b12e941aa286983e2be72da9185ea67d268ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9db8e39765cfbff66f5c8fc0617b12e941aa286983e2be72da9185ea67d268ab", kill_on_drop: false }` [INFO] [stdout] 9db8e39765cfbff66f5c8fc0617b12e941aa286983e2be72da9185ea67d268ab