[INFO] fetching crate serde_yml 0.0.12... [INFO] checking serde_yml-0.0.12 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate serde_yml 0.0.12 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate serde_yml 0.0.12 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde_yml 0.0.12 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate serde_yml 0.0.12 [INFO] tweaked toml for crates.io crate serde_yml 0.0.12 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate serde_yml 0.0.12 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b2b410eb0cddc0570dbf5c68d5546ae409ce99cc4c9186e3f21923c3a79dadb6 [INFO] running `Command { std: "docker" "start" "-a" "b2b410eb0cddc0570dbf5c68d5546ae409ce99cc4c9186e3f21923c3a79dadb6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b2b410eb0cddc0570dbf5c68d5546ae409ce99cc4c9186e3f21923c3a79dadb6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b2b410eb0cddc0570dbf5c68d5546ae409ce99cc4c9186e3f21923c3a79dadb6", kill_on_drop: false }` [INFO] [stdout] b2b410eb0cddc0570dbf5c68d5546ae409ce99cc4c9186e3f21923c3a79dadb6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3a99b48609c97e0099d92f8f224720d8345580b5cce13b4b649e70ed805c3253 [INFO] running `Command { std: "docker" "start" "-a" "3a99b48609c97e0099d92f8f224720d8345580b5cce13b4b649e70ed805c3253", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Compiling serde_yml v0.0.12 (/opt/rustwide/workdir) [INFO] [stderr] Checking libyml v0.0.5 [INFO] [stderr] Checking indexmap v2.4.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.76 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn into_inner(mut self) -> Result { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | Ok(*unsafe { Box::from_raw(Box::into_raw(writer).cast::()) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:251:15 [INFO] [stdout] | [INFO] [stdout] 247 | fn deserialize_bool(self, visitor: V) -> Result [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | match self.untag() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:362:15 [INFO] [stdout] | [INFO] [stdout] 357 | visitor: V, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | match self.untag() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:382:15 [INFO] [stdout] | [INFO] [stdout] 377 | visitor: V, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | match self.untag() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:438:15 [INFO] [stdout] | [INFO] [stdout] 434 | fn deserialize_seq(self, visitor: V) -> Result [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 438 | match self.untag() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:472:15 [INFO] [stdout] | [INFO] [stdout] 468 | fn deserialize_map(self, visitor: V) -> Result [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 472 | match self.untag() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:704:15 [INFO] [stdout] | [INFO] [stdout] 699 | seed: T, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 704 | match self.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option<(Value, Value)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:744:15 [INFO] [stdout] | [INFO] [stdout] 739 | seed: T, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 744 | match self.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:757:15 [INFO] [stdout] | [INFO] [stdout] 753 | fn next_value_seed(&mut self, seed: T) -> Result [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 757 | match self.value.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:129:13 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn into_inner(mut self) -> Result { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 129 | Ok(*unsafe { Box::from_raw(Box::into_raw(writer).cast::()) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:251:15 [INFO] [stdout] | [INFO] [stdout] 247 | fn deserialize_bool(self, visitor: V) -> Result [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | match self.untag() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:362:15 [INFO] [stdout] | [INFO] [stdout] 357 | visitor: V, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | match self.untag() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:382:15 [INFO] [stdout] | [INFO] [stdout] 377 | visitor: V, [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 382 | match self.untag() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:438:15 [INFO] [stdout] | [INFO] [stdout] 434 | fn deserialize_seq(self, visitor: V) -> Result [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 438 | match self.untag() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Value` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:472:15 [INFO] [stdout] | [INFO] [stdout] 468 | fn deserialize_map(self, visitor: V) -> Result [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 472 | match self.untag() { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option<>::Value>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/with.rs:943:19 [INFO] [stdout] | [INFO] [stdout] 937 | mut self, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 943 | match self.delegate.next_key_seed(seed)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:704:15 [INFO] [stdout] | [INFO] [stdout] 699 | seed: T, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 704 | match self.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option<(Value, Value)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:744:15 [INFO] [stdout] | [INFO] [stdout] 739 | seed: T, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 744 | match self.iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/de.rs:757:15 [INFO] [stdout] | [INFO] [stdout] 753 | fn next_value_seed(&mut self, seed: T) -> Result [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 757 | match self.value.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option<>::Value>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/with.rs:2725:19 [INFO] [stdout] | [INFO] [stdout] 2719 | mut self, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2725 | match self.delegate.next_key_seed(seed)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_yml` (lib test) due to 12 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option<>::Value>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/with.rs:943:19 [INFO] [stdout] | [INFO] [stdout] 937 | mut self, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 943 | match self.delegate.next_key_seed(seed)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option<>::Value>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/with.rs:2725:19 [INFO] [stdout] | [INFO] [stdout] 2719 | mut self, [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2725 | match self.delegate.next_key_seed(seed)? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_yml` (lib) due to 12 previous errors [INFO] running `Command { std: "docker" "inspect" "3a99b48609c97e0099d92f8f224720d8345580b5cce13b4b649e70ed805c3253", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3a99b48609c97e0099d92f8f224720d8345580b5cce13b4b649e70ed805c3253", kill_on_drop: false }` [INFO] [stdout] 3a99b48609c97e0099d92f8f224720d8345580b5cce13b4b649e70ed805c3253