[INFO] fetching crate serde_rusqlite 0.36.0... [INFO] checking serde_rusqlite-0.36.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate serde_rusqlite 0.36.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate serde_rusqlite 0.36.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde_rusqlite 0.36.0 [INFO] finished tweaking crates.io crate serde_rusqlite 0.36.0 [INFO] tweaked toml for crates.io crate serde_rusqlite 0.36.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 23 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c8b86f461b71d00939d9b0ae451d9895a5017ce1cc06d5283221a1f6dc555a5 [INFO] running `Command { std: "docker" "start" "-a" "6c8b86f461b71d00939d9b0ae451d9895a5017ce1cc06d5283221a1f6dc555a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c8b86f461b71d00939d9b0ae451d9895a5017ce1cc06d5283221a1f6dc555a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c8b86f461b71d00939d9b0ae451d9895a5017ce1cc06d5283221a1f6dc555a5", kill_on_drop: false }` [INFO] [stdout] 6c8b86f461b71d00939d9b0ae451d9895a5017ce1cc06d5283221a1f6dc555a5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 086a6a497296e69ac92071cea78ba6a8685eda670e0871e04c22dfbdb3fd97c6 [INFO] running `Command { std: "docker" "start" "-a" "086a6a497296e69ac92071cea78ba6a8685eda670e0871e04c22dfbdb3fd97c6", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking serde_rusqlite v0.36.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stdout] error: this value of type `std::result::Result>>, error::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 40 | fn test_ser_err bool>(value: &S, err_check_fn: F) { [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | match super::to_params(value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `AndThenRows<'_, for<'a, 'b> fn(&'a Row<'b>) -> std::result::Result {from_row::}>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 47 | fn test_values_with_cmp_fn(db_type: &str, value_ser: &S, value_de: &D, comparison_fn: Option) [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let con = make_connection_with_spec(&format!("test_column {}", db_type)); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let mut stmt = con.prepare("SELECT * FROM test").unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let res = stmt.query_and_then([], super::from_row::).unwrap(); [INFO] [stdout] 63 | for row in res { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `AndThenRows<'_, for<'a, 'b> fn(&'a Row<'b>) -> std::result::Result<(i64, f64, std::string::String, Vec, std::option::Option), error::Error> {from_row::<(i64, f64, std::string::String, Vec, std::option::Option)>}>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:271:7 [INFO] [stdout] | [INFO] [stdout] 253 | let con = make_connection(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | let mut stmt = con.prepare("SELECT * FROM test").unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 271 | let mut res = stmt.query_and_then([], super::from_row::).unwrap(); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `DeserRows<'_, TestDeser>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:453:7 [INFO] [stdout] | [INFO] [stdout] 413 | let con = make_connection(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 451 | let mut stmt = con.prepare("SELECT f_real, f_blob, f_null FROM test").unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 452 | { [INFO] [stdout] 453 | let mut res = super::from_rows::(stmt.query([]).unwrap()); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `DeserRows<'_, Deser>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:488:7 [INFO] [stdout] | [INFO] [stdout] 465 | let con = make_connection(); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 486 | let mut stmt = con.prepare("SELECT f_real, f_text FROM test").unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 487 | { [INFO] [stdout] 488 | let mut res = super::from_rows::(stmt.query([]).unwrap()); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_rusqlite` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "086a6a497296e69ac92071cea78ba6a8685eda670e0871e04c22dfbdb3fd97c6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "086a6a497296e69ac92071cea78ba6a8685eda670e0871e04c22dfbdb3fd97c6", kill_on_drop: false }` [INFO] [stdout] 086a6a497296e69ac92071cea78ba6a8685eda670e0871e04c22dfbdb3fd97c6