[INFO] fetching crate sc-utils 17.0.0... [INFO] checking sc-utils-17.0.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate sc-utils 17.0.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate sc-utils 17.0.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sc-utils 17.0.0 [INFO] finished tweaking crates.io crate sc-utils 17.0.0 [INFO] tweaked toml for crates.io crate sc-utils 17.0.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 99 packages to latest compatible versions [INFO] [stderr] Adding async-channel v1.9.0 (available: v2.3.1) [INFO] [stderr] Adding derive_more v0.99.18 (available: v1.0.0) [INFO] [stderr] Adding event-listener v2.5.3 (available: v5.3.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5359763060b7493551bc374a07eff913b6fb2eb9ba3abb39e753a47f0097c2f0 [INFO] running `Command { std: "docker" "start" "-a" "5359763060b7493551bc374a07eff913b6fb2eb9ba3abb39e753a47f0097c2f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5359763060b7493551bc374a07eff913b6fb2eb9ba3abb39e753a47f0097c2f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5359763060b7493551bc374a07eff913b6fb2eb9ba3abb39e753a47f0097c2f0", kill_on_drop: false }` [INFO] [stdout] 5359763060b7493551bc374a07eff913b6fb2eb9ba3abb39e753a47f0097c2f0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9cd72e3b35d89081dcb80bbacc0a0e7673a50677ee0c3707a1b6661af990c8b9 [INFO] running `Command { std: "docker" "start" "-a" "9cd72e3b35d89081dcb80bbacc0a0e7673a50677ee0c3707a1b6661af990c8b9", kill_on_drop: false }` [INFO] [stderr] Compiling winnow v0.6.20 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling regex-syntax v0.8.4 [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Compiling common-path v1.0.0 [INFO] [stderr] Checking byte-slice-cast v1.2.2 [INFO] [stderr] Compiling prometheus v0.13.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking integer-sqrt v0.1.5 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking sp-std v14.0.0 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Compiling serde_spanned v0.6.8 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling impl-trait-for-tuples v0.2.2 [INFO] [stderr] Compiling derive-syn-parse v0.2.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Compiling toml v0.8.19 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling parity-scale-codec-derive v3.6.12 [INFO] [stderr] Compiling scale-info-derive v2.11.3 [INFO] [stderr] Checking thiserror v1.0.64 [INFO] [stderr] Compiling docify_macros v0.2.8 [INFO] [stderr] Checking parity-scale-codec v3.6.12 [INFO] [stderr] Checking docify v0.2.8 [INFO] [stderr] Checking scale-info v2.11.3 [INFO] [stderr] Checking sp-arithmetic v26.0.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking sc-utils v17.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `futures::lock::MutexGuard<'_, Inner>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/status_sinks.rs:86:7 [INFO] [stdout] | [INFO] [stdout] 86 | let mut inner = self.inner.lock().await; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 105 | / futures::select! { [INFO] [stdout] 106 | | new_entry = inner.entries_rx.next() => { [INFO] [stdout] 107 | | if let Some(new_entry) = new_entry { [INFO] [stdout] 108 | | inner.entries.push(new_entry); [INFO] [stdout] ... | [INFO] [stdout] 117 | | } [INFO] [stdout] 118 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `futures::lock::MutexGuard<'_, Inner>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/status_sinks.rs:86:7 [INFO] [stdout] | [INFO] [stdout] 86 | let mut inner = self.inner.lock().await; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 105 | / futures::select! { [INFO] [stdout] 106 | | new_entry = inner.entries_rx.next() => { [INFO] [stdout] 107 | | if let Some(new_entry) = new_entry { [INFO] [stdout] 108 | | inner.entries.push(new_entry); [INFO] [stdout] ... | [INFO] [stdout] 117 | | } [INFO] [stdout] 118 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/status_sinks.rs:134:25 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn send(mut self, element: T) { [INFO] [stdout] | -------- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | if let Some(sender) = self.sender.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sc-utils` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/status_sinks.rs:134:25 [INFO] [stdout] | [INFO] [stdout] 133 | pub fn send(mut self, element: T) { [INFO] [stdout] | -------- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | if let Some(sender) = self.sender.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sc-utils` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "9cd72e3b35d89081dcb80bbacc0a0e7673a50677ee0c3707a1b6661af990c8b9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9cd72e3b35d89081dcb80bbacc0a0e7673a50677ee0c3707a1b6661af990c8b9", kill_on_drop: false }` [INFO] [stdout] 9cd72e3b35d89081dcb80bbacc0a0e7673a50677ee0c3707a1b6661af990c8b9