[INFO] fetching crate savefile-derive 0.17.7... [INFO] checking savefile-derive-0.17.7 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate savefile-derive 0.17.7 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate savefile-derive 0.17.7 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate savefile-derive 0.17.7 [INFO] finished tweaking crates.io crate savefile-derive 0.17.7 [INFO] tweaked toml for crates.io crate savefile-derive 0.17.7 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 493a74e5f881696ad215011cd4bc5d1cf29a4cee6ad6fa4d4b82fd5b0de3551a [INFO] running `Command { std: "docker" "start" "-a" "493a74e5f881696ad215011cd4bc5d1cf29a4cee6ad6fa4d4b82fd5b0de3551a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "493a74e5f881696ad215011cd4bc5d1cf29a4cee6ad6fa4d4b82fd5b0de3551a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "493a74e5f881696ad215011cd4bc5d1cf29a4cee6ad6fa4d4b82fd5b0de3551a", kill_on_drop: false }` [INFO] [stdout] 493a74e5f881696ad215011cd4bc5d1cf29a4cee6ad6fa4d4b82fd5b0de3551a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 87271ee7e1777fb34b2a9ab834f25d091aefe6a9b02ce175096089015e392d44 [INFO] running `Command { std: "docker" "start" "-a" "87271ee7e1777fb34b2a9ab834f25d091aefe6a9b02ce175096089015e392d44", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking proc-macro-error v1.0.4 [INFO] [stderr] Checking savefile-derive v0.17.7 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Option<(usize, Vec)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:63:43 [INFO] [stdout] | [INFO] [stdout] 62 | let local_serializer: TokenStream = local_serializer.clone(); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | if let Some((_align, deferred)) = deferred_reprc.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 86 | return output.push(quote!( #(#fallbacks)* )); [INFO] [stdout] | ------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | / quote!( [INFO] [stdout] 94 | | unsafe { [INFO] [stdout] 95 | | if #(#conditions)* { [INFO] [stdout] 96 | | #local_serializer.raw_write_region(self,&#deferred_from,&#deferred_to, local_serializer.file_version)?; [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] 101 | | )); [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `proc_macro2::Ident` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/savefile_abi.rs:789:21 [INFO] [stdout] | [INFO] [stdout] 535 | let temp_arg_name = Ident::new(&format!("temp_{}_{}", arg_orig_name, nesting_level), Span::call_site()); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 536 | [INFO] [stdout] 537 | let layout_compatible = if let Some(arg_index) = arg_index { [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 789 | let temp_arg_name2 = Ident::new(&format!("temp2_{}", arg_orig_name), Span::call_site()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 859 | deserialized_type: quote! {AbiConnection::}, [INFO] [stdout] | ---------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 860 | callee_trampoline_temp_variable_declaration1: quote! { [INFO] [stdout] | ___________________________________________________________________- [INFO] [stdout] 861 | | let #mutsymbol #temp_arg_name; [INFO] [stdout] 862 | | let #mutsymbol #temp_arg_name2; [INFO] [stdout] 863 | | }, [INFO] [stdout] | |_____________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 864 | callee_trampoline_variable_deserializer1: quote! { [INFO] [stdout] | _______________________________________________________________- [INFO] [stdout] | |_______________________________________________________________| [INFO] [stdout] | |_______________________________________________________________| [INFO] [stdout] | |_______________________________________________________________| [INFO] [stdout] 865 | | { [INFO] [stdout] 866 | | #temp_arg_name = unsafe { AbiConnection::::from_raw_packaged(PackagedTraitObject::deser... [INFO] [stdout] 867 | | #temp_arg_name2 = move|#(#typedarglist,)*| {#temp_arg_name.docall(#(#arglist,)*)}; [INFO] [stdout] 868 | | #temp_arg_name2 [INFO] [stdout] 869 | | } [INFO] [stdout] 870 | | }, [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option<(usize, Vec)>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:63:43 [INFO] [stdout] | [INFO] [stdout] 62 | let local_serializer: TokenStream = local_serializer.clone(); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | if let Some((_align, deferred)) = deferred_reprc.take() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 86 | return output.push(quote!( #(#fallbacks)* )); [INFO] [stdout] | ------------------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | / quote!( [INFO] [stdout] 94 | | unsafe { [INFO] [stdout] 95 | | if #(#conditions)* { [INFO] [stdout] 96 | | #local_serializer.raw_write_region(self,&#deferred_from,&#deferred_to, local_serializer.file_version)?; [INFO] [stdout] ... | [INFO] [stdout] 100 | | } [INFO] [stdout] 101 | | )); [INFO] [stdout] | | - [INFO] [stdout] | |_____________| [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `proc_macro2::Ident` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/savefile_abi.rs:789:21 [INFO] [stdout] | [INFO] [stdout] 535 | let temp_arg_name = Ident::new(&format!("temp_{}_{}", arg_orig_name, nesting_level), Span::call_site()); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 536 | [INFO] [stdout] 537 | let layout_compatible = if let Some(arg_index) = arg_index { [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 789 | let temp_arg_name2 = Ident::new(&format!("temp2_{}", arg_orig_name), Span::call_site()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 859 | deserialized_type: quote! {AbiConnection::}, [INFO] [stdout] | ---------------------------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 860 | callee_trampoline_temp_variable_declaration1: quote! { [INFO] [stdout] | ___________________________________________________________________- [INFO] [stdout] 861 | | let #mutsymbol #temp_arg_name; [INFO] [stdout] 862 | | let #mutsymbol #temp_arg_name2; [INFO] [stdout] 863 | | }, [INFO] [stdout] | |_____________________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 864 | callee_trampoline_variable_deserializer1: quote! { [INFO] [stdout] | _______________________________________________________________- [INFO] [stdout] | |_______________________________________________________________| [INFO] [stdout] | |_______________________________________________________________| [INFO] [stdout] | |_______________________________________________________________| [INFO] [stdout] 865 | | { [INFO] [stdout] 866 | | #temp_arg_name = unsafe { AbiConnection::::from_raw_packaged(PackagedTraitObject::deser... [INFO] [stdout] 867 | | #temp_arg_name2 = move|#(#typedarglist,)*| {#temp_arg_name.docall(#(#arglist,)*)}; [INFO] [stdout] 868 | | #temp_arg_name2 [INFO] [stdout] 869 | | } [INFO] [stdout] 870 | | }, [INFO] [stdout] | | - [INFO] [stdout] | |_____________________| [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `savefile-derive` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `savefile-derive` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "87271ee7e1777fb34b2a9ab834f25d091aefe6a9b02ce175096089015e392d44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "87271ee7e1777fb34b2a9ab834f25d091aefe6a9b02ce175096089015e392d44", kill_on_drop: false }` [INFO] [stdout] 87271ee7e1777fb34b2a9ab834f25d091aefe6a9b02ce175096089015e392d44