[INFO] fetching crate savage_core 0.2.0... [INFO] checking savage_core-0.2.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate savage_core 0.2.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate savage_core 0.2.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate savage_core 0.2.0 [INFO] finished tweaking crates.io crate savage_core 0.2.0 [INFO] tweaked toml for crates.io crate savage_core 0.2.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 50 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.3.8 (available: v0.8.11) [INFO] [stderr] Adding chumsky v0.8.0 (available: v0.9.3) [INFO] [stderr] Adding darling v0.13.4 (available: v0.20.10) [INFO] [stderr] Adding darling_core v0.13.4 (available: v0.20.10) [INFO] [stderr] Adding darling_macro v0.13.4 (available: v0.20.10) [INFO] [stderr] Adding nalgebra v0.29.0 (available: v0.33.0) [INFO] [stderr] Adding nalgebra-macros v0.1.0 (available: v0.2.2) [INFO] [stderr] Adding simba v0.6.0 (available: v0.9.0) [INFO] [stderr] Adding strsim v0.10.0 (available: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4c614d8dcc5f960f36afa0eaae1881e7516b7b71f9f77ca0e5d5f0a375fc16e3 [INFO] running `Command { std: "docker" "start" "-a" "4c614d8dcc5f960f36afa0eaae1881e7516b7b71f9f77ca0e5d5f0a375fc16e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4c614d8dcc5f960f36afa0eaae1881e7516b7b71f9f77ca0e5d5f0a375fc16e3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c614d8dcc5f960f36afa0eaae1881e7516b7b71f9f77ca0e5d5f0a375fc16e3", kill_on_drop: false }` [INFO] [stdout] 4c614d8dcc5f960f36afa0eaae1881e7516b7b71f9f77ca0e5d5f0a375fc16e3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 01fbe111046c90895ed9c0a4aea4d02cb7588f2207d4c33c6fd86cb37a4fa5a9 [INFO] running `Command { std: "docker" "start" "-a" "01fbe111046c90895ed9c0a4aea4d02cb7588f2207d4c33c6fd86cb37a4fa5a9", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking bytemuck v1.18.0 [INFO] [stderr] Compiling matrixmultiply v0.3.9 [INFO] [stderr] Checking hamming v0.1.3 [INFO] [stderr] Checking primal-estimate v0.3.3 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking permutohedron v0.2.4 [INFO] [stderr] Compiling nalgebra-macros v0.1.0 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking primal-bit v0.3.2 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Checking safe_arch v0.7.2 [INFO] [stderr] Checking primal-sieve v0.3.7 [INFO] [stderr] Checking wide v0.7.28 [INFO] [stderr] Compiling getrandom v0.2.15 [INFO] [stderr] Compiling const-random-macro v0.1.16 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking const-random v0.1.18 [INFO] [stderr] Checking ahash v0.3.8 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking primal-check v0.3.4 [INFO] [stderr] Checking primal v0.3.3 [INFO] [stderr] Checking chumsky v0.8.0 [INFO] [stderr] Checking simba v0.6.0 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling savage_macros v0.1.0 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking nalgebra v0.29.0 [INFO] [stderr] Checking savage_core v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `(&expression::Expression, Type)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluate.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 79 | let a = a.evaluate_step(context)?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | [INFO] [stdout] 81 | match (self, a.typ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&expression::Expression, Type, Type)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluate.rs:151:15 [INFO] [stdout] | [INFO] [stdout] 145 | let a = a.evaluate_step(context)?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let b = b.evaluate_step(context)?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | match (self, a.typ(), b.typ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Type` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:118:37 [INFO] [stdout] | [INFO] [stdout] 117 | fn try_from(expression: Expression) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | if let Type::Number(z, _) = expression.typ() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Type` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:140:37 [INFO] [stdout] | [INFO] [stdout] 139 | fn try_from(expression: Expression) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | if let Type::Number(z, _) = expression.typ() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Type` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:162:37 [INFO] [stdout] | [INFO] [stdout] 161 | fn try_from(expression: Expression) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | if let Type::Number(z, _) = expression.typ() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Type` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:180:34 [INFO] [stdout] | [INFO] [stdout] 179 | fn try_from(expression: Expression) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | if let Type::Matrix(m) = expression.typ() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Type` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:202:34 [INFO] [stdout] | [INFO] [stdout] 201 | fn try_from(expression: Expression) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | if let Type::Matrix(m) = expression.typ() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&expression::Expression, Type)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluate.rs:81:15 [INFO] [stdout] | [INFO] [stdout] 79 | let a = a.evaluate_step(context)?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | [INFO] [stdout] 81 | match (self, a.typ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(&expression::Expression, Type, Type)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evaluate.rs:151:15 [INFO] [stdout] | [INFO] [stdout] 145 | let a = a.evaluate_step(context)?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let b = b.evaluate_step(context)?; [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | match (self, a.typ(), b.typ()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `savage_core` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Type` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:118:37 [INFO] [stdout] | [INFO] [stdout] 117 | fn try_from(expression: Expression) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | if let Type::Number(z, _) = expression.typ() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Type` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:140:37 [INFO] [stdout] | [INFO] [stdout] 139 | fn try_from(expression: Expression) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | if let Type::Number(z, _) = expression.typ() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Type` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:162:37 [INFO] [stdout] | [INFO] [stdout] 161 | fn try_from(expression: Expression) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | if let Type::Number(z, _) = expression.typ() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Type` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:180:34 [INFO] [stdout] | [INFO] [stdout] 179 | fn try_from(expression: Expression) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | if let Type::Matrix(m) = expression.typ() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Type` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/helpers.rs:202:34 [INFO] [stdout] | [INFO] [stdout] 201 | fn try_from(expression: Expression) -> Result { [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | if let Type::Matrix(m) = expression.typ() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `savage_core` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "01fbe111046c90895ed9c0a4aea4d02cb7588f2207d4c33c6fd86cb37a4fa5a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "01fbe111046c90895ed9c0a4aea4d02cb7588f2207d4c33c6fd86cb37a4fa5a9", kill_on_drop: false }` [INFO] [stdout] 01fbe111046c90895ed9c0a4aea4d02cb7588f2207d4c33c6fd86cb37a4fa5a9