[INFO] fetching crate satex-core 0.2.2... [INFO] checking satex-core-0.2.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate satex-core 0.2.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate satex-core 0.2.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate satex-core 0.2.2 [INFO] finished tweaking crates.io crate satex-core 0.2.2 [INFO] tweaked toml for crates.io crate satex-core 0.2.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 75 packages to latest compatible versions [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding sync_wrapper v0.1.2 (available: v1.0.1) [INFO] [stderr] Adding tower v0.4.13 (available: v0.5.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3470f60d8fe38ca6ba3a3b64eba58a11414b44716377e4870cf37d40b5d5ffb0 [INFO] running `Command { std: "docker" "start" "-a" "3470f60d8fe38ca6ba3a3b64eba58a11414b44716377e4870cf37d40b5d5ffb0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3470f60d8fe38ca6ba3a3b64eba58a11414b44716377e4870cf37d40b5d5ffb0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3470f60d8fe38ca6ba3a3b64eba58a11414b44716377e4870cf37d40b5d5ffb0", kill_on_drop: false }` [INFO] [stdout] 3470f60d8fe38ca6ba3a3b64eba58a11414b44716377e4870cf37d40b5d5ffb0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d1a1cb4ce93c3f726426e995fd417b1dba5cc168bf4806a7c14061cc75278659 [INFO] running `Command { std: "docker" "start" "-a" "d1a1cb4ce93c3f726426e995fd417b1dba5cc168bf4806a7c14061cc75278659", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking gimli v0.31.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking addr2line v0.24.1 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Compiling serde_derive v1.0.210 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling concat-idents v1.1.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde-this-or-that v0.4.2 [INFO] [stderr] Checking http-serde v2.1.1 [INFO] [stderr] Checking satex-core v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/body.rs:144:26 [INFO] [stdout] | [INFO] [stdout] 144 | match ready!(Pin::new(&mut self.inner).poll_frame(cx)?) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll::Ok, ::Error>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/body.rs:199:22 [INFO] [stdout] | [INFO] [stdout] 199 | match ready!(stream.try_poll_next(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/body.rs:144:26 [INFO] [stdout] | [INFO] [stdout] 144 | match ready!(Pin::new(&mut self.inner).poll_frame(cx)?) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll::Ok, ::Error>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/body.rs:199:22 [INFO] [stdout] | [INFO] [stdout] 199 | match ready!(stream.try_poll_next(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/pattern.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 120 | / fn serialize(&self, serializer: S) -> Result [INFO] [stdout] 121 | | where [INFO] [stdout] 122 | | S: Serializer, [INFO] [stdout] | |______________________- move the `impl` block outside of this method `serialize` [INFO] [stdout] 123 | { [INFO] [stdout] 124 | impl<'a> From for StrOrBool<'a> { [INFO] [stdout] | ^^^^^^^^^----^^^^^^^^^^^---------^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `StrOrBool` is not local [INFO] [stdout] | `From` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/pattern.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 120 | / fn serialize(&self, serializer: S) -> Result [INFO] [stdout] 121 | | where [INFO] [stdout] 122 | | S: Serializer, [INFO] [stdout] | |______________________- move the `impl` block outside of this method `serialize` [INFO] [stdout] ... [INFO] [stdout] 129 | impl<'a> From<&'a str> for StrOrBool<'a> { [INFO] [stdout] | ^^^^^^^^^----^^^^^^^^^^^^^^---------^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `StrOrBool` is not local [INFO] [stdout] | `From` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/pattern.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 120 | / fn serialize(&self, serializer: S) -> Result [INFO] [stdout] 121 | | where [INFO] [stdout] 122 | | S: Serializer, [INFO] [stdout] | |______________________- move the `impl` block outside of this method `serialize` [INFO] [stdout] 123 | { [INFO] [stdout] 124 | impl<'a> From for StrOrBool<'a> { [INFO] [stdout] | ^^^^^^^^^----^^^^^^^^^^^---------^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `StrOrBool` is not local [INFO] [stdout] | `From` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/pattern.rs:129:9 [INFO] [stdout] | [INFO] [stdout] 120 | / fn serialize(&self, serializer: S) -> Result [INFO] [stdout] 121 | | where [INFO] [stdout] 122 | | S: Serializer, [INFO] [stdout] | |______________________- move the `impl` block outside of this method `serialize` [INFO] [stdout] ... [INFO] [stdout] 129 | impl<'a> From<&'a str> for StrOrBool<'a> { [INFO] [stdout] | ^^^^^^^^^----^^^^^^^^^^^^^^---------^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `StrOrBool` is not local [INFO] [stdout] | `From` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `satex-core` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `satex-core` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d1a1cb4ce93c3f726426e995fd417b1dba5cc168bf4806a7c14061cc75278659", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d1a1cb4ce93c3f726426e995fd417b1dba5cc168bf4806a7c14061cc75278659", kill_on_drop: false }` [INFO] [stdout] d1a1cb4ce93c3f726426e995fd417b1dba5cc168bf4806a7c14061cc75278659