[INFO] fetching crate rustunnel 0.1.2... [INFO] checking rustunnel-0.1.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate rustunnel 0.1.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rustunnel 0.1.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustunnel 0.1.2 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate rustunnel 0.1.2 [INFO] tweaked toml for crates.io crate rustunnel 0.1.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 66 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding core-foundation v0.9.4 (available: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (available: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (available: v0.6.5) [INFO] [stderr] Adding memoffset v0.6.5 (available: v0.9.1) [INFO] [stderr] Adding nix v0.23.2 (available: v0.29.0) [INFO] [stderr] Adding security-framework v2.11.1 (available: v3.0.0) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (available: v0.13.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 34d85c3b9b811b4a2b53bfc394619b8513e69ed3441fdc6a1a17af30c760aca9 [INFO] running `Command { std: "docker" "start" "-a" "34d85c3b9b811b4a2b53bfc394619b8513e69ed3441fdc6a1a17af30c760aca9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "34d85c3b9b811b4a2b53bfc394619b8513e69ed3441fdc6a1a17af30c760aca9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34d85c3b9b811b4a2b53bfc394619b8513e69ed3441fdc6a1a17af30c760aca9", kill_on_drop: false }` [INFO] [stdout] 34d85c3b9b811b4a2b53bfc394619b8513e69ed3441fdc6a1a17af30c760aca9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b72963059dd75530e1b2391ae5cdc76f93ce54bb55a8542f5fb9a14a23a622ef [INFO] running `Command { std: "docker" "start" "-a" "b72963059dd75530e1b2391ae5cdc76f93ce54bb55a8542f5fb9a14a23a622ef", kill_on_drop: false }` [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking gimli v0.31.0 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Compiling seccomp-sys v0.1.3 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Compiling cc v1.1.21 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Compiling clear_on_drop v0.2.5 [INFO] [stderr] Compiling rustunnel v0.1.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking nix v0.23.2 [INFO] [stderr] Checking addr2line v0.24.1 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/sandbox.rs:61:56 [INFO] [stdout] | [INFO] [stdout] 61 | panic::set_hook(Box::new(move |panic_info: &panic::PanicInfo<'_>| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `openssl::pkcs12::ParsedPkcs12`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 42 | pkcs12: pkcs12::ParsedPkcs12, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `openssl::pkcs12::ParsedPkcs12::pkey`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:114:31 [INFO] [stdout] | [INFO] [stdout] 114 | .set_private_key(&tls_identity.pkcs12.pkey) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `openssl::pkcs12::ParsedPkcs12::cert`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:117:31 [INFO] [stdout] | [INFO] [stdout] 117 | .set_certificate(&tls_identity.pkcs12.cert) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `openssl::pkcs12::ParsedPkcs12::chain`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:119:30 [INFO] [stdout] | [INFO] [stdout] 119 | if let Some(chain) = tls_identity.pkcs12.chain { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `openssl::pkcs12::ParsedPkcs12::pkey`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:191:35 [INFO] [stdout] | [INFO] [stdout] 191 | .set_private_key(&tls_identity.pkcs12.pkey) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `openssl::pkcs12::ParsedPkcs12::cert`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:194:35 [INFO] [stdout] | [INFO] [stdout] 194 | .set_certificate(&tls_identity.pkcs12.cert) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `openssl::pkcs12::ParsedPkcs12::chain`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:196:34 [INFO] [stdout] | [INFO] [stdout] 196 | if let Some(chain) = tls_identity.pkcs12.chain { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `openssl::pkcs12::Pkcs12Ref::parse`: Use parse2 instead [INFO] [stdout] --> src/tls.rs:298:54 [INFO] [stdout] | [INFO] [stdout] 298 | let pkcs12 = pkcs12::Pkcs12::from_der(data)?.parse(password)?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MidHandshakeSslStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:398:45 [INFO] [stdout] | [INFO] [stdout] 394 | fn from(error: ssl::HandshakeError) -> Self { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 398 | ssl::HandshakeError::WouldBlock(stream) => match stream.error().code() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, ()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:15 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn run(mut self) -> Result<(), failure::Error> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | match handshake(self.tls_acceptor.accept(self.source_tcp_stream)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, ()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:205:15 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn run(mut self) -> Result<(), failure::Error> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | match handshake(self.tls_connector.connect(self.target_tcp_stream)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead [INFO] [stdout] --> src/sandbox.rs:61:56 [INFO] [stdout] | [INFO] [stdout] 61 | panic::set_hook(Box::new(move |panic_info: &panic::PanicInfo<'_>| { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `openssl::pkcs12::ParsedPkcs12`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 42 | pkcs12: pkcs12::ParsedPkcs12, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tls.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 81 | #[derive(Debug, failure::Fail)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_HandshakeFailure` [INFO] [stdout] 82 | pub(crate) enum HandshakeFailure { [INFO] [stdout] | ---------------- `HandshakeFailure` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `failure::Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `failure::Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `failure::Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tls.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 81 | #[derive(Debug, failure::Fail)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_HandshakeFailure` [INFO] [stdout] 82 | pub(crate) enum HandshakeFailure { [INFO] [stdout] | ---------------- `HandshakeFailure` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `failure::Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `failure::Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `failure::Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustunnel` (lib) due to 4 previous errors; 11 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: use of deprecated field `openssl::pkcs12::ParsedPkcs12::pkey`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:114:31 [INFO] [stdout] | [INFO] [stdout] 114 | .set_private_key(&tls_identity.pkcs12.pkey) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `openssl::pkcs12::ParsedPkcs12::cert`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:117:31 [INFO] [stdout] | [INFO] [stdout] 117 | .set_certificate(&tls_identity.pkcs12.cert) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `openssl::pkcs12::ParsedPkcs12::chain`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:119:30 [INFO] [stdout] | [INFO] [stdout] 119 | if let Some(chain) = tls_identity.pkcs12.chain { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `openssl::pkcs12::ParsedPkcs12::pkey`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:191:35 [INFO] [stdout] | [INFO] [stdout] 191 | .set_private_key(&tls_identity.pkcs12.pkey) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `openssl::pkcs12::ParsedPkcs12::cert`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:194:35 [INFO] [stdout] | [INFO] [stdout] 194 | .set_certificate(&tls_identity.pkcs12.cert) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated field `openssl::pkcs12::ParsedPkcs12::chain`: Use ParsedPkcs12_2 instead [INFO] [stdout] --> src/tls.rs:196:34 [INFO] [stdout] | [INFO] [stdout] 196 | if let Some(chain) = tls_identity.pkcs12.chain { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `openssl::pkcs12::Pkcs12Ref::parse`: Use parse2 instead [INFO] [stdout] --> src/tls.rs:298:54 [INFO] [stdout] | [INFO] [stdout] 298 | let pkcs12 = pkcs12::Pkcs12::from_der(data)?.parse(password)?; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `MidHandshakeSslStream` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tls.rs:398:45 [INFO] [stdout] | [INFO] [stdout] 394 | fn from(error: ssl::HandshakeError) -> Self { [INFO] [stdout] | ----- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 398 | ssl::HandshakeError::WouldBlock(stream) => match stream.error().code() { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, ()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:144:15 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn run(mut self) -> Result<(), failure::Error> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | match handshake(self.tls_acceptor.accept(self.source_tcp_stream)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, ()>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:205:15 [INFO] [stdout] | [INFO] [stdout] 201 | pub fn run(mut self) -> Result<(), failure::Error> { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | match handshake(self.tls_connector.connect(self.target_tcp_stream)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tls.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 81 | #[derive(Debug, failure::Fail)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_HandshakeFailure` [INFO] [stdout] 82 | pub(crate) enum HandshakeFailure { [INFO] [stdout] | ---------------- `HandshakeFailure` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `failure::Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `failure::Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `failure::Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/tls.rs:81:17 [INFO] [stdout] | [INFO] [stdout] 81 | #[derive(Debug, failure::Fail)] [INFO] [stdout] | ^------------ [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_HandshakeFailure` [INFO] [stdout] 82 | pub(crate) enum HandshakeFailure { [INFO] [stdout] | ---------------- `HandshakeFailure` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `failure::Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `failure::Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `failure::Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustunnel` (lib test) due to 4 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b72963059dd75530e1b2391ae5cdc76f93ce54bb55a8542f5fb9a14a23a622ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b72963059dd75530e1b2391ae5cdc76f93ce54bb55a8542f5fb9a14a23a622ef", kill_on_drop: false }` [INFO] [stdout] b72963059dd75530e1b2391ae5cdc76f93ce54bb55a8542f5fb9a14a23a622ef