[INFO] fetching crate rustofi 0.2.2... [INFO] checking rustofi-0.2.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate rustofi 0.2.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rustofi 0.2.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustofi 0.2.2 [INFO] finished tweaking crates.io crate rustofi 0.2.2 [INFO] tweaked toml for crates.io crate rustofi 0.2.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate rustofi 0.2.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 29fd1e57a88b1e1bae35d7ae478adcb0b4fb097973a69213e441945d04434a9a [INFO] running `Command { std: "docker" "start" "-a" "29fd1e57a88b1e1bae35d7ae478adcb0b4fb097973a69213e441945d04434a9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "29fd1e57a88b1e1bae35d7ae478adcb0b4fb097973a69213e441945d04434a9a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29fd1e57a88b1e1bae35d7ae478adcb0b4fb097973a69213e441945d04434a9a", kill_on_drop: false }` [INFO] [stdout] 29fd1e57a88b1e1bae35d7ae478adcb0b4fb097973a69213e441945d04434a9a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac3e8a13195870b773117e2107fe7856a5e8a0299f10299849f791277a14d755 [INFO] running `Command { std: "docker" "start" "-a" "ac3e8a13195870b773117e2107fe7856a5e8a0299f10299849f791277a14d755", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.6 [INFO] [stderr] Compiling syn v1.0.8 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling serde v1.0.102 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking half v1.4.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking dtoa v0.4.4 [INFO] [stderr] Checking yaml-rust v0.4.3 [INFO] [stderr] Compiling bincode v1.2.0 [INFO] [stderr] Compiling num-traits v0.2.9 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking subprocess v0.1.18 [INFO] [stderr] Compiling serde_derive v1.0.102 [INFO] [stderr] Checking rustofi v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/window.rs:144:15 [INFO] [stdout] | [INFO] [stdout] 140 | let mut p = Popen::create(&call, pc)?; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | match p.wait() { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/window.rs:40:17 [INFO] [stdout] | [INFO] [stdout] 40 | #[derive(Debug, ToPrimitive, Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `ToPrimitive` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_NUM_ToPrimitive_FOR_Location` [INFO] [stdout] 41 | pub enum Location { [INFO] [stdout] | -------- `Location` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `ToPrimitive` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `ToPrimitive` may come from an old version of the `num_derive` crate, try updating your dependency with `cargo update -p num_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `ToPrimitive` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustofi` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "ac3e8a13195870b773117e2107fe7856a5e8a0299f10299849f791277a14d755", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac3e8a13195870b773117e2107fe7856a5e8a0299f10299849f791277a14d755", kill_on_drop: false }` [INFO] [stdout] ac3e8a13195870b773117e2107fe7856a5e8a0299f10299849f791277a14d755