[INFO] fetching crate rustdds 0.11.0... [INFO] checking rustdds-0.11.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate rustdds 0.11.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rustdds 0.11.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rustdds 0.11.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate rustdds 0.11.0 [INFO] tweaked toml for crates.io crate rustdds 0.11.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate rustdds 0.11.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 206271342e514e2f2710337b1f022921392198987f29ca29d1fdea993de4d92f [INFO] running `Command { std: "docker" "start" "-a" "206271342e514e2f2710337b1f022921392198987f29ca29d1fdea993de4d92f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "206271342e514e2f2710337b1f022921392198987f29ca29d1fdea993de4d92f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "206271342e514e2f2710337b1f022921392198987f29ca29d1fdea993de4d92f", kill_on_drop: false }` [INFO] [stdout] 206271342e514e2f2710337b1f022921392198987f29ca29d1fdea993de4d92f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 257841e8fca1e8a134bf40f006b267fc5a65ffa598044130d2bc7182c161a80e [INFO] running `Command { std: "docker" "start" "-a" "257841e8fca1e8a134bf40f006b267fc5a65ffa598044130d2bc7182c161a80e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling io-lifetimes v2.0.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Compiling io-extras v0.18.2 [INFO] [stderr] Compiling socketpair v0.19.5 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking destructure_traitobject v0.2.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking piper v0.2.3 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking unsafe-any-ors v1.0.0 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking clap_builder v4.5.11 [INFO] [stderr] Checking typemap-ors v1.0.0 [INFO] [stderr] Checking bytes v1.7.0 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking hex-literal v0.4.1 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking async-executor v1.13.0 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking async-fs v2.1.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking thread-id v4.2.2 [INFO] [stderr] Checking if-addrs v0.13.3 [INFO] [stderr] Checking termion v4.0.2 [INFO] [stderr] Checking signal-hook v0.3.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking clap v4.5.11 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling cdr-encoding-size-derive v0.5.1 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking ctrlc v3.4.4 [INFO] [stderr] Checking cdr-encoding-size v0.5.1 [INFO] [stderr] Compiling test-case-core v3.3.1 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling enumflags2_derive v0.7.10 [INFO] [stderr] Compiling speedy-derive v0.8.7 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling test-case-macros v3.3.1 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Checking polling v3.7.2 [INFO] [stderr] Checking test-case v3.3.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking ppv-lite86 v0.2.19 [INFO] [stderr] Checking async-io v2.3.3 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking speedy v0.8.7 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking async-signal v0.2.9 [INFO] [stderr] Checking async-net v2.0.0 [INFO] [stderr] Checking async-process v2.2.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking smol v2.0.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking enumflags2 v0.7.10 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking cdr-encoding v0.10.1 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking test-log v0.2.16 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking log4rs v1.3.0 [INFO] [stderr] Checking rustdds v0.11.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tui v0.19.0 [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/discovery/discovery_db.rs:755:12 [INFO] [stdout] | [INFO] [stdout] 752 | pub fn get_local_topic_readers<'a, T: TopicDescription>( [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 755 | ) -> Vec<&DiscoveredReaderData> { [INFO] [stdout] | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), dds::result::WriteError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/discovery/discovery.rs:1851:11 [INFO] [stdout] | [INFO] [stdout] 1833 | let db = discovery_db_read(&self.discovery_db); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1851 | match self.dcps_topic.writer.write(topic_data.clone(), None) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option, bool, bool)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rtps/reader.rs:770:11 [INFO] [stdout] | [INFO] [stdout] 765 | data: Data, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 770 | match ( [INFO] [stdout] | ___________^ [INFO] [stdout] 771 | | data.serialized_payload, [INFO] [stdout] 772 | | data_flags.contains(DATA_Flags::Data), [INFO] [stdout] 773 | | data_flags.contains(DATA_Flags::Key), [INFO] [stdout] 774 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `U` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rtps/reader.rs:849:13 [INFO] [stdout] | [INFO] [stdout] 839 | fn with_mutable_writer_proxy(&mut self, writer_guid: GUID, worker: F) -> Option [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 849 | let res = worker(self, &mut wp); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, RecvTimeoutError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:275:11 [INFO] [stdout] | [INFO] [stdout] 202 | let (djh_sender, djh_receiver) = mio_channel::channel(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | let dp = DomainParticipant { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | let (discovery_started_sender, discovery_started_receiver) = std::sync::mpsc::channel(); [INFO] [stdout] | -------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | match discovery_started_receiver.recv_timeout(Duration::from_secs(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, DomainParticipantDisc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:339:5 [INFO] [stdout] | [INFO] [stdout] 338 | let w = self.weak_clone(); // this must be done first to avoid deadlock [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | self.dpi.lock()?.create_publisher(&w, qos) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, DomainParticipantDisc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:361:5 [INFO] [stdout] | [INFO] [stdout] 360 | let w = self.weak_clone(); // do this first, avoid deadlock [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 361 | self.dpi.lock()?.create_subscriber(&w, qos) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, DomainParticipantDisc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 390 | let w = self.weak_clone(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 391 | / self [INFO] [stdout] 392 | | .dpi [INFO] [stdout] 393 | | .lock()? [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, DomainParticipantDisc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:399:5 [INFO] [stdout] | [INFO] [stdout] 398 | let w = self.weak_clone(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 399 | self.dpi.lock()?.find_topic(&w, name, timeout) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:625:11 [INFO] [stdout] | [INFO] [stdout] 622 | let dp_lock = self.status_listener.dp_disc.lock().unwrap(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 623 | let mut w = dp_lock.status_channel_receiver().get_waker_update_lock(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 624 | // lock already at the beginning, before try_recv [INFO] [stdout] 625 | match dp_lock.status_channel_receiver().try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, DomainParticipantDisc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:724:9 [INFO] [stdout] | [INFO] [stdout] 723 | .and_then(|dpi| { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 724 | / dpi [INFO] [stdout] 725 | | .lock()? [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), mio_extras::channel::TrySendError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/statusevents.rs:98:11 [INFO] [stdout] | [INFO] [stdout] 97 | let mut w = self.waker.lock().unwrap(); // lock already at the beginning [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | match self.actual_sender.try_send(t) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/statusevents.rs:229:11 [INFO] [stdout] | [INFO] [stdout] 227 | let mut w = self.sync_receiver.get_waker_update_lock(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | // lock already at the beginning, before try_recv [INFO] [stdout] 229 | match self.sync_receiver.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result::K>>, dds::result::ReadError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/with_key/datareader.rs:926:11 [INFO] [stdout] | [INFO] [stdout] 921 | let mut datareader = match self.lock_datareader() { [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 926 | match datareader.take_bare(1, ReadCondition::not_read()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>, dds::result::ReadError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/with_key/datareader.rs:1018:11 [INFO] [stdout] | [INFO] [stdout] 1013 | let mut datareader = match self.lock_datareader() { [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1018 | match datareader.take(1, ReadCondition::not_read()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `K` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/with_key/datasample.rs:48:23 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn unwrap(self) -> D { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Sample::Dispose(_k) => panic!("Unwrap called on a Sample with no data"), [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), mio_extras::channel::TrySendError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/with_key/datawriter.rs:374:11 [INFO] [stdout] | [INFO] [stdout] 347 | data: D, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 374 | match try_send_timeout(&self.cc_upload, writer_command, timeout) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 16 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustdds` (lib) due to 17 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::result::Result<(), dds::result::WriteError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/discovery/discovery.rs:1851:11 [INFO] [stdout] | [INFO] [stdout] 1833 | let db = discovery_db_read(&self.discovery_db); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1851 | match self.dcps_topic.writer.write(topic_data.clone(), None) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `bytes::Bytes` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/discovery/spdp_participant_data.rs:620:15 [INFO] [stdout] | [INFO] [stdout] 606 | let data = spdp_participant_data_raw(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 609 | let submsgs = rtpsmsg.submessages(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 620 | let sdata = participant_data [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(std::option::Option, bool, bool)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rtps/reader.rs:770:11 [INFO] [stdout] | [INFO] [stdout] 765 | data: Data, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 770 | match ( [INFO] [stdout] | ___________^ [INFO] [stdout] 771 | | data.serialized_payload, [INFO] [stdout] 772 | | data_flags.contains(DATA_Flags::Data), [INFO] [stdout] 773 | | data_flags.contains(DATA_Flags::Key), [INFO] [stdout] 774 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `U` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rtps/reader.rs:849:13 [INFO] [stdout] | [INFO] [stdout] 839 | fn with_mutable_writer_proxy(&mut self, writer_guid: GUID, worker: F) -> Option [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 849 | let res = worker(self, &mut wp); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result, RecvTimeoutError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:275:11 [INFO] [stdout] | [INFO] [stdout] 202 | let (djh_sender, djh_receiver) = mio_channel::channel(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 246 | let dp = DomainParticipant { [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | let (discovery_started_sender, discovery_started_receiver) = std::sync::mpsc::channel(); [INFO] [stdout] | -------------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 275 | match discovery_started_receiver.recv_timeout(Duration::from_secs(10)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, DomainParticipantDisc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:339:5 [INFO] [stdout] | [INFO] [stdout] 338 | let w = self.weak_clone(); // this must be done first to avoid deadlock [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 339 | self.dpi.lock()?.create_publisher(&w, qos) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, DomainParticipantDisc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:361:5 [INFO] [stdout] | [INFO] [stdout] 360 | let w = self.weak_clone(); // do this first, avoid deadlock [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 361 | self.dpi.lock()?.create_subscriber(&w, qos) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, DomainParticipantDisc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 390 | let w = self.weak_clone(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 391 | / self [INFO] [stdout] 392 | | .dpi [INFO] [stdout] 393 | | .lock()? [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, DomainParticipantDisc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:399:5 [INFO] [stdout] | [INFO] [stdout] 398 | let w = self.weak_clone(); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 399 | self.dpi.lock()?.find_topic(&w, name, timeout) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:625:11 [INFO] [stdout] | [INFO] [stdout] 622 | let dp_lock = self.status_listener.dp_disc.lock().unwrap(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 623 | let mut w = dp_lock.status_channel_receiver().get_waker_update_lock(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 624 | // lock already at the beginning, before try_recv [INFO] [stdout] 625 | match dp_lock.status_channel_receiver().try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::sync::MutexGuard<'_, DomainParticipantDisc>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/participant.rs:724:9 [INFO] [stdout] | [INFO] [stdout] 723 | .and_then(|dpi| { [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 724 | / dpi [INFO] [stdout] 725 | | .lock()? [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), mio_extras::channel::TrySendError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/statusevents.rs:98:11 [INFO] [stdout] | [INFO] [stdout] 97 | let mut w = self.waker.lock().unwrap(); // lock already at the beginning [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | match self.actual_sender.try_send(t) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/statusevents.rs:229:11 [INFO] [stdout] | [INFO] [stdout] 227 | let mut w = self.sync_receiver.get_waker_update_lock(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | // lock already at the beginning, before try_recv [INFO] [stdout] 229 | match self.sync_receiver.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result::K>>, dds::result::ReadError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/with_key/datareader.rs:926:11 [INFO] [stdout] | [INFO] [stdout] 921 | let mut datareader = match self.lock_datareader() { [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 926 | match datareader.take_bare(1, ReadCondition::not_read()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result>, dds::result::ReadError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/with_key/datareader.rs:1018:11 [INFO] [stdout] | [INFO] [stdout] 1013 | let mut datareader = match self.lock_datareader() { [INFO] [stdout] | -------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1018 | match datareader.take(1, ReadCondition::not_read()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `K` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/with_key/datasample.rs:48:23 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn unwrap(self) -> D { [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | Sample::Dispose(_k) => panic!("Unwrap called on a Sample with no data"), [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::result::Result<(), mio_extras::channel::TrySendError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dds/with_key/datawriter.rs:374:11 [INFO] [stdout] | [INFO] [stdout] 347 | data: D, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 374 | match try_send_timeout(&self.cc_upload, writer_command, timeout) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustdds` (lib test) due to 18 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "257841e8fca1e8a134bf40f006b267fc5a65ffa598044130d2bc7182c161a80e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "257841e8fca1e8a134bf40f006b267fc5a65ffa598044130d2bc7182c161a80e", kill_on_drop: false }` [INFO] [stdout] 257841e8fca1e8a134bf40f006b267fc5a65ffa598044130d2bc7182c161a80e