[INFO] fetching crate rust-unixfs 0.4.1... [INFO] checking rust-unixfs-0.4.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate rust-unixfs 0.4.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rust-unixfs 0.4.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rust-unixfs 0.4.1 [INFO] finished tweaking crates.io crate rust-unixfs 0.4.1 [INFO] tweaked toml for crates.io crate rust-unixfs 0.4.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate rust-unixfs 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cabe25164c20b1500e769fff7a593f4181e2b310accb747c0c6f83b7e544123d [INFO] running `Command { std: "docker" "start" "-a" "cabe25164c20b1500e769fff7a593f4181e2b310accb747c0c6f83b7e544123d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cabe25164c20b1500e769fff7a593f4181e2b310accb747c0c6f83b7e544123d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cabe25164c20b1500e769fff7a593f4181e2b310accb747c0c6f83b7e544123d", kill_on_drop: false }` [INFO] [stdout] cabe25164c20b1500e769fff7a593f4181e2b310accb747c0c6f83b7e544123d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 129e8ca6b5acc83780390bc763b776cd84443efbeb8d5fcccd448cd71e35a86d [INFO] running `Command { std: "docker" "start" "-a" "129e8ca6b5acc83780390bc763b776cd84443efbeb8d5fcccd448cd71e35a86d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling serde v1.0.196 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking arrayref v0.3.7 [INFO] [stderr] Checking constant_time_eq v0.3.0 [INFO] [stderr] Compiling data-encoding v2.5.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Checking unsigned-varint v0.7.2 [INFO] [stderr] Checking base-x v0.2.11 [INFO] [stderr] Compiling serde_json v1.0.113 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking blake2s_simd v1.0.2 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking blake2b_simd v1.0.2 [INFO] [stderr] Checking quick-protobuf v0.8.1 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Checking half v2.3.1 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking textwrap v0.16.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking tar v0.4.40 [INFO] [stderr] Compiling hex-literal v0.3.4 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking regex-automata v0.4.5 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Compiling blake3 v1.5.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.12 [INFO] [stderr] Compiling toml v0.5.11 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling serde_derive v1.0.196 [INFO] [stderr] Checking data-encoding-macro v0.1.14 [INFO] [stderr] Checking multibase v0.9.1 [INFO] [stderr] Compiling proc-macro-crate v1.1.3 [INFO] [stderr] Compiling multihash-derive v0.8.1 [INFO] [stderr] Compiling libipld-cbor-derive v0.16.0 [INFO] [stderr] Checking multihash v0.18.1 [INFO] [stderr] Checking cid v0.10.1 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking libipld-core v0.16.0 [INFO] [stderr] Checking libipld-pb v0.16.0 [INFO] [stderr] Checking libipld-macro v0.16.0 [INFO] [stderr] Checking libipld-cbor v0.16.0 [INFO] [stderr] Checking libipld-json v0.16.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking libipld v0.16.0 [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stderr] Checking rust-unixfs v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `unwrap_borrowed` is never used [INFO] [stdout] --> src/file.rs:156:8 [INFO] [stdout] | [INFO] [stdout] 154 | pub(crate) trait UnwrapBorrowedExt<'a> { [INFO] [stdout] | ----------------- method in this trait [INFO] [stdout] 155 | /// Does not default but requires there to be an borrowed inner value. [INFO] [stdout] 156 | fn unwrap_borrowed(self) -> &'a [u8]; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `file::reader::FileContent<'_, I>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file/reader.rs:251:13 [INFO] [stdout] | [INFO] [stdout] 248 | pub fn unwrap_content(self) -> &'a [u8] { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 251 | y => panic!("Expected FileContent::Bytes, found: {y:?}"), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, LookupError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/sharded_lookup.rs:362:13 [INFO] [stdout] | [INFO] [stdout] 357 | let found = ShardedLookup::lookup_or_start(parsed, "bin", &mut None); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | x => unreachable!("{:?}", x), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `LookupError` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dir/sharded_lookup.rs:394:13 [INFO] [stdout] | [INFO] [stdout] 372 | let see_next = ShardedLookup::lookup_or_start(parsed, "formal", &mut None); [INFO] [stdout] | -------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 391 | let err = next.continue_walk(FILE, &mut None).unwrap_err(); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 394 | x => unreachable!("{:?}", x), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust-unixfs` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "129e8ca6b5acc83780390bc763b776cd84443efbeb8d5fcccd448cd71e35a86d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "129e8ca6b5acc83780390bc763b776cd84443efbeb8d5fcccd448cd71e35a86d", kill_on_drop: false }` [INFO] [stdout] 129e8ca6b5acc83780390bc763b776cd84443efbeb8d5fcccd448cd71e35a86d