[INFO] fetching crate rslock 0.5.0... [INFO] checking rslock-0.5.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate rslock 0.5.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate rslock 0.5.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rslock 0.5.0 [INFO] finished tweaking crates.io crate rslock 0.5.0 [INFO] tweaked toml for crates.io crate rslock 0.5.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate rslock 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b52c5f1d3c2ad19faa1d08dde1a89b4a952efe67e8b6d7f28c4266a5e95253cf [INFO] running `Command { std: "docker" "start" "-a" "b52c5f1d3c2ad19faa1d08dde1a89b4a952efe67e8b6d7f28c4266a5e95253cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b52c5f1d3c2ad19faa1d08dde1a89b4a952efe67e8b6d7f28c4266a5e95253cf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b52c5f1d3c2ad19faa1d08dde1a89b4a952efe67e8b6d7f28c4266a5e95253cf", kill_on_drop: false }` [INFO] [stdout] b52c5f1d3c2ad19faa1d08dde1a89b4a952efe67e8b6d7f28c4266a5e95253cf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a36d20d68db10af243d0e29732c63cd985c14b7af868977bac79eededf597554 [INFO] running `Command { std: "docker" "start" "-a" "a36d20d68db10af243d0e29732c63cd985c14b7af868977bac79eededf597554", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking litemap v0.7.3 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking writeable v0.5.5 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking value-bag v1.9.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking icu_locid_transform_data v1.5.0 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking icu_properties_data v1.5.0 [INFO] [stderr] Checking write16 v1.0.0 [INFO] [stderr] Checking utf8_iter v1.0.4 [INFO] [stderr] Checking icu_normalizer_data v1.5.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking utf16_iter v1.0.5 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Checking piper v0.2.3 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking sha1_smol v1.0.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking async-lock v3.4.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking polling v2.8.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking async-executor v1.12.0 [INFO] [stderr] Checking blocking v1.6.1 [INFO] [stderr] Checking rustix v0.37.27 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking async-io v1.13.0 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Checking polling v3.7.2 [INFO] [stderr] Checking async-io v2.3.3 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Compiling synstructure v0.13.1 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling zerofrom-derive v0.1.4 [INFO] [stderr] Compiling yoke-derive v0.7.4 [INFO] [stderr] Compiling zerovec-derive v0.10.2 [INFO] [stderr] Compiling displaydoc v0.2.4 [INFO] [stderr] Compiling icu_provider_macros v1.5.0 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling serde_derive v1.0.203 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling serde_with_macros v1.5.2 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking zerofrom v0.1.4 [INFO] [stderr] Checking yoke v0.7.4 [INFO] [stderr] Checking zerovec v0.10.2 [INFO] [stderr] Checking tinystr v0.7.6 [INFO] [stderr] Checking icu_collections v1.5.0 [INFO] [stderr] Checking icu_locid v1.5.0 [INFO] [stderr] Checking icu_provider v1.5.0 [INFO] [stderr] Checking icu_locid_transform v1.5.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking icu_properties v1.5.0 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking serde_with v1.14.0 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking icu_normalizer v1.5.0 [INFO] [stderr] Checking idna v1.0.0 [INFO] [stderr] Checking bollard-stubs v1.41.0 [INFO] [stderr] Checking url v2.5.1 [INFO] [stderr] Checking redis v0.24.0 [INFO] [stderr] Checking rslock v0.5.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking testcontainers v0.14.0 [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> examples/shared_lock.rs:42:15 [INFO] [stdout] | [INFO] [stdout] 25 | let lock; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | match rl_clone.extend(&lock, Duration::from_millis(2000)).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rslock` (example "shared_lock") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:625:29 [INFO] [stdout] | [INFO] [stdout] 617 | let lock_guard = rl.acquire(&key, Duration::from_millis(1000)).await.unwrap(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 625 | if let Ok(_l) = rl2.lock(&key, Duration::from_millis(1000)).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:701:19 [INFO] [stdout] | [INFO] [stdout] 685 | let lock1 = rl1 [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 701 | match rl2.lock(&key, Duration::from_millis(1000)).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:743:19 [INFO] [stdout] | [INFO] [stdout] 726 | let lock1 = rl1.acquire(&key, Duration::from_millis(500)).await.unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 743 | match rl1.extend(&lock1.lock, Duration::from_millis(1000)).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:789:15 [INFO] [stdout] | [INFO] [stdout] 783 | let (_containers, addresses) = create_clients(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 784 | let rl = LockManager::new(addresses.clone()); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 789 | match rl.lock(&key, ttl).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `lock::Lock` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:987:16 [INFO] [stdout] | [INFO] [stdout] 979 | let (_containers, _) = create_clients(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 980 | let rl = LockManager::new(Vec::::new()); // No Redis clients, simulate failure [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 981 | [INFO] [stdout] 982 | let lock_result = rl [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 987 | Ok(lock) => { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `lock::Lock` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:1013:16 [INFO] [stdout] | [INFO] [stdout] 1005 | let (_containers, _) = create_clients(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1006 | let rl = LockManager::new(Vec::::new()); // No Redis clients, simulate failure [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1007 | [INFO] [stdout] 1008 | let lock_result = rl [INFO] [stdout] | ----------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1013 | Ok(lock) => match rl.is_freed(&lock).await { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:1053:15 [INFO] [stdout] | [INFO] [stdout] 1031 | let (_containers, addresses) = create_clients(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1032 | let rl = LockManager::new(addresses.clone()); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1033 | [INFO] [stdout] 1034 | let lock = rl [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1040 | let mut con = rl.lock_manager_inner.servers[0] [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1053 | match rl.is_freed(&lock).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lock.rs:1084:15 [INFO] [stdout] | [INFO] [stdout] 1065 | let (_containers, addresses) = create_clients(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1066 | let rl = LockManager::new(addresses.clone()); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1067 | [INFO] [stdout] 1068 | let lock = rl [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1074 | let mut con = rl.lock_manager_inner.servers[0] [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1084 | match rl.is_freed(&lock).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rslock` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "a36d20d68db10af243d0e29732c63cd985c14b7af868977bac79eededf597554", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a36d20d68db10af243d0e29732c63cd985c14b7af868977bac79eededf597554", kill_on_drop: false }` [INFO] [stdout] a36d20d68db10af243d0e29732c63cd985c14b7af868977bac79eededf597554