[INFO] fetching crate rsfs-tokio 0.5.0... [INFO] checking rsfs-tokio-0.5.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate rsfs-tokio 0.5.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate rsfs-tokio 0.5.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rsfs-tokio 0.5.0 [INFO] finished tweaking crates.io crate rsfs-tokio 0.5.0 [INFO] tweaked toml for crates.io crate rsfs-tokio 0.5.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 50 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding memoffset v0.7.1 (available: v0.9.1) [INFO] [stderr] Adding nix v0.26.4 (available: v0.29.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] abdec5ea6fd7f28059cc501e58c2e6c376c61561f001617ce97cc7e8783e3e06 [INFO] running `Command { std: "docker" "start" "-a" "abdec5ea6fd7f28059cc501e58c2e6c376c61561f001617ce97cc7e8783e3e06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "abdec5ea6fd7f28059cc501e58c2e6c376c61561f001617ce97cc7e8783e3e06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "abdec5ea6fd7f28059cc501e58c2e6c376c61561f001617ce97cc7e8783e3e06", kill_on_drop: false }` [INFO] [stdout] abdec5ea6fd7f28059cc501e58c2e6c376c61561f001617ce97cc7e8783e3e06 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d60058b61f92620e76399f6eb592850e19fe7eab7c3d6e4ecb5a956d9b0c97c8 [INFO] running `Command { std: "docker" "start" "-a" "d60058b61f92620e76399f6eb592850e19fe7eab7c3d6e4ecb5a956d9b0c97c8", kill_on_drop: false }` [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling async-trait v0.1.83 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio-stream v0.1.16 [INFO] [stderr] Checking rsfs-tokio v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:2844:17 [INFO] [stdout] | [INFO] [stdout] 2841 | path: P, [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 2842 | err: Option, [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 2843 | ) { [INFO] [stdout] 2844 | let res = fs [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/ptr.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | this.ptr == other.ptr [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 30 | std::ptr::addr_eq(this.ptr, other.ptr) [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 30 | std::ptr::eq(this.ptr, other.ptr) [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `parking_lot::lock_api::MutexGuard<'_, parking_lot::RawMutex, FileCursor>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem/unix.rs:3578:17 [INFO] [stdout] | [INFO] [stdout] 3485 | let fs = FS::with_mode(0o300); [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3531 | let mut f = fs.new_openopts().write(true).open("f").await.unwrap(); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3549 | let mut z = fs [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 3578 | let cursor = f.cursor.lock(); // re-check the initial f [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: ambiguous wide pointer comparison, the comparison includes metadata which may not be expected [INFO] [stdout] --> src/ptr.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | this.ptr == other.ptr [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(ambiguous_wide_pointer_comparisons)]` on by default [INFO] [stdout] help: use `std::ptr::addr_eq` or untyped pointers to only compare their addresses [INFO] [stdout] | [INFO] [stdout] 30 | std::ptr::addr_eq(this.ptr, other.ptr) [INFO] [stdout] | ++++++++++++++++++ ~ + [INFO] [stdout] help: use explicit `std::ptr::eq` method to compare metadata and addresses [INFO] [stdout] | [INFO] [stdout] 30 | std::ptr::eq(this.ptr, other.ptr) [INFO] [stdout] | +++++++++++++ ~ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rsfs-tokio` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d60058b61f92620e76399f6eb592850e19fe7eab7c3d6e4ecb5a956d9b0c97c8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d60058b61f92620e76399f6eb592850e19fe7eab7c3d6e4ecb5a956d9b0c97c8", kill_on_drop: false }` [INFO] [stdout] d60058b61f92620e76399f6eb592850e19fe7eab7c3d6e4ecb5a956d9b0c97c8