[INFO] fetching crate rscontainer 0.1.0... [INFO] checking rscontainer-0.1.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate rscontainer 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rscontainer 0.1.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rscontainer 0.1.0 [INFO] finished tweaking crates.io crate rscontainer 0.1.0 [INFO] tweaked toml for crates.io crate rscontainer 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d9b5dd330afdefc8b170cdf7a7908f4cf9dc529f679c87e4f832e9a2cb270ebd [INFO] running `Command { std: "docker" "start" "-a" "d9b5dd330afdefc8b170cdf7a7908f4cf9dc529f679c87e4f832e9a2cb270ebd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d9b5dd330afdefc8b170cdf7a7908f4cf9dc529f679c87e4f832e9a2cb270ebd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9b5dd330afdefc8b170cdf7a7908f4cf9dc529f679c87e4f832e9a2cb270ebd", kill_on_drop: false }` [INFO] [stdout] d9b5dd330afdefc8b170cdf7a7908f4cf9dc529f679c87e4f832e9a2cb270ebd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e23e3bc9278a2143a9a59b4409c6472f24e8b327fa5693a19d9655ae3fb5eea1 [INFO] running `Command { std: "docker" "start" "-a" "e23e3bc9278a2143a9a59b4409c6472f24e8b327fa5693a19d9655ae3fb5eea1", kill_on_drop: false }` [INFO] [stderr] Checking rscontainer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result, BorrowError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:238:15 [INFO] [stdout] | [INFO] [stdout] 237 | fn try_access) -> U>(&self, f: F) -> Option { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | match self.try_borrow() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, TryLockError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:265:15 [INFO] [stdout] | [INFO] [stdout] 264 | fn try_access) -> U>(&self, f: F) -> Option { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | match self.try_lock() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, TryLockError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:284:15 [INFO] [stdout] | [INFO] [stdout] 283 | fn try_access) -> U>(&self, f: F) -> Option { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | match self.try_read() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, BorrowMutError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:329:15 [INFO] [stdout] | [INFO] [stdout] 328 | fn try_access_mut) -> U>(&self, f: F) -> Option { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | match self.try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, TryLockError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:358:15 [INFO] [stdout] | [INFO] [stdout] 357 | fn try_access_mut) -> U>(&self, f: F) -> Option { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 358 | match self.try_lock() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, TryLockError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:377:15 [INFO] [stdout] | [INFO] [stdout] 376 | fn try_access_mut) -> U>(&self, f: F) -> Option { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 377 | match self.try_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/builder.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | let mut entry = self.entry(TypeId::of::()); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rscontainer` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Result, BorrowError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:238:15 [INFO] [stdout] | [INFO] [stdout] 237 | fn try_access) -> U>(&self, f: F) -> Option { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 238 | match self.try_borrow() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, TryLockError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:265:15 [INFO] [stdout] | [INFO] [stdout] 264 | fn try_access) -> U>(&self, f: F) -> Option { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | match self.try_lock() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, TryLockError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:284:15 [INFO] [stdout] | [INFO] [stdout] 283 | fn try_access) -> U>(&self, f: F) -> Option { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | match self.try_read() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, BorrowMutError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:329:15 [INFO] [stdout] | [INFO] [stdout] 328 | fn try_access_mut) -> U>(&self, f: F) -> Option { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | match self.try_borrow_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, TryLockError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:358:15 [INFO] [stdout] | [INFO] [stdout] 357 | fn try_access_mut) -> U>(&self, f: F) -> Option { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 358 | match self.try_lock() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, TryLockError>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/access.rs:377:15 [INFO] [stdout] | [INFO] [stdout] 376 | fn try_access_mut) -> U>(&self, f: F) -> Option { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 377 | match self.try_write() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/builder.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | let mut entry = self.entry(TypeId::of::()); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rscontainer` (lib test) due to 7 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "e23e3bc9278a2143a9a59b4409c6472f24e8b327fa5693a19d9655ae3fb5eea1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e23e3bc9278a2143a9a59b4409c6472f24e8b327fa5693a19d9655ae3fb5eea1", kill_on_drop: false }` [INFO] [stdout] e23e3bc9278a2143a9a59b4409c6472f24e8b327fa5693a19d9655ae3fb5eea1