[INFO] fetching crate routerify-ws 3.0.0... [INFO] checking routerify-ws-3.0.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate routerify-ws 3.0.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate routerify-ws 3.0.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate routerify-ws 3.0.0 [INFO] finished tweaking crates.io crate routerify-ws 3.0.0 [INFO] tweaked toml for crates.io crate routerify-ws 3.0.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate routerify-ws 3.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3f37412bea279fa553b1d8e5496d611d2d7ce89fa25e3d517dcb431e184ad8c4 [INFO] running `Command { std: "docker" "start" "-a" "3f37412bea279fa553b1d8e5496d611d2d7ce89fa25e3d517dcb431e184ad8c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3f37412bea279fa553b1d8e5496d611d2d7ce89fa25e3d517dcb431e184ad8c4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f37412bea279fa553b1d8e5496d611d2d7ce89fa25e3d517dcb431e184ad8c4", kill_on_drop: false }` [INFO] [stdout] 3f37412bea279fa553b1d8e5496d611d2d7ce89fa25e3d517dcb431e184ad8c4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d9def8eb522da27f470f1a848a26fc31c3657b12c5e415e739ab52b91dbf3991 [INFO] running `Command { std: "docker" "start" "-a" "d9def8eb522da27f470f1a848a26fc31c3657b12c5e415e739ab52b91dbf3991", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.84 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling futures-core v0.3.19 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Checking http v0.2.6 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Checking futures-sink v0.3.19 [INFO] [stderr] Compiling futures-util v0.3.19 [INFO] [stderr] Checking smallvec v1.7.0 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking lock_api v0.4.5 [INFO] [stderr] Compiling quote v1.0.14 [INFO] [stderr] Checking ring v0.16.20 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling serde_derive v1.0.132 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Checking futures-io v0.3.19 [INFO] [stderr] Compiling serde v1.0.132 [INFO] [stderr] Checking futures-channel v0.3.19 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking webpki v0.22.0 [INFO] [stderr] Checking sct v0.7.0 [INFO] [stderr] Checking rustls v0.20.2 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking sha-1 v0.9.8 [INFO] [stderr] Checking http-body v0.4.4 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Checking headers v0.3.5 [INFO] [stderr] Checking futures v0.3.19 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling derive_more v0.99.17 [INFO] [stderr] Checking tokio v1.15.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tungstenite v0.16.0 [INFO] [stderr] Checking hyper v0.14.16 [INFO] [stderr] Checking tokio-tungstenite v0.16.1 [INFO] [stderr] Checking routerify v3.0.0 [INFO] [stderr] Checking routerify-ws v3.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `std::vec::IntoIter` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upgrade.rs:299:5 [INFO] [stdout] | [INFO] [stdout] 296 | fn encode_header(h: T) -> HeaderValue { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | val.into_iter().nth(0).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:64:22 [INFO] [stdout] | [INFO] [stdout] 64 | match ready!(Pin::new(&mut self.inner).poll_next(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:76:22 [INFO] [stdout] | [INFO] [stdout] 76 | match ready!(Pin::new(&mut self.inner).poll_ready(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 90 | match ready!(Pin::new(&mut self.inner).poll_flush(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 97 | match ready!(Pin::new(&mut self.inner).poll_close(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Display)] [INFO] [stdout] | -^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `_derive_more_DisplayAs` is not local [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_derive_more_DisplayAs_impl` and up 2 bodies [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `derive_more` crate, try updating your dependency with `cargo update -p derive_more` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `routerify-ws` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stdout] error: this value of type `std::vec::IntoIter` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upgrade.rs:299:5 [INFO] [stdout] | [INFO] [stdout] 296 | fn encode_header(h: T) -> HeaderValue { [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 299 | val.into_iter().nth(0).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Poll>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:64:22 [INFO] [stdout] | [INFO] [stdout] 64 | match ready!(Pin::new(&mut self.inner).poll_next(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:76:22 [INFO] [stdout] | [INFO] [stdout] 76 | match ready!(Pin::new(&mut self.inner).poll_ready(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:90:22 [INFO] [stdout] | [INFO] [stdout] 90 | match ready!(Pin::new(&mut self.inner).poll_flush(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/websocket.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 97 | match ready!(Pin::new(&mut self.inner).poll_close(cx)) { [INFO] [stdout] | -------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/error.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | #[derive(Display)] [INFO] [stdout] | -^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `_derive_more_DisplayAs` is not local [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_derive_more_DisplayAs_impl` and up 2 bodies [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Display` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Display` may come from an old version of the `derive_more` crate, try updating your dependency with `cargo update -p derive_more` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Display` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `routerify-ws` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "d9def8eb522da27f470f1a848a26fc31c3657b12c5e415e739ab52b91dbf3991", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9def8eb522da27f470f1a848a26fc31c3657b12c5e415e739ab52b91dbf3991", kill_on_drop: false }` [INFO] [stdout] d9def8eb522da27f470f1a848a26fc31c3657b12c5e415e739ab52b91dbf3991