[INFO] fetching crate roundqueue 0.2.9... [INFO] checking roundqueue-0.2.9 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate roundqueue 0.2.9 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate roundqueue 0.2.9 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate roundqueue 0.2.9 [INFO] finished tweaking crates.io crate roundqueue 0.2.9 [INFO] tweaked toml for crates.io crate roundqueue 0.2.9 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate roundqueue 0.2.9 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 802c722a00a9de99bac3e4b89a2c01c752ae5d8ac642cd219ba838d73281309a [INFO] running `Command { std: "docker" "start" "-a" "802c722a00a9de99bac3e4b89a2c01c752ae5d8ac642cd219ba838d73281309a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "802c722a00a9de99bac3e4b89a2c01c752ae5d8ac642cd219ba838d73281309a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "802c722a00a9de99bac3e4b89a2c01c752ae5d8ac642cd219ba838d73281309a", kill_on_drop: false }` [INFO] [stdout] 802c722a00a9de99bac3e4b89a2c01c752ae5d8ac642cd219ba838d73281309a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2ee1ced8fe496a8ea19d7c5a670f7dcaca4113b95f816e7394cf815d61d8c853 [INFO] running `Command { std: "docker" "start" "-a" "2ee1ced8fe496a8ea19d7c5a670f7dcaca4113b95f816e7394cf815d61d8c853", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling crc32fast v1.2.1 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Compiling serde_json v1.0.62 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking rle-decode-fast v1.0.1 [INFO] [stderr] Checking libflate_lz77 v1.0.0 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking match_cfg v0.1.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking hex v0.4.2 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Checking libflate v1.0.3 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking filetime v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking unix-daemonize v0.1.2 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking shared_child v0.3.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking dirs v3.0.1 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking notify v4.0.15 [INFO] [stderr] Checking procfs v0.8.1 [INFO] [stderr] Compiling git-version-macro v0.3.4 [INFO] [stderr] Checking git-version v0.3.4 [INFO] [stderr] Checking roundqueue v0.2.9 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:15 [INFO] [stdout] | [INFO] [stdout] 121 | let mut f = std::fs::File::open(fname)?; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | match serde_json::from_slice::(&data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:291:15 [INFO] [stdout] | [INFO] [stdout] 288 | let mut f = std::fs::File::open(fname)?; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | match serde_json::from_slice::(&data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:15 [INFO] [stdout] | [INFO] [stdout] 121 | let mut f = std::fs::File::open(fname)?; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | match serde_json::from_slice::(&data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:291:15 [INFO] [stdout] | [INFO] [stdout] 288 | let mut f = std::fs::File::open(fname)?; [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 291 | match serde_json::from_slice::(&data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:366:21 [INFO] [stdout] | [INFO] [stdout] 366 | for node in std::fs::read_dir(my_homedir.join(RQ)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 366 | while let Ok(node) = std::fs::read_dir(my_homedir.join(RQ)) { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 366 | for node in std::fs::read_dir(my_homedir.join(RQ))? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 366 | if let Ok(node) = std::fs::read_dir(my_homedir.join(RQ)) { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `roundqueue` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:366:21 [INFO] [stdout] | [INFO] [stdout] 366 | for node in std::fs::read_dir(my_homedir.join(RQ)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 366 | while let Ok(node) = std::fs::read_dir(my_homedir.join(RQ)) { [INFO] [stdout] | ~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 366 | for node in std::fs::read_dir(my_homedir.join(RQ))? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 366 | if let Ok(node) = std::fs::read_dir(my_homedir.join(RQ)) { [INFO] [stdout] | ~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `roundqueue` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "2ee1ced8fe496a8ea19d7c5a670f7dcaca4113b95f816e7394cf815d61d8c853", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ee1ced8fe496a8ea19d7c5a670f7dcaca4113b95f816e7394cf815d61d8c853", kill_on_drop: false }` [INFO] [stdout] 2ee1ced8fe496a8ea19d7c5a670f7dcaca4113b95f816e7394cf815d61d8c853