[INFO] fetching crate ross 0.1.7... [INFO] checking ross-0.1.7 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate ross 0.1.7 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate ross 0.1.7 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ross 0.1.7 [INFO] finished tweaking crates.io crate ross 0.1.7 [INFO] tweaked toml for crates.io crate ross 0.1.7 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.6.10 (available: v1.1.3) [INFO] [stderr] Adding crossbeam v0.2.12 (available: v0.8.4) [INFO] [stderr] Adding futures v0.1.31 (available: v0.3.30) [INFO] [stderr] Adding num v0.1.42 (available: v0.4.3) [INFO] [stderr] Adding num-bigint v0.1.44 (available: v0.4.6) [INFO] [stderr] Adding num-complex v0.1.43 (available: v0.4.6) [INFO] [stderr] Adding num-rational v0.1.42 (available: v0.4.2) [INFO] [stderr] Adding owning_ref v0.2.4 (available: v0.4.1) [INFO] [stderr] Adding parking_lot v0.3.8 (available: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.2.14 (available: v0.9.10) [INFO] [stderr] Adding rand v0.3.23 (available: v0.8.5) [INFO] [stderr] Adding rand v0.4.6 (available: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding redox_syscall v0.1.57 (available: v0.5.6) [INFO] [stderr] Adding regex v0.2.11 (available: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (available: v0.8.4) [INFO] [stderr] Adding smallvec v0.3.4 (available: v1.13.2) [INFO] [stderr] Adding smallvec v0.6.14 (available: v1.13.2) [INFO] [stderr] Adding statistical v0.1.1 (available: v1.0.0) [INFO] [stderr] Adding thread-id v3.3.0 (available: v4.2.2) [INFO] [stderr] Adding thread_local v0.3.6 (available: v1.1.8) [INFO] [stderr] Adding time v0.1.45 (available: v0.3.36) [INFO] [stderr] Adding ucd-util v0.1.10 (available: v0.2.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e8a7f25a47ff95f525b5d9f5fc778609b9f73ed32168f893cd12ee9144a7ca44 [INFO] running `Command { std: "docker" "start" "-a" "e8a7f25a47ff95f525b5d9f5fc778609b9f73ed32168f893cd12ee9144a7ca44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e8a7f25a47ff95f525b5d9f5fc778609b9f73ed32168f893cd12ee9144a7ca44", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e8a7f25a47ff95f525b5d9f5fc778609b9f73ed32168f893cd12ee9144a7ca44", kill_on_drop: false }` [INFO] [stdout] e8a7f25a47ff95f525b5d9f5fc778609b9f73ed32168f893cd12ee9144a7ca44 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb8f7174b92582ce9c359a4eb4a1d5fe4761ed7a220090711e1ea11f56ea7726 [INFO] running `Command { std: "docker" "start" "-a" "bb8f7174b92582ce9c359a4eb4a1d5fe4761ed7a220090711e1ea11f56ea7726", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Checking owning_ref v0.2.4 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking smallvec v0.3.4 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Checking crossbeam v0.2.12 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking parking_lot v0.3.8 [INFO] [stderr] Checking multiqueue v0.3.2 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking statistical v0.1.1 [INFO] [stderr] Checking ross v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/io/seq.rs:49:36 [INFO] [stdout] | [INFO] [stdout] 49 | fn sanitize_id(id: &String) -> (String); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - fn sanitize_id(id: &String) -> (String); [INFO] [stdout] 49 + fn sanitize_id(id: &String) -> String; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/io/seq.rs:116:36 [INFO] [stdout] | [INFO] [stdout] 116 | fn sanitize_id(id: &String) -> (String) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 116 - fn sanitize_id(id: &String) -> (String) { [INFO] [stdout] 116 + fn sanitize_id(id: &String) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/io/seq.rs:49:36 [INFO] [stdout] | [INFO] [stdout] 49 | fn sanitize_id(id: &String) -> (String); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - fn sanitize_id(id: &String) -> (String); [INFO] [stdout] 49 + fn sanitize_id(id: &String) -> String; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/io/seq.rs:116:36 [INFO] [stdout] | [INFO] [stdout] 116 | fn sanitize_id(id: &String) -> (String) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 116 - fn sanitize_id(id: &String) -> (String) { [INFO] [stdout] 116 + fn sanitize_id(id: &String) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/friends_replace.rs:71:28 [INFO] [stdout] | [INFO] [stdout] 53 | let find_regex = Regex::new(&find_param) [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let mut buffer_iter = my_buffer.lines(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | while let Some(line) = buffer_iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ross` (bin "friends_replace" test) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/friends_replace.rs:71:28 [INFO] [stdout] | [INFO] [stdout] 53 | let find_regex = Regex::new(&find_param) [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let mut buffer_iter = my_buffer.lines(); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | while let Some(line) = buffer_iter.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ross` (bin "friends_replace") due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "bb8f7174b92582ce9c359a4eb4a1d5fe4761ed7a220090711e1ea11f56ea7726", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb8f7174b92582ce9c359a4eb4a1d5fe4761ed7a220090711e1ea11f56ea7726", kill_on_drop: false }` [INFO] [stdout] bb8f7174b92582ce9c359a4eb4a1d5fe4761ed7a220090711e1ea11f56ea7726