[INFO] fetching crate retriever 0.0.3... [INFO] checking retriever-0.0.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate retriever 0.0.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate retriever 0.0.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate retriever 0.0.3 [INFO] finished tweaking crates.io crate retriever 0.0.3 [INFO] tweaked toml for crates.io crate retriever 0.0.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 108 packages to latest compatible versions [INFO] [stderr] Adding autocfg v0.1.8 (available: v1.3.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding cloudabi v0.0.3 (available: v0.1.0) [INFO] [stderr] Adding colored v1.9.4 (available: v2.1.0) [INFO] [stderr] Adding criterion v0.3.6 (available: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (available: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (available: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding rand v0.6.5 (available: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.1.1 (available: v0.3.1) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rand_hc v0.1.0 (available: v0.3.2) [INFO] [stderr] Adding rand_isaac v0.1.1 (available: v0.3.0) [INFO] [stderr] Adding rand_jitter v0.1.4 (available: v0.4.0) [INFO] [stderr] Adding rand_os v0.1.3 (available: v0.2.2) [INFO] [stderr] Adding rand_pcg v0.1.2 (available: v0.3.1) [INFO] [stderr] Adding rand_xorshift v0.1.1 (available: v0.3.0) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding simple_logger v1.16.0 (available: v5.0.0) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding windows-core v0.52.0 (available: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6384fe3a843e10b119057ede07c3433f9be8c2ada508fc915b0733a8725e7900 [INFO] running `Command { std: "docker" "start" "-a" "6384fe3a843e10b119057ede07c3433f9be8c2ada508fc915b0733a8725e7900", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6384fe3a843e10b119057ede07c3433f9be8c2ada508fc915b0733a8725e7900", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6384fe3a843e10b119057ede07c3433f9be8c2ada508fc915b0733a8725e7900", kill_on_drop: false }` [INFO] [stdout] 6384fe3a843e10b119057ede07c3433f9be8c2ada508fc915b0733a8725e7900 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f49b6a80e4e3fa353c7df24fd2eb2d6b6358188b72c5af02614db9dc1672018 [INFO] running `Command { std: "docker" "start" "-a" "8f49b6a80e4e3fa353c7df24fd2eb2d6b6358188b72c5af02614db9dc1672018", kill_on_drop: false }` [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Compiling num-conv v0.1.0 [INFO] [stderr] Compiling time-core v0.1.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking retriever v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/bits/bitfield.rs:5:32 [INFO] [stdout] | [INFO] [stdout] 5 | pub(crate) const BITS: usize = (std::mem::size_of::() * 8); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 5 - pub(crate) const BITS: usize = (std::mem::size_of::() * 8); [INFO] [stdout] 5 + pub(crate) const BITS: usize = std::mem::size_of::() * 8; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking time v0.3.36 [INFO] [stdout] error: this value of type `Flatten<<>::ItemIdxSet as IdxSet>::IdxIter>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/chunk_storage.rs:138:20 [INFO] [stdout] | [INFO] [stdout] 131 | pub(crate) fn modify<'a, Q, F>(&'a mut self, query: &Q, f: F) [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | let chunk_key: ChunkKey::Owned = self.chunk_key.clone(); [INFO] [stdout] | --------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | [INFO] [stdout] 138 | for idx in query [INFO] [stdout] | ____________________^ [INFO] [stdout] 139 | | .item_idxs(self.chunk_key.borrow(), &self) [INFO] [stdout] 140 | | .into_idx_iter() [INFO] [stdout] 141 | | .flatten() [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Element` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/types/entry.rs:61:17 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn or_insert_with(mut self, f: F) -> &'a mut Element [INFO] [stdout] | -------- - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let new_value: Element = f(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/types/entry.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 99 | panic!(format!( [INFO] [stdout] | ____________________^ [INFO] [stdout] 100 | | "retriever: Entry::or_panic(): {:?} doesn't exist", [INFO] [stdout] 101 | | &self.id [INFO] [stdout] 102 | | )) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: the `panic!()` macro supports formatting, so there's no need for the `format!()` macro here [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` on by default [INFO] [stdout] help: remove the `format!(..)` macro call [INFO] [stdout] | [INFO] [stdout] 99 ~ panic!( [INFO] [stdout] 100 | "retriever: Entry::or_panic(): {:?} doesn't exist", [INFO] [stdout] 101 | &self.id [INFO] [stdout] 102 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `retriever` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "8f49b6a80e4e3fa353c7df24fd2eb2d6b6358188b72c5af02614db9dc1672018", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f49b6a80e4e3fa353c7df24fd2eb2d6b6358188b72c5af02614db9dc1672018", kill_on_drop: false }` [INFO] [stdout] 8f49b6a80e4e3fa353c7df24fd2eb2d6b6358188b72c5af02614db9dc1672018