[INFO] fetching crate resufancy 0.1.1... [INFO] checking resufancy-0.1.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate resufancy 0.1.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate resufancy 0.1.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate resufancy 0.1.1 [INFO] finished tweaking crates.io crate resufancy 0.1.1 [INFO] tweaked toml for crates.io crate resufancy 0.1.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 103 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding cfg-if v0.1.10 (available: v1.0.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.5.18) [INFO] [stderr] Adding fsevent v0.4.0 (available: v2.1.2) [INFO] [stderr] Adding fsevent-sys v2.0.1 (available: v4.1.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding idna v0.1.5 (available: v1.0.2) [INFO] [stderr] Adding inotify v0.7.1 (available: v0.11.0) [INFO] [stderr] Adding lazy_static v0.2.11 (available: v1.5.0) [INFO] [stderr] Adding log v0.3.9 (available: v0.4.22) [INFO] [stderr] Adding mio v0.6.23 (available: v1.0.2) [INFO] [stderr] Adding miow v0.2.2 (available: v0.6.0) [INFO] [stderr] Adding notify v4.0.18 (available: v6.1.1) [INFO] [stderr] Adding percent-encoding v1.0.1 (available: v2.3.1) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding rand v0.4.6 (available: v0.8.5) [INFO] [stderr] Adding rand_core v0.3.1 (available: v0.6.4) [INFO] [stderr] Adding rand_core v0.4.2 (available: v0.6.4) [INFO] [stderr] Adding rdrand v0.4.0 (available: v0.8.3) [INFO] [stderr] Adding remove_dir_all v0.5.3 (available: v0.8.4) [INFO] [stderr] Adding strsim v0.8.0 (available: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (available: v0.16.1) [INFO] [stderr] Adding thread-id v2.0.0 (available: v4.2.2) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding url v1.7.2 (available: v2.5.2) [INFO] [stderr] Adding winapi v0.2.8 (available: v0.3.9) [INFO] [stderr] Adding wkhtmltopdf v0.3.0 (available: v0.4.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ae15384527b1981cf76e797e17c986006e6e7f3636fb2b92e99db8914363946c [INFO] running `Command { std: "docker" "start" "-a" "ae15384527b1981cf76e797e17c986006e6e7f3636fb2b92e99db8914363946c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ae15384527b1981cf76e797e17c986006e6e7f3636fb2b92e99db8914363946c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ae15384527b1981cf76e797e17c986006e6e7f3636fb2b92e99db8914363946c", kill_on_drop: false }` [INFO] [stdout] ae15384527b1981cf76e797e17c986006e6e7f3636fb2b92e99db8914363946c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a549f0e028dd85df987cadea702941e5af9bb758f68bff075bcc0ae8b0789191 [INFO] running `Command { std: "docker" "start" "-a" "a549f0e028dd85df987cadea702941e5af9bb758f68bff075bcc0ae8b0789191", kill_on_drop: false }` [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking matches v0.1.10 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking lazycell v1.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking ucd-trie v0.1.6 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking wkhtmltox-sys v0.1.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking filesystem v0.4.4 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking notify v4.0.18 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Checking wkhtmltopdf v0.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.64 [INFO] [stderr] Compiling thiserror v1.0.64 [INFO] [stderr] Compiling pest v2.7.13 [INFO] [stderr] Compiling pest_meta v2.7.13 [INFO] [stderr] Compiling pest_generator v2.7.13 [INFO] [stderr] Compiling pest_derive v2.7.13 [INFO] [stderr] Checking pug_tmp_workaround v0.1.9 [INFO] [stderr] Checking resufancy v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/commands/args.rs:7:50 [INFO] [stdout] | [INFO] [stdout] 7 | pub static ref TEMPLATE: Template<'static> = { Template::new() }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 7 - pub static ref TEMPLATE: Template<'static> = { Template::new() }; [INFO] [stdout] 7 + pub static ref TEMPLATE: Template<'static> = Template::new(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/commands/args.rs:11:42 [INFO] [stdout] | [INFO] [stdout] 11 | pub static ref SKIP_HTML: SkipHtml = { SkipHtml::default() }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 11 - pub static ref SKIP_HTML: SkipHtml = { SkipHtml::default() }; [INFO] [stdout] 11 + pub static ref SKIP_HTML: SkipHtml = SkipHtml::default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/commands/args.rs:15:40 [INFO] [stdout] | [INFO] [stdout] 15 | pub static ref SKIP_PDF: SkipPdf = { SkipPdf::default() }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 15 - pub static ref SKIP_PDF: SkipPdf = { SkipPdf::default() }; [INFO] [stdout] 15 + pub static ref SKIP_PDF: SkipPdf = SkipPdf::default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/commands/args.rs:19:35 [INFO] [stdout] | [INFO] [stdout] 19 | pub static ref WATCH: Watch = { Watch::default() }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 19 - pub static ref WATCH: Watch = { Watch::default() }; [INFO] [stdout] 19 + pub static ref WATCH: Watch = Watch::default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/commands/args.rs:7:50 [INFO] [stdout] | [INFO] [stdout] 7 | pub static ref TEMPLATE: Template<'static> = { Template::new() }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 7 - pub static ref TEMPLATE: Template<'static> = { Template::new() }; [INFO] [stdout] 7 + pub static ref TEMPLATE: Template<'static> = Template::new(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/commands/args.rs:11:42 [INFO] [stdout] | [INFO] [stdout] 11 | pub static ref SKIP_HTML: SkipHtml = { SkipHtml::default() }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 11 - pub static ref SKIP_HTML: SkipHtml = { SkipHtml::default() }; [INFO] [stdout] 11 + pub static ref SKIP_HTML: SkipHtml = SkipHtml::default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/commands/args.rs:15:40 [INFO] [stdout] | [INFO] [stdout] 15 | pub static ref SKIP_PDF: SkipPdf = { SkipPdf::default() }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 15 - pub static ref SKIP_PDF: SkipPdf = { SkipPdf::default() }; [INFO] [stdout] 15 + pub static ref SKIP_PDF: SkipPdf = SkipPdf::default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/commands/args.rs:19:35 [INFO] [stdout] | [INFO] [stdout] 19 | pub static ref WATCH: Watch = { Watch::default() }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 19 - pub static ref WATCH: Watch = { Watch::default() }; [INFO] [stdout] 19 + pub static ref WATCH: Watch = Watch::default(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Option, resufancy::error::Error>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 25 | let subcommands = Commands::new(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let matches = app.get_matches(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | [INFO] [stdout] 39 | if let Some(result) = subcommands.run(&matches) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `resufancy` (bin "resufancy") due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Option, resufancy::error::Error>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:39:27 [INFO] [stdout] | [INFO] [stdout] 25 | let subcommands = Commands::new(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let matches = app.get_matches(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | [INFO] [stdout] 39 | if let Some(result) = subcommands.run(&matches) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `resufancy` (bin "resufancy" test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a549f0e028dd85df987cadea702941e5af9bb758f68bff075bcc0ae8b0789191", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a549f0e028dd85df987cadea702941e5af9bb758f68bff075bcc0ae8b0789191", kill_on_drop: false }` [INFO] [stdout] a549f0e028dd85df987cadea702941e5af9bb758f68bff075bcc0ae8b0789191