[INFO] fetching crate reliudp 0.2.0... [INFO] checking reliudp-0.2.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate reliudp 0.2.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate reliudp 0.2.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate reliudp 0.2.0 [INFO] finished tweaking crates.io crate reliudp 0.2.0 [INFO] tweaked toml for crates.io crate reliudp 0.2.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate reliudp 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a74428cba94ed9402b83b44c102bd9beb39f6da08453419379193951d82f3650 [INFO] running `Command { std: "docker" "start" "-a" "a74428cba94ed9402b83b44c102bd9beb39f6da08453419379193951d82f3650", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a74428cba94ed9402b83b44c102bd9beb39f6da08453419379193951d82f3650", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a74428cba94ed9402b83b44c102bd9beb39f6da08453419379193951d82f3650", kill_on_drop: false }` [INFO] [stdout] a74428cba94ed9402b83b44c102bd9beb39f6da08453419379193951d82f3650 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3804eec1648a507d7e7883f9dfdaf2baedb39b48fec5a8c8e18539a561dbf4bc [INFO] running `Command { std: "docker" "start" "-a" "3804eec1648a507d7e7883f9dfdaf2baedb39b48fec5a8c8e18539a561dbf4bc", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling build_const v0.2.1 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking byteorder v1.2.3 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Compiling crc v1.8.1 [INFO] [stderr] Checking reliudp v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/fragment.rs:150:141 [INFO] [stdout] | [INFO] [stdout] 150 | ...s_from_bytes<'a>(data: &'a [u8], seq_id: u32, frag_meta: FragmentMeta) -> Result<(Box src/fragment.rs:150:141 [INFO] [stdout] | [INFO] [stdout] 150 | ...s_from_bytes<'a>(data: &'a [u8], seq_id: u32, frag_meta: FragmentMeta) -> Result<(Box, BuildHasherDefault>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragment_combiner.rs:46:47 [INFO] [stdout] | [INFO] [stdout] 45 | let old_state = ::std::mem::replace(&mut self.state, FragmentSetState::Complete(iteration_n, 0)); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | if let FragmentSetState::Incomplete { fragments } = old_state { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>>, UdpPacketError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rudp.rs:262:34 [INFO] [stdout] | [INFO] [stdout] 261 | ...oming(udp_socket: Arc, incoming_packet: UdpPacket>, incoming_address: SocketAddr) -> Result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `clone_box` is never used [INFO] [stdout] --> src/misc.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub (crate) trait ClonableIterator<'a>: Iterator { [INFO] [stdout] | ---------------- method in this trait [INFO] [stdout] 2 | fn clone_box(&self) -> Box + 'a>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/fragment_combiner.rs:19:14 [INFO] [stdout] | [INFO] [stdout] 19 | Complete(u64, u8) [INFO] [stdout] | -------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FragmentSetState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 19 | Complete((), u8) [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reliudp` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `HashMap, BuildHasherDefault>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fragment_combiner.rs:46:47 [INFO] [stdout] | [INFO] [stdout] 45 | let old_state = ::std::mem::replace(&mut self.state, FragmentSetState::Complete(iteration_n, 0)); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | if let FragmentSetState::Incomplete { fragments } = old_state { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `misc::OwnedSlice>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/udp_packet.rs:455:68 [INFO] [stdout] | [INFO] [stdout] 453 | let received_packet = udp_message.compute_packet().unwrap(); [INFO] [stdout] | --------------- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 454 | [INFO] [stdout] 455 | if let Packet::Fragment(Fragment {seq_id, frag_id, frag_total, data, frag_meta}) = received_packet { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result>>, UdpPacketError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rudp.rs:262:34 [INFO] [stdout] | [INFO] [stdout] 261 | ...oming(udp_socket: Arc, incoming_packet: UdpPacket>, incoming_address: SocketAddr) -> Result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `clone_box` is never used [INFO] [stdout] --> src/misc.rs:2:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub (crate) trait ClonableIterator<'a>: Iterator { [INFO] [stdout] | ---------------- method in this trait [INFO] [stdout] 2 | fn clone_box(&self) -> Box + 'a>; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/fragment_combiner.rs:19:14 [INFO] [stdout] | [INFO] [stdout] 19 | Complete(u64, u8) [INFO] [stdout] | -------- ^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FragmentSetState` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 19 | Complete((), u8) [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reliudp` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3804eec1648a507d7e7883f9dfdaf2baedb39b48fec5a8c8e18539a561dbf4bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3804eec1648a507d7e7883f9dfdaf2baedb39b48fec5a8c8e18539a561dbf4bc", kill_on_drop: false }` [INFO] [stdout] 3804eec1648a507d7e7883f9dfdaf2baedb39b48fec5a8c8e18539a561dbf4bc