[INFO] fetching crate regent-internals 0.2.0... [INFO] checking regent-internals-0.2.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate regent-internals 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate regent-internals 0.2.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate regent-internals 0.2.0 [INFO] finished tweaking crates.io crate regent-internals 0.2.0 [INFO] tweaked toml for crates.io crate regent-internals 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] [stderr] Adding darling v0.14.4 (available: v0.20.10) [INFO] [stderr] Adding darling_core v0.14.4 (available: v0.20.10) [INFO] [stderr] Adding darling_macro v0.14.4 (available: v0.20.10) [INFO] [stderr] Adding strsim v0.10.0 (available: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (available: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0775b5ea434d6b3e9ed6ffa243a383a441464204dde4bfd53a5f23645a9b48e1 [INFO] running `Command { std: "docker" "start" "-a" "0775b5ea434d6b3e9ed6ffa243a383a441464204dde4bfd53a5f23645a9b48e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0775b5ea434d6b3e9ed6ffa243a383a441464204dde4bfd53a5f23645a9b48e1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0775b5ea434d6b3e9ed6ffa243a383a441464204dde4bfd53a5f23645a9b48e1", kill_on_drop: false }` [INFO] [stdout] 0775b5ea434d6b3e9ed6ffa243a383a441464204dde4bfd53a5f23645a9b48e1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] aa32cbbcaf83b463ade753c6c0fa086ac72e21d9b86dcee5e506be1312666374 [INFO] running `Command { std: "docker" "start" "-a" "aa32cbbcaf83b463ade753c6c0fa086ac72e21d9b86dcee5e506be1312666374", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking darling_core v0.14.4 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Checking darling v0.14.4 [INFO] [stderr] Checking regent-internals v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:383:29 [INFO] [stdout] | [INFO] [stdout] 377 | field_as_repr: TokenStream2, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | let mut tmp_elems = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 401 | / quote!({ [INFO] [stdout] 402 | | let tmp = (#(#tmp_elems),*); [INFO] [stdout] 403 | | [INFO] [stdout] 404 | | (#(#elems),*) [INFO] [stdout] 405 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 416 | / quote!({ [INFO] [stdout] 417 | | let mut get_elem = || { [INFO] [stdout] 418 | | let elem = #elem_decoded; [INFO] [stdout] 419 | | #field_as_repr >>= #elem_width; [INFO] [stdout] ... | [INFO] [stdout] 424 | | [#(#elems),*] [INFO] [stdout] 425 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:374:9 [INFO] [stdout] | [INFO] [stdout] 342 | fn bitwise_on_struct(expected_width: Option, item: syn::ItemStruct) -> TokenStream { [INFO] [stdout] | ----------------------------------------------------------------------------------------- move the `impl` block outside of this function `bitwise_on_struct` [INFO] [stdout] ... [INFO] [stdout] 374 | impl Type { [INFO] [stdout] | ^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | `Type` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:472:9 [INFO] [stdout] | [INFO] [stdout] 342 | fn bitwise_on_struct(expected_width: Option, item: syn::ItemStruct) -> TokenStream { [INFO] [stdout] | ----------------------------------------------------------------------------------------- move the `impl` block outside of this function `bitwise_on_struct` [INFO] [stdout] ... [INFO] [stdout] 472 | impl PrimeType { [INFO] [stdout] | ^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | `PrimeType` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Vec` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:383:29 [INFO] [stdout] | [INFO] [stdout] 377 | field_as_repr: TokenStream2, [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | let mut tmp_elems = Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 401 | / quote!({ [INFO] [stdout] 402 | | let tmp = (#(#tmp_elems),*); [INFO] [stdout] 403 | | [INFO] [stdout] 404 | | (#(#elems),*) [INFO] [stdout] 405 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 416 | / quote!({ [INFO] [stdout] 417 | | let mut get_elem = || { [INFO] [stdout] 418 | | let elem = #elem_decoded; [INFO] [stdout] 419 | | #field_as_repr >>= #elem_width; [INFO] [stdout] ... | [INFO] [stdout] 424 | | [#(#elems),*] [INFO] [stdout] 425 | | }) [INFO] [stdout] | | - [INFO] [stdout] | |__________________________| [INFO] [stdout] | |__________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `regent-internals` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:374:9 [INFO] [stdout] | [INFO] [stdout] 342 | fn bitwise_on_struct(expected_width: Option, item: syn::ItemStruct) -> TokenStream { [INFO] [stdout] | ----------------------------------------------------------------------------------------- move the `impl` block outside of this function `bitwise_on_struct` [INFO] [stdout] ... [INFO] [stdout] 374 | impl Type { [INFO] [stdout] | ^^^^^---- [INFO] [stdout] | | [INFO] [stdout] | `Type` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/lib.rs:472:9 [INFO] [stdout] | [INFO] [stdout] 342 | fn bitwise_on_struct(expected_width: Option, item: syn::ItemStruct) -> TokenStream { [INFO] [stdout] | ----------------------------------------------------------------------------------------- move the `impl` block outside of this function `bitwise_on_struct` [INFO] [stdout] ... [INFO] [stdout] 472 | impl PrimeType { [INFO] [stdout] | ^^^^^--------- [INFO] [stdout] | | [INFO] [stdout] | `PrimeType` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `regent-internals` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "aa32cbbcaf83b463ade753c6c0fa086ac72e21d9b86dcee5e506be1312666374", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa32cbbcaf83b463ade753c6c0fa086ac72e21d9b86dcee5e506be1312666374", kill_on_drop: false }` [INFO] [stdout] aa32cbbcaf83b463ade753c6c0fa086ac72e21d9b86dcee5e506be1312666374