[INFO] fetching crate redis-pubsub 0.0.1... [INFO] checking redis-pubsub-0.0.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate redis-pubsub 0.0.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate redis-pubsub 0.0.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate redis-pubsub 0.0.1 [INFO] finished tweaking crates.io crate redis-pubsub 0.0.1 [INFO] tweaked toml for crates.io crate redis-pubsub 0.0.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate redis-pubsub 0.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd3365a4840ba21f2df964124e42442a2900a19d8b7af4c9395dcc2c1ef79d6a [INFO] running `Command { std: "docker" "start" "-a" "cd3365a4840ba21f2df964124e42442a2900a19d8b7af4c9395dcc2c1ef79d6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd3365a4840ba21f2df964124e42442a2900a19d8b7af4c9395dcc2c1ef79d6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd3365a4840ba21f2df964124e42442a2900a19d8b7af4c9395dcc2c1ef79d6a", kill_on_drop: false }` [INFO] [stdout] cd3365a4840ba21f2df964124e42442a2900a19d8b7af4c9395dcc2c1ef79d6a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5fe0f529e569f8d43699ea3db60760b835960e9816c1f5d49eac2a79223edfda [INFO] running `Command { std: "docker" "start" "-a" "5fe0f529e569f8d43699ea3db60760b835960e9816c1f5d49eac2a79223edfda", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.37 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.91 [INFO] [stderr] Compiling libc v0.2.122 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking pin-project-lite v0.2.8 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Checking futures-sink v0.3.21 [INFO] [stderr] Checking matches v0.1.9 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Checking unicode-bidi v0.3.7 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking tinyvec v1.5.1 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Compiling async-trait v0.1.53 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking tracing-core v0.1.24 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking sha1_smol v1.0.0 [INFO] [stderr] Checking form_urlencoded v1.0.1 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking sha1 v0.6.1 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking unicode-normalization v0.1.19 [INFO] [stderr] Compiling quote v1.0.17 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking mio v0.8.2 [INFO] [stderr] Checking getrandom v0.2.6 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking idna v0.2.3 [INFO] [stderr] Checking url v2.2.2 [INFO] [stderr] Compiling tokio-macros v1.7.0 [INFO] [stderr] Compiling tracing-attributes v0.1.20 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling async-stream-impl v0.3.3 [INFO] [stderr] Checking tokio v1.17.0 [INFO] [stderr] Checking async-stream v0.3.3 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tracing v0.1.33 [INFO] [stderr] Checking tokio-util v0.6.9 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Checking combine v4.6.3 [INFO] [stderr] Checking redis-pubsub v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `impl Future>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redis_sub.rs:163:21 [INFO] [stdout] | [INFO] [stdout] 163 | Ok(Box::pin(stream! { [INFO] [stdout] | _____________________^ [INFO] [stdout] 164 | | loop { [INFO] [stdout] 165 | | let (mut read, write) = match self.connect(false).await { [INFO] [stdout] | | -------- ----- ------------------------- [INFO] [stdout] | | | | | | [INFO] [stdout] | | | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 166 | | Ok(t) => t, [INFO] [stdout] ... | [INFO] [stdout] 176 | | let mut stored_writer = self.writer.lock().await; [INFO] [stdout] | | ----- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 182 | | if let Err(e) = self.subscribe_stored().await { [INFO] [stdout] | | ----- [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 197 | | let res = match read.read(&mut buf).await { [INFO] [stdout] | | --- ------------------------- [INFO] [stdout] | | | | | [INFO] [stdout] | | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 206 | | Err(e) => { [INFO] [stdout] | | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | | *self.writer.lock().await = None; [INFO] [stdout] | | ----- ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 239 | | } [INFO] [stdout] 240 | | })) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `stream` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redis-pubsub` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "5fe0f529e569f8d43699ea3db60760b835960e9816c1f5d49eac2a79223edfda", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5fe0f529e569f8d43699ea3db60760b835960e9816c1f5d49eac2a79223edfda", kill_on_drop: false }` [INFO] [stdout] 5fe0f529e569f8d43699ea3db60760b835960e9816c1f5d49eac2a79223edfda