[INFO] fetching crate redeye 0.3.0... [INFO] checking redeye-0.3.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate redeye 0.3.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate redeye 0.3.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate redeye 0.3.0 [INFO] finished tweaking crates.io crate redeye 0.3.0 [INFO] tweaked toml for crates.io crate redeye 0.3.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate redeye 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 14ab6d8c55e73a77935df2bb748c5aef20c27658964575d6d1bf18a0f865acae [INFO] running `Command { std: "docker" "start" "-a" "14ab6d8c55e73a77935df2bb748c5aef20c27658964575d6d1bf18a0f865acae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "14ab6d8c55e73a77935df2bb748c5aef20c27658964575d6d1bf18a0f865acae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14ab6d8c55e73a77935df2bb748c5aef20c27658964575d6d1bf18a0f865acae", kill_on_drop: false }` [INFO] [stdout] 14ab6d8c55e73a77935df2bb748c5aef20c27658964575d6d1bf18a0f865acae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a876311b3e674b36392514f7e075f222a0979e885d9c444175e28e1f5b070c0d [INFO] running `Command { std: "docker" "start" "-a" "a876311b3e674b36392514f7e075f222a0979e885d9c444175e28e1f5b070c0d", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling syn v1.0.16 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Compiling failure_derive v0.1.7 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling serde v1.0.105 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking rustc-demangle v0.1.16 [INFO] [stderr] Checking unicode-width v0.1.7 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling num-integer v0.1.42 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Compiling backtrace-sys v0.1.34 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking backtrace v0.3.45 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Checking regex v1.3.5 [INFO] [stderr] Checking serde_json v1.0.48 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Checking failure v0.1.7 [INFO] [stderr] Checking redeye v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/redeye/parser.rs:328:59 [INFO] [stdout] | [INFO] [stdout] 328 | fn apply<'a>(&'a self, line: &'a str) -> RedeyeResult { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/redeye/parser.rs:328:59 [INFO] [stdout] | [INFO] [stdout] 328 | fn apply<'a>(&'a self, line: &'a str) -> RedeyeResult { [INFO] [stdout] | -- lifetime `'a` declared here ^^^^^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/redeye/types.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | #[derive(Fail, Debug)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_RedeyeError` [INFO] [stdout] 32 | pub enum RedeyeError { [INFO] [stdout] | ----------- `RedeyeError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/redeye/types.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | #[derive(Fail, Debug)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_RedeyeError` [INFO] [stdout] 32 | pub enum RedeyeError { [INFO] [stdout] | ----------- `RedeyeError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:642:13 [INFO] [stdout] | [INFO] [stdout] 637 | let inner = ParserImpl::new(Regex::new(r"^(.+)$").unwrap()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 638 | let res = inner.apply(""); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 642 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:666:13 [INFO] [stdout] | [INFO] [stdout] 648 | let inner = ParserImpl::new(Regex::new(r"^([^\s]+)\s([^\s]+)$").unwrap()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 649 | let res = inner [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 666 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:684:13 [INFO] [stdout] | [INFO] [stdout] 672 | let inner = ParserImpl::new(Regex::new(r"^([^\s]+)\s([^\s]+)$").unwrap()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 673 | let res = inner [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 684 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:709:13 [INFO] [stdout] | [INFO] [stdout] 690 | let inner = ParserImpl::new(Regex::new(r"^\[(.+)\]$").unwrap()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 691 | let res = inner [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 709 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:726:13 [INFO] [stdout] | [INFO] [stdout] 715 | let inner = ParserImpl::new(Regex::new(r"^\[(.+)\]$").unwrap()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 716 | let res = inner [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 726 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:742:13 [INFO] [stdout] | [INFO] [stdout] 732 | let inner = ParserImpl::new(Regex::new(r"^(.+)$").unwrap()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 733 | let res = inner [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 742 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:760:13 [INFO] [stdout] | [INFO] [stdout] 748 | let inner = ParserImpl::new(Regex::new(r"^(.+)$").unwrap()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 749 | let res = inner [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 760 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:779:13 [INFO] [stdout] | [INFO] [stdout] 766 | let inner = ParserImpl::new(Regex::new(r"^(.+)$").unwrap()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 767 | let res = inner [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 779 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:808:13 [INFO] [stdout] | [INFO] [stdout] 785 | let inner = ParserImpl::new(Regex::new(r"^([^\s]+)\s([^\s]+)$").unwrap()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 786 | let res = inner [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 808 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:828:13 [INFO] [stdout] | [INFO] [stdout] 814 | let inner = ParserImpl::new(Regex::new(r"^([^\s]+)\s([^\s]+)$").unwrap()); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 815 | let res = inner [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 828 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:845:13 [INFO] [stdout] | [INFO] [stdout] 840 | let c = single_val_capture(line); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 841 | let res = parse_timestamp(&c, 2 /* shouldn't exist */, line, COMMON_LOG_TIMESTAMP); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 845 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:857:13 [INFO] [stdout] | [INFO] [stdout] 852 | let c = single_val_capture(line); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 853 | let res = parse_timestamp(&c, 1, line, COMMON_LOG_TIMESTAMP); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 857 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:869:13 [INFO] [stdout] | [INFO] [stdout] 864 | let c = single_val_capture(line); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 865 | let res = parse_timestamp(&c, 1, line, COMMON_LOG_TIMESTAMP); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 869 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:889:13 [INFO] [stdout] | [INFO] [stdout] 876 | let c = single_val_capture(line); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 877 | let res = parse_timestamp(&c, 1, line, COMMON_LOG_TIMESTAMP); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 889 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:901:13 [INFO] [stdout] | [INFO] [stdout] 896 | let c = single_val_capture(line); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 897 | let res = parse_text_value(&c, 2 /* shouldn't exist */, line); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 901 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:913:13 [INFO] [stdout] | [INFO] [stdout] 908 | let c = single_val_capture(line); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 909 | let res = parse_text_value(&c, 1, line); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 913 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:927:13 [INFO] [stdout] | [INFO] [stdout] 920 | let c = single_val_capture(line); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 921 | let res = parse_text_value(&c, 1, line); [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 927 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:939:13 [INFO] [stdout] | [INFO] [stdout] 934 | let c = single_val_capture(line); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 935 | let res = parse_int_value(&c, 2 /* shouldn't exist */, line); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 939 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:951:13 [INFO] [stdout] | [INFO] [stdout] 946 | let c = single_val_capture(line); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 947 | let res = parse_int_value(&c, 1, line); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 951 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:963:13 [INFO] [stdout] | [INFO] [stdout] 958 | let c = single_val_capture(line); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 959 | let res = parse_int_value(&c, 1, line); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 963 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, RedeyeError>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/redeye/parser.rs:977:13 [INFO] [stdout] | [INFO] [stdout] 970 | let c = single_val_capture(line); [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 971 | let res = parse_int_value(&c, 1, line); [INFO] [stdout] | --- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 977 | v => panic!("Unexpected result: {:?}", v), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/redeye/types.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | #[derive(Fail, Debug)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_RedeyeError` [INFO] [stdout] 32 | pub enum RedeyeError { [INFO] [stdout] | ----------- `RedeyeError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/redeye/types.rs:31:10 [INFO] [stdout] | [INFO] [stdout] 31 | #[derive(Fail, Debug)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_RedeyeError` [INFO] [stdout] 32 | pub enum RedeyeError { [INFO] [stdout] | ----------- `RedeyeError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `redeye` (lib test) due to 22 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a876311b3e674b36392514f7e075f222a0979e885d9c444175e28e1f5b070c0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a876311b3e674b36392514f7e075f222a0979e885d9c444175e28e1f5b070c0d", kill_on_drop: false }` [INFO] [stdout] a876311b3e674b36392514f7e075f222a0979e885d9c444175e28e1f5b070c0d