[INFO] fetching crate really-notify 0.1.0... [INFO] checking really-notify-0.1.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate really-notify 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate really-notify 0.1.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate really-notify 0.1.0 [INFO] finished tweaking crates.io crate really-notify 0.1.0 [INFO] tweaked toml for crates.io crate really-notify 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate really-notify 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e69d6196be4b8652422683cc222641d0fb57f5ebc9ffc60d4fa8896bb2fceb96 [INFO] running `Command { std: "docker" "start" "-a" "e69d6196be4b8652422683cc222641d0fb57f5ebc9ffc60d4fa8896bb2fceb96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e69d6196be4b8652422683cc222641d0fb57f5ebc9ffc60d4fa8896bb2fceb96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e69d6196be4b8652422683cc222641d0fb57f5ebc9ffc60d4fa8896bb2fceb96", kill_on_drop: false }` [INFO] [stdout] e69d6196be4b8652422683cc222641d0fb57f5ebc9ffc60d4fa8896bb2fceb96 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 60d01e788121a35b4c805b4f363c9857d457aa0a00bdca5d111f30acf45a3c70 [INFO] running `Command { std: "docker" "start" "-a" "60d01e788121a35b4c805b4f363c9857d457aa0a00bdca5d111f30acf45a3c70", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.60 [INFO] [stderr] Compiling unicode-ident v1.0.9 [INFO] [stderr] Compiling quote v1.0.28 [INFO] [stderr] Compiling libc v0.2.146 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling rustix v0.37.20 [INFO] [stderr] Compiling tokio v1.28.2 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Checking aho-corasick v1.0.2 [INFO] [stderr] Checking regex-syntax v0.7.2 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Compiling syn v2.0.18 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking regex v1.8.4 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking is-terminal v0.4.7 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling bitmask-enum v2.1.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking really-notify v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 99 | async fn run(self, sender: mpsc::Sender) { [INFO] [stdout] | ---- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | let notify = Arc::new(Notify::new()); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 132 | / select! { [INFO] [stdout] 133 | | _ = notify.notified() => { [INFO] [stdout] 134 | | let target = loop { [INFO] [stdout] 135 | | match self.read_target().await { [INFO] [stdout] ... | [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Arc` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:123:13 [INFO] [stdout] | [INFO] [stdout] 99 | async fn run(self, sender: mpsc::Sender) { [INFO] [stdout] | ---- ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | let notify = Arc::new(Notify::new()); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 132 | / select! { [INFO] [stdout] 133 | | _ = notify.notified() => { [INFO] [stdout] 134 | | let target = loop { [INFO] [stdout] 135 | | match self.read_target().await { [INFO] [stdout] ... | [INFO] [stdout] 153 | | } [INFO] [stdout] 154 | | } [INFO] [stdout] | |_____________- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inotify.rs:133:32 [INFO] [stdout] | [INFO] [stdout] 130 | / stream! { [INFO] [stdout] 131 | | let mut buf = [0u8; EVENT_SIZE + NAME_MAX + 1]; [INFO] [stdout] 132 | | loop { [INFO] [stdout] 133 | | let read_len = self.stream.read(&mut buf[..EVENT_SIZE + NAME_MAX + 1]).await?; [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inotify.rs:133:32 [INFO] [stdout] | [INFO] [stdout] 130 | / stream! { [INFO] [stdout] 131 | | let mut buf = [0u8; EVENT_SIZE + NAME_MAX + 1]; [INFO] [stdout] 132 | | loop { [INFO] [stdout] 133 | | let read_len = self.stream.read(&mut buf[..EVENT_SIZE + NAME_MAX + 1]).await?; [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... | [INFO] [stdout] 157 | | } [INFO] [stdout] 158 | | } [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `mask` and `cookie` are never read [INFO] [stdout] --> src/inotify.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 63 | pub struct INotifyEvent { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 64 | pub watch_descriptor: WatchHandle, [INFO] [stdout] 65 | pub mask: INotifyMask, [INFO] [stdout] | ^^^^ [INFO] [stdout] 66 | pub cookie: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `INotifyEvent` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `really-notify` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `mask` and `cookie` are never read [INFO] [stdout] --> src/inotify.rs:65:9 [INFO] [stdout] | [INFO] [stdout] 63 | pub struct INotifyEvent { [INFO] [stdout] | ------------ fields in this struct [INFO] [stdout] 64 | pub watch_descriptor: WatchHandle, [INFO] [stdout] 65 | pub mask: INotifyMask, [INFO] [stdout] | ^^^^ [INFO] [stdout] 66 | pub cookie: u32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `INotifyEvent` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `really-notify` (lib) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "60d01e788121a35b4c805b4f363c9857d457aa0a00bdca5d111f30acf45a3c70", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "60d01e788121a35b4c805b4f363c9857d457aa0a00bdca5d111f30acf45a3c70", kill_on_drop: false }` [INFO] [stdout] 60d01e788121a35b4c805b4f363c9857d457aa0a00bdca5d111f30acf45a3c70