[INFO] fetching crate reactors 0.1.4... [INFO] checking reactors-0.1.4 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate reactors 0.1.4 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate reactors 0.1.4 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate reactors 0.1.4 [INFO] finished tweaking crates.io crate reactors 0.1.4 [INFO] tweaked toml for crates.io crate reactors 0.1.4 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 143 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (available: v0.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (available: v2.6.0) [INFO] [stderr] Adding clap v3.2.25 (available: v4.5.18) [INFO] [stderr] Adding clap_lex v0.2.4 (available: v0.7.2) [INFO] [stderr] Adding criterion v0.4.0 (available: v0.5.1) [INFO] [stderr] Adding encode_unicode v0.3.6 (available: v1.0.0) [INFO] [stderr] Adding env_logger v0.7.1 (available: v0.11.5) [INFO] [stderr] Adding hashbrown v0.12.3 (available: v0.14.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (available: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding humantime v1.3.0 (available: v2.1.0) [INFO] [stderr] Adding indexmap v1.9.3 (available: v2.5.0) [INFO] [stderr] Adding itertools v0.10.5 (available: v0.13.0) [INFO] [stderr] Adding os_str_bytes v6.6.1 (available: v7.0.0) [INFO] [stderr] Adding pretty_env_logger v0.4.0 (available: v0.5.0) [INFO] [stderr] Adding quick-error v1.2.3 (available: v2.0.1) [INFO] [stderr] Adding unicode-width v0.1.14 (available: v0.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 210f97781e7e51741c4cc5ba9c424fb62ee401df6598de1e1951f40100459ea2 [INFO] running `Command { std: "docker" "start" "-a" "210f97781e7e51741c4cc5ba9c424fb62ee401df6598de1e1951f40100459ea2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "210f97781e7e51741c4cc5ba9c424fb62ee401df6598de1e1951f40100459ea2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "210f97781e7e51741c4cc5ba9c424fb62ee401df6598de1e1951f40100459ea2", kill_on_drop: false }` [INFO] [stdout] 210f97781e7e51741c4cc5ba9c424fb62ee401df6598de1e1951f40100459ea2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 976475b572e24a65b56281d155d3a5c31c5916f029e6f206d5610acc4b6bccc4 [INFO] running `Command { std: "docker" "start" "-a" "976475b572e24a65b56281d155d3a5c31c5916f029e6f206d5610acc4b6bccc4", kill_on_drop: false }` [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling portable-atomic v1.8.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking serde v1.0.210 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling anyhow v1.0.89 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking clap_builder v4.5.18 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking os_socketaddr v0.2.5 [INFO] [stderr] Checking errno v0.3.9 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking pretty_env_logger v0.4.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking clap v4.5.18 [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking futures-test v0.3.30 [INFO] [stderr] Checking reactors v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `macos` [INFO] [stdout] --> src/io/poller.rs:275:17 [INFO] [stdout] | [INFO] [stdout] 275 | #[cfg(all(test, target_family = "macos"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_family` are: `unix`, `wasm`, and `windows` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/io/file/file_unix.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | file.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 201 | let _ = file.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking criterion v0.4.0 [INFO] [stdout] error: this value of type `Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/file.rs:53:15 [INFO] [stdout] | [INFO] [stdout] 14 | let mut reactor = IoReactor::default(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let file = File::create(reactor.clone(), dir.join("test")).unwrap(); [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | [INFO] [stdout] 20 | let mut write_stream = file.to_write_stream(None); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | [INFO] [stdout] 22 | let mut read_stream = file.to_read_stream(None); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | match read.poll_unpin(&mut noop_context()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `macos` [INFO] [stdout] --> src/io/poller.rs:275:17 [INFO] [stdout] | [INFO] [stdout] 275 | #[cfg(all(test, target_family = "macos"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_family` are: `unix`, `wasm`, and `windows` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reactors` (test "file") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::task::Poll>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/socket/tcp.rs:331:19 [INFO] [stdout] | [INFO] [stdout] 264 | let mut reactor = IoReactor::default(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | let mut acceptor = TcpAcceptor::new(reactor.clone(), listen_addr, None).unwrap(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 274 | let mut connect = TcpStream::connect(reactor.clone(), listen_addr, None, None); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | [INFO] [stdout] 276 | let client_connection: TcpStream; [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 293 | let server_connection: TcpStream; [INFO] [stdout] | ----------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | let mut write_stream = client_connection.to_write_stream(None); [INFO] [stdout] | ---------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | let mut read_stream = server_connection.to_read_stream(None); [INFO] [stdout] | --------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 331 | match read.poll_unpin(&mut noop_context()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::task::Poll, std::net::SocketAddr)>, std::io::Error>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/io/socket/udp.rs:238:19 [INFO] [stdout] | [INFO] [stdout] 171 | let mut reactor = IoReactor::default(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let server = UdpSocket::new(reactor.clone(), server_addr).unwrap(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | [INFO] [stdout] 179 | let client = UdpSocket::new(reactor.clone(), client_addr).unwrap(); [INFO] [stdout] | ------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | [INFO] [stdout] 181 | let mut server_write_stream = server.to_write_stream(None); [INFO] [stdout] | ----------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | let mut server_read_stream = server.to_read_stream(1024, None); [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | [INFO] [stdout] 184 | let mut client_write_stream = client.to_write_stream(None); [INFO] [stdout] | ----------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | let mut client_read_stream = client.to_read_stream(1024, None); [INFO] [stdout] | ---------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | match try_next.poll_unpin(&mut noop_context()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `into_raw_fd` that must be used [INFO] [stdout] --> src/io/file/file_unix.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | file.into_raw_fd(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the raw file descriptor may leak resources [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 201 | let _ = file.into_raw_fd(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reactors` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "976475b572e24a65b56281d155d3a5c31c5916f029e6f206d5610acc4b6bccc4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "976475b572e24a65b56281d155d3a5c31c5916f029e6f206d5610acc4b6bccc4", kill_on_drop: false }` [INFO] [stdout] 976475b572e24a65b56281d155d3a5c31c5916f029e6f206d5610acc4b6bccc4