[INFO] fetching crate rbe 0.1.26... [INFO] checking rbe-0.1.26 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate rbe 0.1.26 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate rbe 0.1.26 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rbe 0.1.26 [INFO] finished tweaking crates.io crate rbe 0.1.26 [INFO] tweaked toml for crates.io crate rbe 0.1.26 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 21afc798d60495bdb2c8891a8888b2a95d7c8bf764b14f18a2a1e7f40b65aaae [INFO] running `Command { std: "docker" "start" "-a" "21afc798d60495bdb2c8891a8888b2a95d7c8bf764b14f18a2a1e7f40b65aaae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "21afc798d60495bdb2c8891a8888b2a95d7c8bf764b14f18a2a1e7f40b65aaae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21afc798d60495bdb2c8891a8888b2a95d7c8bf764b14f18a2a1e7f40b65aaae", kill_on_drop: false }` [INFO] [stdout] 21afc798d60495bdb2c8891a8888b2a95d7c8bf764b14f18a2a1e7f40b65aaae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b7f71b982464af187e360b27b413ebd9ebef92c1a828d81edc3c19db40d25d4 [INFO] running `Command { std: "docker" "start" "-a" "4b7f71b982464af187e360b27b413ebd9ebef92c1a828d81edc3c19db40d25d4", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.210 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking hashbag v0.1.12 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking serde_json v1.0.128 [INFO] [stderr] Checking rbe v0.1.26 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `rbe1::Rbe` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rbe1_matcher.rs:51:15 [INFO] [stdout] | [INFO] [stdout] 49 | let mut pending = Pending::new(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut processed: Vec<(K, V)> = Vec::new(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | match self.matches_iter(iter, &mut pending, &mut processed) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rbe` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `rbe1::Rbe` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rbe1_matcher.rs:51:15 [INFO] [stdout] | [INFO] [stdout] 49 | let mut pending = Pending::new(); [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut processed: Vec<(K, V)> = Vec::new(); [INFO] [stdout] | ------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | match self.matches_iter(iter, &mut pending, &mut processed) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/rbe1.rs:463:9 [INFO] [stdout] | [INFO] [stdout] 460 | fn deriv_a_1_1_and_b_opt_with_a() { [INFO] [stdout] | --------------------------------- move the `impl` block outside of this function `deriv_a_1_1_and_b_opt_with_a` [INFO] [stdout] ... [INFO] [stdout] 463 | impl Ref for i32 {} [INFO] [stdout] | ^^^^^---^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Ref` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/rbe1.rs:497:9 [INFO] [stdout] | [INFO] [stdout] 496 | fn deriv_symbol_b_2_3() { [INFO] [stdout] | ----------------------- move the `impl` block outside of this function `deriv_symbol_b_2_3` [INFO] [stdout] 497 | impl Key for String {} [INFO] [stdout] | ^^^^^---^^^^^------ [INFO] [stdout] | | | [INFO] [stdout] | | `String` is not local [INFO] [stdout] | `Key` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rbe` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "4b7f71b982464af187e360b27b413ebd9ebef92c1a828d81edc3c19db40d25d4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b7f71b982464af187e360b27b413ebd9ebef92c1a828d81edc3c19db40d25d4", kill_on_drop: false }` [INFO] [stdout] 4b7f71b982464af187e360b27b413ebd9ebef92c1a828d81edc3c19db40d25d4