[INFO] fetching crate ratchet_core 1.0.3... [INFO] checking ratchet_core-1.0.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate ratchet_core 1.0.3 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ratchet_core 1.0.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ratchet_core 1.0.3 [INFO] finished tweaking crates.io crate ratchet_core 1.0.3 [INFO] tweaked toml for crates.io crate ratchet_core 1.0.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 98 packages to latest compatible versions [INFO] [stderr] Adding convert_case v0.4.0 (available: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (available: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v1.1.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (available: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (available: v1.0.2) [INFO] [stderr] Adding mio v0.8.11 (available: v1.0.2) [INFO] [stderr] Adding tokio v1.38.1 (available: v1.40.0) [INFO] [stderr] Adding tokio-macros v2.3.0 (available: v2.4.0) [INFO] [stderr] Adding tokio-util v0.7.1 (available: v0.7.12) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (available: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (available: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (available: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (available: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 54f9c45fd28a9a5ce9c4d2d054111eccba90e8a69824a361c39c69b34c8023db [INFO] running `Command { std: "docker" "start" "-a" "54f9c45fd28a9a5ce9c4d2d054111eccba90e8a69824a361c39c69b34c8023db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "54f9c45fd28a9a5ce9c4d2d054111eccba90e8a69824a361c39c69b34c8023db", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54f9c45fd28a9a5ce9c4d2d054111eccba90e8a69824a361c39c69b34c8023db", kill_on_drop: false }` [INFO] [stdout] 54f9c45fd28a9a5ce9c4d2d054111eccba90e8a69824a361c39c69b34c8023db [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a6351de1e5feb9a72decb65bff1fc4c92045536b0cf136c09b9f574e41e38f26 [INFO] running `Command { std: "docker" "start" "-a" "a6351de1e5feb9a72decb65bff1fc4c92045536b0cf136c09b9f574e41e38f26", kill_on_drop: false }` [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking ratchet_ext v1.0.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking tokio v1.38.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.1 [INFO] [stderr] Checking ratchet_core v1.0.3 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `Result, errors::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/server/tests.rs:75:15 [INFO] [stdout] | [INFO] [stdout] 74 | async fn t(request: Request<()>, name: HeaderName) { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | match exec_request(request).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option<::SplitEncoder>, Option<::SplitDecoder>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext.rs:248:15 [INFO] [stdout] | [INFO] [stdout] 247 | fn reunite(encoder: Self::SplitEncoder, decoder: Self::SplitDecoder) -> Self { [INFO] [stdout] | ------- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | match (encoder.0, decoder.0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ratchet_core` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `(Option<::SplitEncoder>, Option<::SplitDecoder>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ext.rs:248:15 [INFO] [stdout] | [INFO] [stdout] 247 | fn reunite(encoder: Self::SplitEncoder, decoder: Self::SplitDecoder) -> Self { [INFO] [stdout] | ------- ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 248 | match (encoder.0, decoder.0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Item` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framed/tests.rs:90:9 [INFO] [stdout] | [INFO] [stdout] 48 | let mut framed = FramedIo::new( [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let mut rx_buf = BytesMut::default(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let message_type = framed.read_next(&mut rx_buf, &mut NoExt).await.unwrap(); [INFO] [stdout] | ------------ these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | i => panic!("Unexpected message type: {:?}", i), [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `O` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/framed/tests.rs:196:12 [INFO] [stdout] | [INFO] [stdout] 191 | fn ok_eq(result: Result, eq: O) [INFO] [stdout] | ------ -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | Ok(actual) => assert_eq!(actual, eq), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Result, errors::Error>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/client/tests.rs:343:15 [INFO] [stdout] | [INFO] [stdout] 327 | let mut buf = BytesMut::new(); [INFO] [stdout] | ------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 328 | let mut machine = ClientHandshake::new( [INFO] [stdout] | ----------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | match machine.read().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `errors::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/client/tests.rs:665:17 [INFO] [stdout] | [INFO] [stdout] 663 | |result| match result { [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 664 | Ok(handshake_result) => assert!(handshake_result.extension.take().unwrap().0), [INFO] [stdout] 665 | Err(e) => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `errors::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/client/tests.rs:683:17 [INFO] [stdout] | [INFO] [stdout] 681 | |result| match result { [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 682 | Ok(handshake_result) => assert!(!handshake_result.extension.take().unwrap().0), [INFO] [stdout] 683 | Err(e) => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `errors::Error` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handshake/server/tests.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 300 | let (mut client, server) = mock(); [INFO] [stdout] | ---------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 303 | let result = accept_with( [INFO] [stdout] | ------ [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 315 | Err(e) => { [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a method [INFO] [stdout] --> src/ws.rs:574:9 [INFO] [stdout] | [INFO] [stdout] 574 | / pub async fn write_frame( [INFO] [stdout] 575 | | &mut self, [INFO] [stdout] 576 | | buf: A, [INFO] [stdout] 577 | | opcode: OpCode, [INFO] [stdout] ... | [INFO] [stdout] 580 | | where [INFO] [stdout] 581 | | A: AsRef<[u8]>, [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | missing_docs, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: missing documentation for a method [INFO] [stdout] --> src/ws.rs:600:9 [INFO] [stdout] | [INFO] [stdout] 600 | pub async fn read_frame(&mut self, read_buffer: &mut BytesMut) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ratchet_core` (lib test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "a6351de1e5feb9a72decb65bff1fc4c92045536b0cf136c09b9f574e41e38f26", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6351de1e5feb9a72decb65bff1fc4c92045536b0cf136c09b9f574e41e38f26", kill_on_drop: false }` [INFO] [stdout] a6351de1e5feb9a72decb65bff1fc4c92045536b0cf136c09b9f574e41e38f26