[INFO] fetching crate railsgun 3.0.1... [INFO] checking railsgun-3.0.1 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate railsgun 3.0.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate railsgun 3.0.1 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate railsgun 3.0.1 [INFO] finished tweaking crates.io crate railsgun 3.0.1 [INFO] tweaked toml for crates.io crate railsgun 3.0.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 26 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7a25d9f594d389d93b878eb9d66a917a8e0e633ce7a14536597fb9a73c28d035 [INFO] running `Command { std: "docker" "start" "-a" "7a25d9f594d389d93b878eb9d66a917a8e0e633ce7a14536597fb9a73c28d035", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7a25d9f594d389d93b878eb9d66a917a8e0e633ce7a14536597fb9a73c28d035", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a25d9f594d389d93b878eb9d66a917a8e0e633ce7a14536597fb9a73c28d035", kill_on_drop: false }` [INFO] [stdout] 7a25d9f594d389d93b878eb9d66a917a8e0e633ce7a14536597fb9a73c28d035 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d51cdf694a2bd5cc77e66383cdc4a0d088190996ca631646627fd9d10999c890 [INFO] running `Command { std: "docker" "start" "-a" "d51cdf694a2bd5cc77e66383cdc4a0d088190996ca631646627fd9d10999c890", kill_on_drop: false }` [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking railsgun v3.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:107:1 [INFO] [stdout] | [INFO] [stdout] 107 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Result, Result)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:50:15 [INFO] [stdout] | [INFO] [stdout] 48 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | ) -> Result { [INFO] [stdout] 50 | match (self, res1) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Result, Result, Result)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 75 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | ) -> Result { [INFO] [stdout] 77 | match (self, res1, res2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Result, Result, Result, Result)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:107:15 [INFO] [stdout] | [INFO] [stdout] 105 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | ) -> Result { [INFO] [stdout] 107 | match (self, res1, res2, res3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Result, Result, Result, Result, Result)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:140:15 [INFO] [stdout] | [INFO] [stdout] 138 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | ) -> Result { [INFO] [stdout] 140 | match (self, res1, res2, res3, res4) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:200:15 [INFO] [stdout] | [INFO] [stdout] 198 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | ) -> Option { [INFO] [stdout] 200 | match (self, res1) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:227:15 [INFO] [stdout] | [INFO] [stdout] 224 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | match (self, res1, res2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option, Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:255:15 [INFO] [stdout] | [INFO] [stdout] 253 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | ) -> Option { [INFO] [stdout] 255 | match (self, res1, res2, res3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option, Option, Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:285:15 [INFO] [stdout] | [INFO] [stdout] 283 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | ) -> Option { [INFO] [stdout] 285 | match (self, res1, res2, res3, res4) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/option_extended/mod.rs:581:15 [INFO] [stdout] | [INFO] [stdout] 577 | fn zip_with(self, other: Option, f: F) -> Option [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 581 | match (self, other) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `railsgun` (lib) due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `(Result, Result)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:50:15 [INFO] [stdout] | [INFO] [stdout] 48 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | ) -> Result { [INFO] [stdout] 50 | match (self, res1) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Result, Result, Result)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:77:15 [INFO] [stdout] | [INFO] [stdout] 75 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | ) -> Result { [INFO] [stdout] 77 | match (self, res1, res2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Result, Result, Result, Result)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:107:15 [INFO] [stdout] | [INFO] [stdout] 105 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | ) -> Result { [INFO] [stdout] 107 | match (self, res1, res2, res3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Result, Result, Result, Result, Result)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:140:15 [INFO] [stdout] | [INFO] [stdout] 138 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | ) -> Result { [INFO] [stdout] 140 | match (self, res1, res2, res3, res4) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:200:15 [INFO] [stdout] | [INFO] [stdout] 198 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | ) -> Option { [INFO] [stdout] 200 | match (self, res1) { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:227:15 [INFO] [stdout] | [INFO] [stdout] 224 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 227 | match (self, res1, res2) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option, Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:255:15 [INFO] [stdout] | [INFO] [stdout] 253 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 254 | ) -> Option { [INFO] [stdout] 255 | match (self, res1, res2, res3) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option, Option, Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rail_merge/mod.rs:285:15 [INFO] [stdout] | [INFO] [stdout] 283 | op: F, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 284 | ) -> Option { [INFO] [stdout] 285 | match (self, res1, res2, res3, res4) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option, Option)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/option_extended/mod.rs:581:15 [INFO] [stdout] | [INFO] [stdout] 577 | fn zip_with(self, other: Option, f: F) -> Option [INFO] [stdout] | - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 581 | match (self, other) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Empty` is never constructed [INFO] [stdout] --> src/iterators/map_iterator.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 31 | enum TestError { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] 32 | Empty, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TestError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `Custom` is never constructed [INFO] [stdout] --> src/iterators/mod.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 103 | enum TestError { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] 104 | Empty, [INFO] [stdout] 105 | Custom, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TestError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `railsgun` (lib test) due to 10 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d51cdf694a2bd5cc77e66383cdc4a0d088190996ca631646627fd9d10999c890", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d51cdf694a2bd5cc77e66383cdc4a0d088190996ca631646627fd9d10999c890", kill_on_drop: false }` [INFO] [stdout] d51cdf694a2bd5cc77e66383cdc4a0d088190996ca631646627fd9d10999c890