[INFO] fetching crate radixdb 0.2.5... [INFO] checking radixdb-0.2.5 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate radixdb 0.2.5 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate radixdb 0.2.5 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate radixdb 0.2.5 [INFO] finished tweaking crates.io crate radixdb 0.2.5 [INFO] tweaked toml for crates.io crate radixdb 0.2.5 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate radixdb 0.2.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 52c44089d1e943aba4d0aee2b69837de5546417898188a45f192de3aa27dfe65 [INFO] running `Command { std: "docker" "start" "-a" "52c44089d1e943aba4d0aee2b69837de5546417898188a45f192de3aa27dfe65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "52c44089d1e943aba4d0aee2b69837de5546417898188a45f192de3aa27dfe65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52c44089d1e943aba4d0aee2b69837de5546417898188a45f192de3aa27dfe65", kill_on_drop: false }` [INFO] [stdout] 52c44089d1e943aba4d0aee2b69837de5546417898188a45f192de3aa27dfe65 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1b7353f38ef2aed5ce9b6e9a4db9f00f37f4e0b01c64fc9c6329b06e8cc813bf [INFO] running `Command { std: "docker" "start" "-a" "1b7353f38ef2aed5ce9b6e9a4db9f00f37f4e0b01c64fc9c6329b06e8cc813bf", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.133 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling unicode-ident v1.0.4 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Compiling syn v1.0.100 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Compiling anyhow v1.0.65 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking inplace-vec-builder v0.1.1 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking thousands v0.2.0 [INFO] [stderr] Compiling hex-literal v0.3.4 [INFO] [stderr] Checking obey v0.1.0 [INFO] [stderr] Compiling lock_api v0.4.8 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking proptest v1.0.0 [INFO] [stderr] Checking env_logger v0.9.1 [INFO] [stderr] Compiling visibility v0.0.1 [INFO] [stderr] Checking radixdb v0.2.5 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `TreeNode` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/mod.rs:1666:12 [INFO] [stdout] | [INFO] [stdout] 1665 | let node = node.clone_shortened(store, n)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1666 | Ok(self.convert_node(&node.as_ref(), store)?.downcast()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/mod.rs:2093:14 [INFO] [stdout] | [INFO] [stdout] 2082 | ab: A, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 2083 | bc: Option>, [INFO] [stdout] 2084 | bb: B, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2093 | Ok(match (ac, bc) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/mod.rs:2299:14 [INFO] [stdout] | [INFO] [stdout] 2288 | ab: A, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 2289 | bc: Option>, [INFO] [stdout] 2290 | bb: B, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2299 | Ok(match (ac, bc) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/mod.rs:2565:14 [INFO] [stdout] | [INFO] [stdout] 2554 | ab: A, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 2555 | bc: Option>, [INFO] [stdout] 2556 | bb: B, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2565 | Ok(match (ac, bc) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `radixdb` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Blob<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/tests.rs:273:26 [INFO] [stdout] | [INFO] [stdout] 272 | let (k, v) = e.unwrap(); [INFO] [stdout] | - - these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | (k.to_vec(), v.load(&store).unwrap().to_vec()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `node::TreeNode` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/mod.rs:1666:12 [INFO] [stdout] | [INFO] [stdout] 1665 | let node = node.clone_shortened(store, n)?; [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 1666 | Ok(self.convert_node(&node.as_ref(), store)?.downcast()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/mod.rs:2093:14 [INFO] [stdout] | [INFO] [stdout] 2082 | ab: A, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 2083 | bc: Option>, [INFO] [stdout] 2084 | bb: B, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2093 | Ok(match (ac, bc) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/mod.rs:2299:14 [INFO] [stdout] | [INFO] [stdout] 2288 | ab: A, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 2289 | bc: Option>, [INFO] [stdout] 2290 | bb: B, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2299 | Ok(match (ac, bc) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `(Option>, Option>)` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node/mod.rs:2565:14 [INFO] [stdout] | [INFO] [stdout] 2554 | ab: A, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 2555 | bc: Option>, [INFO] [stdout] 2556 | bb: B, [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 2565 | Ok(match (ac, bc) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Blob<'_>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 43 | fn get_bytes(tree: RadixTree) -> Vec { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let store = VecStore(Arc::new(Mutex::new(Vec::new()))); [INFO] [stdout] | ----- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let mut tree = tree.try_attached(store.clone()).unwrap(); [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let id = tree.try_reattach().unwrap(); [INFO] [stdout] 47 | store.read(&id).unwrap().to_vec() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `radixdb` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "1b7353f38ef2aed5ce9b6e9a4db9f00f37f4e0b01c64fc9c6329b06e8cc813bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b7353f38ef2aed5ce9b6e9a4db9f00f37f4e0b01c64fc9c6329b06e8cc813bf", kill_on_drop: false }` [INFO] [stdout] 1b7353f38ef2aed5ce9b6e9a4db9f00f37f4e0b01c64fc9c6329b06e8cc813bf