[INFO] fetching crate prqlc-parser 0.13.0... [INFO] checking prqlc-parser-0.13.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate prqlc-parser 0.13.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate prqlc-parser 0.13.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate prqlc-parser 0.13.0 [INFO] finished tweaking crates.io crate prqlc-parser 0.13.0 [INFO] tweaked toml for crates.io crate prqlc-parser 0.13.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 68 packages to latest compatible versions [INFO] [stderr] Adding encode_unicode v0.3.6 (available: v1.0.0) [INFO] [stderr] Adding windows-sys v0.52.0 (available: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f9b52b65dcbd2053a3aeaf0de4f3de4bb781043a7cecce5cea8b616c8079c857 [INFO] running `Command { std: "docker" "start" "-a" "f9b52b65dcbd2053a3aeaf0de4f3de4bb781043a7cecce5cea8b616c8079c857", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f9b52b65dcbd2053a3aeaf0de4f3de4bb781043a7cecce5cea8b616c8079c857", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9b52b65dcbd2053a3aeaf0de4f3de4bb781043a7cecce5cea8b616c8079c857", kill_on_drop: false }` [INFO] [stdout] f9b52b65dcbd2053a3aeaf0de4f3de4bb781043a7cecce5cea8b616c8079c857 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 44b275e1ba831913e0bc4da2eefc667eb4b907c6ba6431ee5ca3969e62ed98b3 [INFO] running `Command { std: "docker" "start" "-a" "44b275e1ba831913e0bc4da2eefc667eb4b907c6ba6431ee5ca3969e62ed98b3", kill_on_drop: false }` [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling ref-cast v1.0.23 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling serde_json v1.0.128 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling ref-cast-impl v1.0.23 [INFO] [stderr] Compiling enum-as-inner v0.6.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling schemars_derive v1.0.0-alpha.15 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking chumsky v0.9.3 [INFO] [stderr] Checking schemars v1.0.0-alpha.15 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking globset v0.4.15 [INFO] [stderr] Checking prqlc-parser v0.13.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking insta v1.40.0 [INFO] [stdout] warning: unexpected `cfg` condition name: `coverage` [INFO] [stdout] --> src/parser/expr.rs:371:11 [INFO] [stdout] | [INFO] [stdout] 371 | #[cfg(not(coverage))] [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(coverage)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(coverage)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `coverage` [INFO] [stdout] --> src/parser/expr.rs:371:11 [INFO] [stdout] | [INFO] [stdout] 371 | #[cfg(not(coverage))] [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `fmt_debug`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(coverage)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(coverage)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/pr/types.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn into_relation(self) -> Option> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | self.kind.into_array().ok()?.kind.into_tuple().ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `prqlc-parser` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Box` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/pr/types.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 141 | pub fn into_relation(self) -> Option> { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | self.kind.into_array().ok()?.kind.into_tuple().ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/parser/mod.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 206 | fn test_no_doc_comment_in_with_doc_comment() { [INFO] [stdout] | -------------------------------------------- move the `impl` block outside of this function `test_no_doc_comment_in_with_doc_comment` [INFO] [stdout] 207 | impl SupportsDocComment for String { [INFO] [stdout] | ^^^^^------------------^^^^^------ [INFO] [stdout] | | | [INFO] [stdout] | | `String` is not local [INFO] [stdout] | `SupportsDocComment` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this lint may become deny-by-default in the edition 2024 and higher, see the tracking issue [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `prqlc-parser` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "44b275e1ba831913e0bc4da2eefc667eb4b907c6ba6431ee5ca3969e62ed98b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "44b275e1ba831913e0bc4da2eefc667eb4b907c6ba6431ee5ca3969e62ed98b3", kill_on_drop: false }` [INFO] [stdout] 44b275e1ba831913e0bc4da2eefc667eb4b907c6ba6431ee5ca3969e62ed98b3