[INFO] fetching crate protobuf-parser 0.1.3... [INFO] checking protobuf-parser-0.1.3 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate protobuf-parser 0.1.3 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate protobuf-parser 0.1.3 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate protobuf-parser 0.1.3 [INFO] finished tweaking crates.io crate protobuf-parser 0.1.3 [INFO] tweaked toml for crates.io crate protobuf-parser 0.1.3 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 3 packages to latest compatible versions [INFO] [stderr] Adding memchr v1.0.2 (available: v2.7.4) [INFO] [stderr] Adding nom v3.2.1 (available: v7.1.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb4cc8d1a01d5b1fd1db1fc1e6fff889ca61e753efc34b2643c73a2148040174 [INFO] running `Command { std: "docker" "start" "-a" "bb4cc8d1a01d5b1fd1db1fc1e6fff889ca61e753efc34b2643c73a2148040174", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb4cc8d1a01d5b1fd1db1fc1e6fff889ca61e753efc34b2643c73a2148040174", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb4cc8d1a01d5b1fd1db1fc1e6fff889ca61e753efc34b2643c73a2148040174", kill_on_drop: false }` [INFO] [stdout] bb4cc8d1a01d5b1fd1db1fc1e6fff889ca61e753efc34b2643c73a2148040174 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3ea220095b9d60419aa6a4b4dd03ea839ace18dd13a32ebc8711ebd365845b72 [INFO] running `Command { std: "docker" "start" "-a" "3ea220095b9d60419aa6a4b4dd03ea839ace18dd13a32ebc8711ebd365845b72", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.159 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking nom v3.2.1 [INFO] [stderr] Checking protobuf-parser v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/parser.rs:49:1 [INFO] [stdout] | [INFO] [stdout] 49 | /// word break: multispace or comment [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/parser.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | b'a'...b'z' | b'A'...b'Z' | b'0'...b'9' | b'_' | b'.' => true, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/parser.rs:10:27 [INFO] [stdout] | [INFO] [stdout] 10 | b'a'...b'z' | b'A'...b'Z' | b'0'...b'9' | b'_' | b'.' => true, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/parser.rs:10:41 [INFO] [stdout] | [INFO] [stdout] 10 | b'a'...b'z' | b'A'...b'Z' | b'0'...b'9' | b'_' | b'.' => true, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/parser.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 21 | / named!( [INFO] [stdout] 22 | | word_ref<&str>, [INFO] [stdout] | | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] 23 | | map_res!(take_while!(is_word), str::from_utf8) [INFO] [stdout] 24 | | ); [INFO] [stdout] | |_- lifetime `'a` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/parser.rs:115:14 [INFO] [stdout] | [INFO] [stdout] 114 | / named!( [INFO] [stdout] 115 | | key_val<(&str, &str)>, [INFO] [stdout] | | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] 116 | | do_parse!( [INFO] [stdout] 117 | | tag!("[") >> many0!(br) >> key: word_ref >> many0!(br) >> tag!("=") >> many0!(br) [INFO] [stdout] ... | [INFO] [stdout] 120 | | ) [INFO] [stdout] 121 | | ); [INFO] [stdout] | |_- lifetime `'a` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/parser.rs:115:20 [INFO] [stdout] | [INFO] [stdout] 114 | / named!( [INFO] [stdout] 115 | | key_val<(&str, &str)>, [INFO] [stdout] | | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] 116 | | do_parse!( [INFO] [stdout] 117 | | tag!("[") >> many0!(br) >> key: word_ref >> many0!(br) >> tag!("=") >> many0!(br) [INFO] [stdout] ... | [INFO] [stdout] 120 | | ) [INFO] [stdout] 121 | | ); [INFO] [stdout] | |_- lifetime `'a` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/parser.rs:49:1 [INFO] [stdout] | [INFO] [stdout] 49 | /// word break: multispace or comment [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/parser.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | b'a'...b'z' | b'A'...b'Z' | b'0'...b'9' | b'_' | b'.' => true, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(ellipsis_inclusive_range_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/parser.rs:10:27 [INFO] [stdout] | [INFO] [stdout] 10 | b'a'...b'z' | b'A'...b'Z' | b'0'...b'9' | b'_' | b'.' => true, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `...` range patterns are deprecated [INFO] [stdout] --> src/parser.rs:10:41 [INFO] [stdout] | [INFO] [stdout] 10 | b'a'...b'z' | b'A'...b'Z' | b'0'...b'9' | b'_' | b'.' => true, [INFO] [stdout] | ^^^ help: use `..=` for an inclusive range [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/parser.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 21 | / named!( [INFO] [stdout] 22 | | word_ref<&str>, [INFO] [stdout] | | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] 23 | | map_res!(take_while!(is_word), str::from_utf8) [INFO] [stdout] 24 | | ); [INFO] [stdout] | |_- lifetime `'a` declared here [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/parser.rs:115:14 [INFO] [stdout] | [INFO] [stdout] 114 | / named!( [INFO] [stdout] 115 | | key_val<(&str, &str)>, [INFO] [stdout] | | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] 116 | | do_parse!( [INFO] [stdout] 117 | | tag!("[") >> many0!(br) >> key: word_ref >> many0!(br) >> tag!("=") >> many0!(br) [INFO] [stdout] ... | [INFO] [stdout] 120 | | ) [INFO] [stdout] 121 | | ); [INFO] [stdout] | |_- lifetime `'a` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/parser.rs:115:20 [INFO] [stdout] | [INFO] [stdout] 114 | / named!( [INFO] [stdout] 115 | | key_val<(&str, &str)>, [INFO] [stdout] | | ^ this elided lifetime gets resolved as `'a` [INFO] [stdout] 116 | | do_parse!( [INFO] [stdout] 117 | | tag!("[") >> many0!(br) >> key: word_ref >> many0!(br) >> tag!("=") >> many0!(br) [INFO] [stdout] ... | [INFO] [stdout] 120 | | ) [INFO] [stdout] 121 | | ); [INFO] [stdout] | |_- lifetime `'a` declared here [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `IResult<&[u8], FileDescriptor>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:232:15 [INFO] [stdout] | [INFO] [stdout] 230 | pub fn parse>(file: S) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | let file = file.as_ref(); [INFO] [stdout] 232 | match file_descriptor(file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `protobuf-parser` (lib) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `Message` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:391:40 [INFO] [stdout] | [INFO] [stdout] 390 | let mess = message(msg.as_bytes()); [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 391 | if let ::nom::IResult::Done(_, mess) = mess { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Message` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:478:40 [INFO] [stdout] | [INFO] [stdout] 477 | let mess = message(msg.as_bytes()); [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 478 | if let ::nom::IResult::Done(_, mess) = mess { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Message` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:506:40 [INFO] [stdout] | [INFO] [stdout] 505 | let mess = message(msg.as_bytes()); [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 506 | if let ::nom::IResult::Done(_, mess) = mess { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `Message` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:522:40 [INFO] [stdout] | [INFO] [stdout] 521 | let mess = message(msg.as_bytes()); [INFO] [stdout] | ---- [INFO] [stdout] | | [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] | these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 522 | if let ::nom::IResult::Done(_, mess) = mess { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `IResult<&[u8], FileDescriptor>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:232:15 [INFO] [stdout] | [INFO] [stdout] 230 | pub fn parse>(file: S) -> Result { [INFO] [stdout] | ---- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | let file = file.as_ref(); [INFO] [stdout] 232 | match file_descriptor(file) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `protobuf-parser` (lib test) due to 6 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3ea220095b9d60419aa6a4b4dd03ea839ace18dd13a32ebc8711ebd365845b72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3ea220095b9d60419aa6a4b4dd03ea839ace18dd13a32ebc8711ebd365845b72", kill_on_drop: false }` [INFO] [stdout] 3ea220095b9d60419aa6a4b4dd03ea839ace18dd13a32ebc8711ebd365845b72