[INFO] fetching crate protobuf-codegen3 2.28.2... [INFO] checking protobuf-codegen3-2.28.2 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate protobuf-codegen3 2.28.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate protobuf-codegen3 2.28.2 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate protobuf-codegen3 2.28.2 [INFO] finished tweaking crates.io crate protobuf-codegen3 2.28.2 [INFO] tweaked toml for crates.io crate protobuf-codegen3 2.28.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate protobuf-codegen3 2.28.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 847b66424fb41aa90d963fbaec8f30e4d62471ad635af3ff331651b20f0fe146 [INFO] running `Command { std: "docker" "start" "-a" "847b66424fb41aa90d963fbaec8f30e4d62471ad635af3ff331651b20f0fe146", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "847b66424fb41aa90d963fbaec8f30e4d62471ad635af3ff331651b20f0fe146", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "847b66424fb41aa90d963fbaec8f30e4d62471ad635af3ff331651b20f0fe146", kill_on_drop: false }` [INFO] [stdout] 847b66424fb41aa90d963fbaec8f30e4d62471ad635af3ff331651b20f0fe146 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8c38f71d3bc34a9341c50363a730969663fb283f2c084322b93dc213cd8583f0 [INFO] running `Command { std: "docker" "start" "-a" "8c38f71d3bc34a9341c50363a730969663fb283f2c084322b93dc213cd8583f0", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling protobuf v2.28.0 [INFO] [stderr] Checking protobuf-codegen3 v2.28.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message.rs:97:45 [INFO] [stdout] | [INFO] [stdout] 52 | impl<'a> MessageGen<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 97 | fn required_fields(&'a self) -> Vec<&'a FieldGen> { [INFO] [stdout] | ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message.rs:107:44 [INFO] [stdout] | [INFO] [stdout] 52 | impl<'a> MessageGen<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 107 | fn message_fields(&'a self) -> Vec<&'a FieldGen> { [INFO] [stdout] | ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message.rs:114:49 [INFO] [stdout] | [INFO] [stdout] 52 | impl<'a> MessageGen<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 114 | fn fields_except_oneof(&'a self) -> Vec<&'a FieldGen> { [INFO] [stdout] | ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message.rs:118:49 [INFO] [stdout] | [INFO] [stdout] 52 | impl<'a> MessageGen<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 118 | fn fields_except_group(&'a self) -> Vec<&'a FieldGen> { [INFO] [stdout] | ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message.rs:125:59 [INFO] [stdout] | [INFO] [stdout] 52 | impl<'a> MessageGen<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 125 | fn fields_except_oneof_and_group(&'a self) -> Vec<&'a FieldGen> { [INFO] [stdout] | ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message.rs:97:45 [INFO] [stdout] | [INFO] [stdout] 52 | impl<'a> MessageGen<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 97 | fn required_fields(&'a self) -> Vec<&'a FieldGen> { [INFO] [stdout] | ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(elided_named_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message.rs:107:44 [INFO] [stdout] | [INFO] [stdout] 52 | impl<'a> MessageGen<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 107 | fn message_fields(&'a self) -> Vec<&'a FieldGen> { [INFO] [stdout] | ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message.rs:114:49 [INFO] [stdout] | [INFO] [stdout] 52 | impl<'a> MessageGen<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 114 | fn fields_except_oneof(&'a self) -> Vec<&'a FieldGen> { [INFO] [stdout] | ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message.rs:118:49 [INFO] [stdout] | [INFO] [stdout] 52 | impl<'a> MessageGen<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 118 | fn fields_except_group(&'a self) -> Vec<&'a FieldGen> { [INFO] [stdout] | ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: elided lifetime has a name [INFO] [stdout] --> src/message.rs:125:59 [INFO] [stdout] | [INFO] [stdout] 52 | impl<'a> MessageGen<'a> { [INFO] [stdout] | -- lifetime `'a` declared here [INFO] [stdout] ... [INFO] [stdout] 125 | fn fields_except_oneof_and_group(&'a self) -> Vec<&'a FieldGen> { [INFO] [stdout] | ^^^^^^^^ this elided lifetime gets resolved as `'a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `rust_types_values::RustType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/field/mod.rs:1665:47 [INFO] [stdout] | [INFO] [stdout] 1661 | let get_xxx_return_type = self.get_xxx_return_type(); [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1665 | let ref rust_type_message = match self.elem().rust_storage_type() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `rust_types_values::RustType` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/field/mod.rs:1665:47 [INFO] [stdout] | [INFO] [stdout] 1661 | let get_xxx_return_type = self.get_xxx_return_type(); [INFO] [stdout] | ------------------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1665 | let ref rust_type_message = match self.elem().rust_storage_type() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/field/mod.rs:235:9 [INFO] [stdout] | [INFO] [stdout] 233 | Message( [INFO] [stdout] | ------- field in this variant [INFO] [stdout] 234 | String, [INFO] [stdout] 235 | String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FieldElem` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 235 | (), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/field/mod.rs:240:18 [INFO] [stdout] | [INFO] [stdout] 240 | Enum(String, String, RustIdent), [INFO] [stdout] | ---- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FieldElem` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 240 | Enum(String, (), RustIdent), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `protobuf-codegen3` (lib test) due to 2 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/field/mod.rs:235:9 [INFO] [stdout] | [INFO] [stdout] 233 | Message( [INFO] [stdout] | ------- field in this variant [INFO] [stdout] 234 | String, [INFO] [stdout] 235 | String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FieldElem` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 235 | (), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `1` is never read [INFO] [stdout] --> src/field/mod.rs:240:18 [INFO] [stdout] | [INFO] [stdout] 240 | Enum(String, String, RustIdent), [INFO] [stdout] | ---- ^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `FieldElem` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 240 | Enum(String, (), RustIdent), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `protobuf-codegen3` (lib) due to 2 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8c38f71d3bc34a9341c50363a730969663fb283f2c084322b93dc213cd8583f0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c38f71d3bc34a9341c50363a730969663fb283f2c084322b93dc213cd8583f0", kill_on_drop: false }` [INFO] [stdout] 8c38f71d3bc34a9341c50363a730969663fb283f2c084322b93dc213cd8583f0