[INFO] fetching crate polyhorn-core 0.4.0... [INFO] checking polyhorn-core-0.4.0 against try#7014e13d5becc920d4bea3cd87942c8a13d359bf+rustflags=-Dtail_expr_drop_order for pr-129864 [INFO] extracting crate polyhorn-core 0.4.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate polyhorn-core 0.4.0 on toolchain 7014e13d5becc920d4bea3cd87942c8a13d359bf [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate polyhorn-core 0.4.0 [INFO] finished tweaking crates.io crate polyhorn-core 0.4.0 [INFO] tweaked toml for crates.io crate polyhorn-core 0.4.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 20 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 73c2285db57298c15b1e15459d5c3e5eae38bb013e0f6672c198c008a14b5adc [INFO] running `Command { std: "docker" "start" "-a" "73c2285db57298c15b1e15459d5c3e5eae38bb013e0f6672c198c008a14b5adc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "73c2285db57298c15b1e15459d5c3e5eae38bb013e0f6672c198c008a14b5adc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73c2285db57298c15b1e15459d5c3e5eae38bb013e0f6672c198c008a14b5adc", kill_on_drop: false }` [INFO] [stdout] 73c2285db57298c15b1e15459d5c3e5eae38bb013e0f6672c198c008a14b5adc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:ceb6ea022f8a89cebbe621bb4987e73a935bd40dfbb726f832cfff4742a5b95a" "/opt/rustwide/cargo-home/bin/cargo" "+7014e13d5becc920d4bea3cd87942c8a13d359bf" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 046637ef8e5afc0dcba0f589f93c1f9fbb4c65b3aaf64f8e6506fe9eb6f38003 [INFO] running `Command { std: "docker" "start" "-a" "046637ef8e5afc0dcba0f589f93c1f9fbb4c65b3aaf64f8e6506fe9eb6f38003", kill_on_drop: false }` [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking polyhorn-core v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this value of type `FuturesUnordered>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evloop.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 105 | pub async fn main(mut self) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let mut tasks = FuturesUnordered::>>>>::new(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `FuturesUnordered>>>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/evloop.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 105 | pub async fn main(mut self) { [INFO] [stdout] | -------- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let mut tasks = FuturesUnordered::>>>>::new(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this value of type `std::option::Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/weak.rs:28:33 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn with_link(&self, op: F) -> Option [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | if let Some(instance) = self.instance.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/disposable.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Disposable(Box); [INFO] [stdout] | ---------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: types that do not implement `Drop` can still have drop glue, consider instead using `std::mem::needs_drop` to detect whether a type is trivially dropped [INFO] [stdout] --> src/disposable.rs:1:31 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Disposable(Box); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dyn_drop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `polyhorn-core` (lib) due to 3 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this value of type `std::option::Option>>` has significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/weak.rs:28:33 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn with_link(&self, op: F) -> Option [INFO] [stdout] | -- these local bindings with significant drop implementation may observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | if let Some(instance) = self.instance.upgrade() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/disposable.rs:1:23 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Disposable(Box); [INFO] [stdout] | ---------- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing this field [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: types that do not implement `Drop` can still have drop glue, consider instead using `std::mem::needs_drop` to detect whether a type is trivially dropped [INFO] [stdout] --> src/disposable.rs:1:31 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Disposable(Box); [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dyn_drop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `polyhorn-core` (lib test) due to 3 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "046637ef8e5afc0dcba0f589f93c1f9fbb4c65b3aaf64f8e6506fe9eb6f38003", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "046637ef8e5afc0dcba0f589f93c1f9fbb4c65b3aaf64f8e6506fe9eb6f38003", kill_on_drop: false }` [INFO] [stdout] 046637ef8e5afc0dcba0f589f93c1f9fbb4c65b3aaf64f8e6506fe9eb6f38003